The initial configuration was missing rules that caused the linter to skip
certain important checks. This update adds the missing rules to ensure the
code quality checks are correctly enforced across the repository.
Signed-off-by: Adharsh <adharshunni0007@gmail.com>
```
WARN The configuration comments are not migrated.
WARN Details about the migration: https://golangci-lint.run/product/migration-guide/
WARN The configuration `run.timeout` is ignored. By default, in v2, the timeout is disabled.
```
I've backported comment and timeout
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
Since Helm is going through breaking changes with Helm v4, the version path to
Helm needs to be updated.
Signed-off-by: Matt Farina <matt.farina@suse.com>
Multiple changes were made to pass linting. Some Go built-in names
are being used for variables (e.g., min). This happens in the Go
source itself including the Go standard library and is not always
a bad practice.
To handle allowing some built-in names to be used the linter config
is updated to allow (via opt-in) some names to pass. This allows us
to still check for re-use of Go built-in names and opt-in to any
new uses.
There were also several cases where a value was checked for nil
before checking its length when this is already handled by len()
or the types default value. These were cleaned up.
The license validation was updated because it was checking everything
in the .git directory including all remote content that was local.
The previous vendor directory was from a time prior to Go modules
when Helm handled dependencies differently. It was no longer needed.
Signed-off-by: Matt Farina <matt.farina@suse.com>
golint which is used as one of the sublinters in golangci-lint is deprecated.
It is replaced with revive which is a drop-in replacement.
Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com>
Co-authored-by: Martin Mulholland <mmulholl@redhat.com>
* fix: add new static linter and fix issues it found
Signed-off-by: Matt Butcher <matt.butcher@microsoft.com>
* fixed two additional linter errors.
Signed-off-by: Matt Butcher <matt.butcher@microsoft.com>
Matthieu MOREL
Robert Sirchia
Adharsh
Justen Stall
Benoit Tigeot
Matt Farina
Fish-pro
yanggang
Martin Hickey
Adam Reese
Matt Butcher
sayboras
Matthew Fisher