5 Commits (50dcd39ba5a3c50bd046b5b539c2c7e6ac68aea1)

Author	SHA1	Message	Date
Marc Khouzam	a8369db802	feat(comp): Isolate go completion framework better ... Signed-off-by: Marc Khouzam <marc.khouzam@montreal.ca>	5 years ago
Marc Khouzam	0095e32001	feat(test): add some completion tests ... Signed-off-by: Marc Khouzam <marc.khouzam@montreal.ca>	5 years ago
Marc Khouzam	90548c591d	feat(comp): Don't use error codes for completion ... To use error codes to indicate completion directive to the completion script had us use os.Exit() in the __complete command. This prevented go tests calling the __complete command from succeeding. Another option was to return an error containing an error code (like is done for helm plugins) instead of calling os.Exit(). However such an approach requires a change in how helm handles the returned error of a Cobra command; although we can do this for Helm, it would be an annoying requirement for other programs if we ever push this completion logic into Cobra. The chosen solution instead is to printout the directive at the end of the list of completions, and have the completion script extract it. Note that we print both the completions and directive to stdout. It would have been interesting to print the completions to stdout and the directive to stderr; however, it is very complicated for the completion script to extract both stdout and stderr to different variables, and even if possible, such code would not be portable to many shells. Printing both to stdout is much simpler. Signed-off-by: Marc Khouzam <marc.khouzam@montreal.ca>	5 years ago
Marc Khouzam	62c9c34d49	feat(comp): Dynamic completion of flags in Go ... Conflicts: cmd/helm/completion/complete.go cmd/helm/root.go Conflicts: cmd/helm/root.go Signed-off-by: Marc Khouzam <marc.khouzam@montreal.ca>	5 years ago
Marc Khouzam	9240e78124	feat(comp): Dynamic completion of arguments in Go ... Signed-off-by: Marc Khouzam <marc.khouzam@montreal.ca>	5 years ago