3e06a8a440
Merge pull request #31512 from benoittgt/31508-client-go
...
fix: correct LDFLAGS path for default Kubernetes version
10 months ago
b740071279
Merge pull request #31342 from TerryHowe/chore-remove-mitchellh-dependency-3
...
chore: replace github.com/mitchellh/copystructure
10 months ago
b6a8c65216
fix: correct LDFLAGS path for default Kubernetes version
...
The Makefile LDFLAGS were pointing to an incorrect package path
(helm.sh/helm/v4/pkg/chart/common/util) that doesn't exist, causing
the k8sVersionMajor and k8sVersionMinor variables to silently fail
to be set. This left the hardcoded defaults (1.20) in place.
After this fix, `helm template` now correctly defaults to Kubernetes
v1.34.0 (matching the bundled client-go version) instead of v1.20.0,
ensuring charts render with current stable API versions.
Testing scenario:
```sh
cat > /tmp/test-chart/Chart.yaml << 'EOF'
apiVersion: v2
name: test-chart
version: 1.0.0
kubeVersion: ">= 1.28.0-0"
EOF
./bin/helm template test-release /tmp/test-chart
cat > /tmp/test-chart-fail/Chart.yaml << 'EOF'
apiVersion: v2
name: test-chart-fail
version: 1.0.0
kubeVersion: ">= 1.35.0-0"
EOF
./bin/helm template test-release /tmp/test-chart-fail
Exit code 1
Error: chart requires kubeVersion: >= 1.35.0-0 which is incompatible with Kubernetes v1.34.0
```
Fixes #31508
Closes #31501
Closes #31502
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
10 months ago
acf331a005
fix: improve plugin name validation err messages early via unmarshalling
...
- Add strict YAML unmarshalling for v1 plugins (d.KnownFields)
- Add comprehensive test coverage for validPluginName regex
- Maintain backwards compatibility for legacy plugins
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
10 months ago
9e1e3d21c5
fix: Make invalid name error message more similar and move tests
...
Follow Scott comment\
https://github.com/helm/helm/pull/31491/files#r2524933784
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
10 months ago
cf077ceb27
fix: focus only on plugin name but give more info about what we get
...
And improve test
Follow Scott comment:
> here I would have a list of valid and invalid names based on pattern, with a check and intended outcome for each one so that we comprehensively cover the rules.
https://github.com/helm/helm/pull/31491/files#r2524820312
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
10 months ago
f4b139a82c
Make validation error similar and explicit for both metadatas
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
10 months ago
c04e18e452
fix: improve plugin name validation error messages
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
10 months ago
51a9bc5157
Merge pull request #31473 from TerryHowe/fix-only-run-release-on-helm-helm
...
fix: do not run release workflow on forks
10 months ago
dd328fbd3b
Merge pull request #31503 from crenshaw-dev/patch-1
...
docs: Fix LFX Health Score badge URL in README.md
10 months ago
ecf1c0d886
Merge pull request #11739 from Fish-pro/fix/statement
...
docs: fix syntax errors in the document
10 months ago
faa0adcb38
Fix syntax errors in the document
...
Signed-off-by: Fish-pro <zechun.chen@daocloud.io>
10 months ago
e7ac8fe3b8
Merge pull request #30984 from fm1ck3y/bug/index-concurrency
...
feat(concurrency): allow concurrent dependency build with atomic file write
10 months ago
d57fb45648
Merge pull request #31469 from saimanojk1/issue-31454
...
Convert pkg/cmd/load_plugins.go to slog
10 months ago
20bc8565f0
Merge pull request #31494 from helm/dependabot/go_modules/main/k8s-io-fe7f9b34ac
...
chore(deps): bump the k8s-io group with 7 updates
10 months ago
c81e267653
chore(deps): bump the k8s-io group with 7 updates
...
Bumps the k8s-io group with 7 updates:
| Package | From | To |
| --- | --- | --- |
| [k8s.io/api](https://github.com/kubernetes/api ) | `0.34.1` | `0.34.2` |
| [k8s.io/apiextensions-apiserver](https://github.com/kubernetes/apiextensions-apiserver ) | `0.34.1` | `0.34.2` |
| [k8s.io/apimachinery](https://github.com/kubernetes/apimachinery ) | `0.34.1` | `0.34.2` |
| [k8s.io/apiserver](https://github.com/kubernetes/apiserver ) | `0.34.1` | `0.34.2` |
| [k8s.io/cli-runtime](https://github.com/kubernetes/cli-runtime ) | `0.34.1` | `0.34.2` |
| [k8s.io/client-go](https://github.com/kubernetes/client-go ) | `0.34.1` | `0.34.2` |
| [k8s.io/kubectl](https://github.com/kubernetes/kubectl ) | `0.34.1` | `0.34.2` |
Updates `k8s.io/api` from 0.34.1 to 0.34.2
- [Commits](https://github.com/kubernetes/api/compare/v0.34.1...v0.34.2 )
Updates `k8s.io/apiextensions-apiserver` from 0.34.1 to 0.34.2
- [Release notes](https://github.com/kubernetes/apiextensions-apiserver/releases )
- [Commits](https://github.com/kubernetes/apiextensions-apiserver/compare/v0.34.1...v0.34.2 )
Updates `k8s.io/apimachinery` from 0.34.1 to 0.34.2
- [Commits](https://github.com/kubernetes/apimachinery/compare/v0.34.1...v0.34.2 )
Updates `k8s.io/apiserver` from 0.34.1 to 0.34.2
- [Commits](https://github.com/kubernetes/apiserver/compare/v0.34.1...v0.34.2 )
Updates `k8s.io/cli-runtime` from 0.34.1 to 0.34.2
- [Commits](https://github.com/kubernetes/cli-runtime/compare/v0.34.1...v0.34.2 )
Updates `k8s.io/client-go` from 0.34.1 to 0.34.2
- [Changelog](https://github.com/kubernetes/client-go/blob/master/CHANGELOG.md )
- [Commits](https://github.com/kubernetes/client-go/compare/v0.34.1...v0.34.2 )
Updates `k8s.io/kubectl` from 0.34.1 to 0.34.2
- [Commits](https://github.com/kubernetes/kubectl/compare/v0.34.1...v0.34.2 )
---
updated-dependencies:
- dependency-name: k8s.io/api
dependency-version: 0.34.2
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: k8s-io
- dependency-name: k8s.io/apiextensions-apiserver
dependency-version: 0.34.2
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: k8s-io
- dependency-name: k8s.io/apimachinery
dependency-version: 0.34.2
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: k8s-io
- dependency-name: k8s.io/apiserver
dependency-version: 0.34.2
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: k8s-io
- dependency-name: k8s.io/cli-runtime
dependency-version: 0.34.2
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: k8s-io
- dependency-name: k8s.io/client-go
dependency-version: 0.34.2
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: k8s-io
- dependency-name: k8s.io/kubectl
dependency-version: 0.34.2
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: k8s-io
...
Signed-off-by: dependabot[bot] <support@github.com>
10 months ago
fdad981960
Merge pull request #31495 from helm/dependabot/go_modules/main/golang.org/x/crypto-0.44.0
...
chore(deps): bump golang.org/x/crypto from 0.43.0 to 0.44.0
10 months ago
40856bf50c
docs: Fix LFX Health Score badge URL in README.md
...
The URL must have changed, because the badge is currently broken in the readme.
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
10 months ago
9861687ad5
Merge pull request #31474 from helm/dependabot/github_actions/main/golangci/golangci-lint-action-9.0.0
...
chore(deps): bump golangci/golangci-lint-action from 8.0.0 to 9.0.0
10 months ago
fb82e0e513
chore(deps): bump golang.org/x/crypto from 0.43.0 to 0.44.0
...
Bumps [golang.org/x/crypto](https://github.com/golang/crypto ) from 0.43.0 to 0.44.0.
- [Commits](https://github.com/golang/crypto/compare/v0.43.0...v0.44.0 )
---
updated-dependencies:
- dependency-name: golang.org/x/crypto
dependency-version: 0.44.0
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
10 months ago
60ee841934
Merge pull request #31482 from helm/dependabot/go_modules/main/github.com/tetratelabs/wazero-1.10.1
...
chore(deps): bump github.com/tetratelabs/wazero from 1.9.0 to 1.10.1
10 months ago
ff1c144ffb
Merge pull request #31488 from helm/gjenkins8-patch-2-1
...
Publish Helm v4 -> `helm-latest-version`
10 months ago
72a84fb369
chore(deps): bump github.com/tetratelabs/wazero from 1.9.0 to 1.10.1
...
Bumps [github.com/tetratelabs/wazero](https://github.com/tetratelabs/wazero ) from 1.9.0 to 1.10.1.
- [Release notes](https://github.com/tetratelabs/wazero/releases )
- [Commits](https://github.com/tetratelabs/wazero/compare/v1.9.0...v1.10.1 )
---
updated-dependencies:
- dependency-name: github.com/tetratelabs/wazero
dependency-version: 1.10.1
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
10 months ago
f4204b5eef
Merge pull request #31476 from helm/dependabot/go_modules/main/sigs.k8s.io/kustomize/kyaml-0.21.0
...
chore(deps): bump sigs.k8s.io/kustomize/kyaml from 0.20.1 to 0.21.0
10 months ago
1208cbbe7e
Merge pull request #31480 from helm/dependabot/go_modules/main/golang.org/x/term-0.37.0
...
chore(deps): bump golang.org/x/term from 0.36.0 to 0.37.0
10 months ago
0a5ed96dba
Merge pull request #31485 from mattfarina/get-helm-4
...
Adding script to download Helm v4
10 months ago
e4353dc8db
Publish Helm v4 -> `helm-latest-version`
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
10 months ago
5ae85868d4
Adding script to download Helm v4
...
Signed-off-by: Matt Farina <matt.farina@suse.com>
10 months ago
76d772af6e
Merge pull request #31318 from helm/gjenkins/fix_helm4_release
...
fix: Helm v4 release distribution & `get-helm-3` script
10 months ago
6cd0bf8171
chore(deps): bump golang.org/x/term from 0.36.0 to 0.37.0
...
Bumps [golang.org/x/term](https://github.com/golang/term ) from 0.36.0 to 0.37.0.
- [Commits](https://github.com/golang/term/compare/v0.36.0...v0.37.0 )
---
updated-dependencies:
- dependency-name: golang.org/x/term
dependency-version: 0.37.0
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
10 months ago
d8c4040336
refactor: use strings.Builder to improve performance
...
Signed-off-by: promalert <promalert@outlook.com>
10 months ago
0089a07bb8
chore(deps): bump sigs.k8s.io/kustomize/kyaml from 0.20.1 to 0.21.0
...
Bumps [sigs.k8s.io/kustomize/kyaml](https://github.com/kubernetes-sigs/kustomize ) from 0.20.1 to 0.21.0.
- [Release notes](https://github.com/kubernetes-sigs/kustomize/releases )
- [Commits](https://github.com/kubernetes-sigs/kustomize/compare/api/v0.20.1...api/v0.21.0 )
---
updated-dependencies:
- dependency-name: sigs.k8s.io/kustomize/kyaml
dependency-version: 0.21.0
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
10 months ago
7a8535810a
chore(deps): bump golangci/golangci-lint-action from 8.0.0 to 9.0.0
...
Bumps [golangci/golangci-lint-action](https://github.com/golangci/golangci-lint-action ) from 8.0.0 to 9.0.0.
- [Release notes](https://github.com/golangci/golangci-lint-action/releases )
- [Commits](4afd733a84...0a35821d5c
10 months ago
0ee89d2d4e
Merge pull request #31418 from tisonkun/typo
...
chore: fix typo of public field
10 months ago
02312a1cf2
Update pkg/cmd/flags.go
...
Co-authored-by: George Jenkins <gvjenkins@gmail.com>
Signed-off-by: Benoit Tigeot <benoittgt@users.noreply.github.com>
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
10 months ago
277c140c87
Error strategy list match help
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
10 months ago
5f6fa437b2
Prevent surprising failure with SDK when timeout is not set
...
While testing SDK features for v4. I was surprised with the error:
"reporter failed to start: event funnel closed: context deadline exceeded"
This occurs when no timeout is set:
```
upgradeClient := action.NewUpgrade(actionConfig)
upgradeClient.WaitStrategy = kube.StatusWatcherStrategy
// When Timeout is zero, the status wait uses a context with zero timeout which
// immediately expires causing "context deadline exceeded" errors.
upgradeClient.Timeout = 2 * time.Minute
```
With this patch it will work without specifying.
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
10 months ago
52a282832f
Do not change the default waiting strategy when --wait is not set
...
It is too much a breaking change for a new RC of beta V4.
See comment: https://github.com/helm/helm/pull/31421#discussion_r2465121438
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
10 months ago
11128659aa
Provide more help for SDK user when setting up WaitStrategy
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
10 months ago
8535e9f4ab
Avoid confusion between `--wait` (watcher) and no --wait (hookOnly)
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
10 months ago
1836f37f4d
The default is not HookOnlyStrategy but WaitStrategy
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
10 months ago
a5e110fccd
Make wait strategy selection more obvious
...
It is not clear enough that you need to set --wait=false for a hook only
strategy.
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
10 months ago
e8b0cff45a
Update pkg/cmd/flags.go
...
Co-authored-by: George Jenkins <gvjenkins@gmail.com>
Signed-off-by: Benoit Tigeot <benoittgt@users.noreply.github.com>
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
10 months ago
95e1ee1089
Increase documentation of --wait flag
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
10 months ago
5cbd9b3035
While testing SDK features for v4. I was surprised with the error:
...
> "reporter failed to start: event funnel closed: context deadline exceeded"
It happens when you forget to set a minimal timeout:
```go
upgradeClient := action.NewUpgrade(actionConfig)
upgradeClient.WaitStrategy = kube.StatusWatcherStrategy
// When Timeout is zero, the status wait uses a context with zero timeout which
// immediately expires causing "context deadline exceeded" errors.
upgradeClient.Timeout = 2 * time.Minute
```
Also maybe it might be worth documenting this more clearly. Initial [PR](https://github.com/helm/helm/pull/13604 ) say:
> I have not written any docs, I assume that can be done when we are closer to Helm 4, a lot of it is covered by linking to - https://github.com/kubernetes-sigs/cli-utils/blob/master/pkg/kstatus/README.md
Related:
- https://github.com/helm/helm/pull/31411#issuecomment-3443925663
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
10 months ago
d93ef03ee4
fix: do not run release workflow on forks
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
10 months ago
f352ced42b
Merge pull request #31468 from yardenshoham/issue-31456
...
Rename copilot-instructions.md to AGENTS.md
10 months ago
6de83c5f60
Convert pkg/cmd/load_plugins.go to slog
...
Signed-off-by: saimanojk1 <saimanojk1@hotmail.com>
10 months ago
caff03fb4e
Rename copilot-instructions.md to AGENTS.md
...
As of https://github.blog/changelog/2025-08-28-copilot-coding-agent-now-supports-agents-md-custom-instructions/ , AGENTS.md is supported.
Signed-off-by: Yarden Shoham <git@yardenshoham.com>
10 months ago
d158708fbf
fix(rollback): `errors.Is` instead of string comp
...
Signed-off-by: Hidde Beydals <hidde@hhh.computer>
10 months ago
George Jenkins
Scott Rigby
Benoit Tigeot
Robert Sirchia
Fish-pro
dependabot[bot]
Michael Crenshaw
Matt Farina
promalert
Benoit Tigeot
Terry Howe
saimanojk1
Yarden Shoham
Hidde Beydals