e3897ad6b1
registry/client: use NewClientWithDockerFallback from oras v1.1.0-rc3
...
Uses NewClientWithDockerFallback to always use Docker config and
modifies go.mod to use oras v1.1.0-rc3.
Ref:
- https://github.com/helm/helm/pull/10536#issuecomment-1010144075
- https://github.com/oras-project/oras-go/pull/92
Signed-off-by: Allen Bai <abai@redhat.com>
3 years ago
e08a9270be
HELM_REGISTRY_CONFIG: change default file of registry config to config.json
...
Changes default registry config file from `registry.json` to
`config.json`. This aligns with the `config.json` that is widely used in docker.
Closes: https://github.com/helm/helm/issues/10156
Related: https://github.com/helm/helm/issues/10122
Signed-off-by: Allen Bai <abai@redhat.com>
3 years ago
46aa53ad22
Merge pull request #10521 from scottrigby/adopt-underscore-convention-for-semver-build-metadata
...
For OCI, convert + to _ before pull, and + to _ before push
3 years ago
fed0d31bf5
ensure consistency in registry client Push/Pull function signatures. ensure message is only printed when tags contain a replaced character
...
Signed-off-by: Josh Wolf <josh@wolfs.io>
3 years ago
157ac85ab7
Fix typo. Thanks buildbot. Also comments at 80 chars
...
Signed-off-by: Scott Rigby <scott@r6by.com>
3 years ago
fb0eeebf66
add oci reference validation and tag scoped (+) replacement to registry client Push/Pull
...
Signed-off-by: Josh Wolf <josh@wolfs.io>
3 years ago
292368a64d
Merge pull request #10209 from yxxhero/fix_sa_issue
...
Add more debug msg when helm upgrade
3 years ago
f82896b0b5
add more debug msg when helm upgrade
...
Signed-off-by: yxxhero <aiopsclub@163.com>
3 years ago
ea5d7af200
Merge pull request #10535 from mattfarina/fix-10534
...
Fixing issue where OCI handling early causes a bad message
3 years ago
d02f13c1bf
Merge pull request #10424 from davidxia/patch1
...
docs: Clarify use of --set-file
3 years ago
ee73a0263c
Fixing issue where OCI handling early causes a bad message
...
Note, there is OCI handling later in the funtion that should
handle the situation instead.
Closes #10534
Signed-off-by: Matt Farina <matt.farina@suse.com>
3 years ago
8424bc2b60
Update registry underscore message with semver note for extra clarity
...
Add newline to registry underscore message
Signed-off-by: Scott Rigby <scott@r6by.com>
3 years ago
4aacbc44e0
Move plus/underscore change to inside Client. Compare original ref for strict mode
...
Signed-off-by: Scott Rigby <scott@r6by.com>
3 years ago
39ca699ca7
Merge pull request #9119 from ErmakovDmitriy/master
...
Added flag --list-repo
3 years ago
a30a8481b8
Adding Joe Julian as triage maintainer
...
Signed-off-by: Bridget Kromhout <bridget@kromhout.org>
3 years ago
d9ffe37d37
Merge pull request #9536 from mengjiao-liu/add-install-validate
...
validate release name during install
3 years ago
472eb6f096
For OCI, convert + to _ before pull, and + to _ before push
...
Signed-off-by: Scott Rigby <scott@r6by.com>
3 years ago
94779dc99f
fix(helm): ignore file-not-found error for `helm repo list -o json`
...
Currently, `helm repo list -o json` returns (either `[]` or an english
"no repositories" error message, depending on whether
`$HELM_CONFIG_HOME/repositories.yaml` exists). This PR aligns the two cases
so that it always returns `[]`.
Signed-off-by: Teo Klestrup Röijezon <teo@nullable.se>
3 years ago
b8d3535991
feat(comp): Allow fuzzy matching during completion
...
We had made the assumption that when doing shell completion, we only
needed choices that had for *prefix* what the user had typed.
However, the zsh and fish shells have a more advanced matching system
which first matches on prefix, but if no match is found, then does
more advanced matching attempts, such as sub-strings; fish even matches
on descriptions of completions.
For example,
helm status nginx<tab>
would match releases such as
ingress-nginx
ingress-nginx-release
as long as no release had a prefix of "nginx".
Such fuzzy matching can make completion even more useful for users in
cases where identical prefixes are common.
Signed-off-by: Marc Khouzam <marc.khouzam@montreal.ca>
3 years ago
66fb403804
Merge pull request #10490 from helm/dependabot/go_modules/github.com/docker/docker-20.10.12incompatible
...
chore(deps): bump github.com/docker/docker from 20.10.11+incompatible to 20.10.12+incompatible
3 years ago
160da867d0
validate release name during install
...
Signed-off-by: mengjiao.liu <mengjiao.liu@daocloud.io>
3 years ago
d3dbd65997
Merge pull request #10504 from jayonlau/clean_up
...
Clean up extra spaces
3 years ago
55bb6c307a
lean up extra spaces
...
Although these errors are not important, they affect the code specification.
Signed-off-by: jayonlau <jayonlau@gmail.com>
3 years ago
babbb67f89
chore(deps): bump github.com/docker/docker
...
Bumps [github.com/docker/docker](https://github.com/docker/docker ) from 20.10.11+incompatible to 20.10.12+incompatible.
- [Release notes](https://github.com/docker/docker/releases )
- [Changelog](https://github.com/moby/moby/blob/master/CHANGELOG.md )
- [Commits](https://github.com/docker/docker/compare/v20.10.11...v20.10.12 )
---
updated-dependencies:
- dependency-name: github.com/docker/docker
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
3 years ago
d417878a69
chore(deps): bump github.com/spf13/cobra from 1.2.1 to 1.3.0
...
Bumps [github.com/spf13/cobra](https://github.com/spf13/cobra ) from 1.2.1 to 1.3.0.
- [Release notes](https://github.com/spf13/cobra/releases )
- [Changelog](https://github.com/spf13/cobra/blob/master/CHANGELOG.md )
- [Commits](https://github.com/spf13/cobra/compare/v1.2.1...v1.3.0 )
---
updated-dependencies:
- dependency-name: github.com/spf13/cobra
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
3 years ago
47c2fd78a2
Merge pull request #10488 from mattfarina/bump-k8s-0.23.1
...
Updating Kubernetes packages to those from 1.23.1
3 years ago
141f2dd501
Fix typo
...
Unset the env var before func return in Unit Test
Signed-off-by: Kay Yan <kay.yan@daocloud.io>
3 years ago
5c698e9fa7
Updating Kubernetes packages to those from 1.23.1
...
Signed-off-by: Matt Farina <matt@mattfarina.com>
3 years ago
ca4e926009
Merge pull request #10470 from bridgetkromhout/prydonius-emeritus
...
Moving prydonius to emeritus
3 years ago
5059ae843e
Fix install memory/goroutine leak
...
Signed-off-by: Neven Miculinic <neven.miculinic@gmail.com>
3 years ago
ad1110eaba
Moving prydonius to emeritus
...
Signed-off-by: Bridget Kromhout <bridget@kromhout.org>
3 years ago
679e14cd21
add legal name check
...
Signed-off-by: Kay Yan <kay.yan@daocloud.io>
3 years ago
797a8cd524
Honor --dependency-update flag in upgrade command
...
Signed-off-by: Andrew Block <andy.block@gmail.com>
3 years ago
dd5db7bc40
Remove AssertGoldenBytes test helper
...
The test suite is thereby simplified somewhat.
Signed-off-by: Simon Alling <alling.simon@gmail.com>
3 years ago
0f15b01dfb
Remove runTestActionCmd and use runTestCmd instead
...
`runTestCmd` is identical to `runTestActionCmd` except that it
* runs the command multiple times if the `repeat` property is greater
than zero,
* calls its storage `storage` instead of `store`,
* fails if the `Create` method returns an error, and
* logs a "running cmd" message.
This is most easily demonstrated by copying the functions to their own
files and diffing the files with this command:
git diff --no-index --ignore-space-change --color-words=. runTestActionCmd.go runTestCmd.go
Also, `runTestCmd` is used 32 times; `runTestActionCmd` only 1.
Signed-off-by: Simon Alling <alling.simon@gmail.com>
3 years ago
8ca401398d
Merge pull request #10440 from jkmw/fix/10439
...
Fix memory leak in upgrade action
3 years ago
9a492f8240
Channel should remain open if there is still a routine that wants to write into it
...
Signed-off-by: Jerome Küttner <j.kuettner@mittwald.de>
3 years ago
ad3d2cc8ef
Fix memory leak in upgrade action
...
fixes helm/helm#10439
Signed-off-by: Jerome Küttner <j.kuettner@mittwald.de>
3 years ago
0e6e936ab8
Merge pull request #10410 from helm/dependabot/go_modules/github.com/Masterminds/squirrel-1.5.2
...
chore(deps): bump github.com/Masterminds/squirrel from 1.5.1 to 1.5.2
3 years ago
03d9e7ca62
Merge pull request #10425 from bridgetkromhout/CustomResourceDefinition-typo-fix
...
Bringing over an edit from the helm-www repo
3 years ago
21e1cd6027
Bringing over an edit from the helm-www repo
...
Signed-off-by: Bridget Kromhout <bridget@kromhout.org>
3 years ago
13d86143f8
docs: Clarify use of --set-file
...
and fix non-idiomatic English.
replaces https://github.com/helm/helm-www/pull/1239
Signed-off-by: David Xia <dxia@spotify.com>
3 years ago
94dc605968
fix(rollback): fix helm rollback doesn't have meta.helm.sh annotations
...
Signed-off-by: cndoit18 <cndoit18@outlook.com>
3 years ago
a840fb0940
chore(deps): bump github.com/Masterminds/squirrel from 1.5.1 to 1.5.2
...
Bumps [github.com/Masterminds/squirrel](https://github.com/Masterminds/squirrel ) from 1.5.1 to 1.5.2.
- [Release notes](https://github.com/Masterminds/squirrel/releases )
- [Commits](https://github.com/Masterminds/squirrel/compare/v1.5.1...v1.5.2 )
---
updated-dependencies:
- dependency-name: github.com/Masterminds/squirrel
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
3 years ago
0ab44aef70
add more error checks during the signing process
...
Before this change, several of the potential errors during the process
of signing a package were skipped.
Crucially, `Close()`ing the ReadCloser from the gpg clearsigner is the call
which actually does the signing, and so has several points of failure
which are ignored; for example, if there's a problem with the format of
the key.
Also changes the error from messageBlock() to be propagated rather than
being swallowed, and adds a test for the case where a signer fails to
sign.
Signed-off-by: Ashley Davis <ashley.davis@jetstack.io>
3 years ago
5d47255a3d
Merge pull request #10230 from yxxhero/fix_sdk_namespace_issue
...
add SetNamespace method for EnvSettings, in order to set namespace in helm sdk
3 years ago
67f92d63fa
Merge pull request #9640 from wangchenglong01/wangchl01
...
Add error check to avoid panic
3 years ago
c6961a9a78
Merge pull request #9794 from j6s/task/missing-dependency-message
...
Add hint to missing dependency message
3 years ago
a8d33e7df4
Merge pull request #9918 from cndoit18/fix-issue-9915
...
fix(install): fix 9915
3 years ago
de8034c097
Merge pull request #10390 from helm/dependabot/go_modules/github.com/mattn/go-shellwords-1.0.12
...
chore(deps): bump github.com/mattn/go-shellwords from 1.0.11 to 1.0.12
3 years ago
Allen Bai
Scott Rigby
Josh Wolf
Martin Hickey
yxxhero
Matt Farina
Matt Farina
Bridget Kromhout
Teo Klestrup Röijezon
Marc Khouzam
mengjiao.liu
Matthew Fisher
jayonlau
dependabot[bot]
Kay Yan
Neven Miculinic
root
Andrew Block
Simon Alling
Jerome Küttner
David Xia
cndoit18
Ashley Davis