Akanksha Trehun
383dc99343
Merge 13700e404c into a8ab76e86f
5 days ago
Nikolaus Schuetz
a8ab76e86f
test(action): poll for the interrupted install goroutine instead of a zero-margin sleep ( #32328 )
...
TestInstallRelease_Wait_Interrupted and
TestInstallRelease_RollbackOnFailure_Interrupted assert that the detached
installation goroutine has exited by sleeping a fixed 10s -- exactly the
FailingKubeClient WaitDuration the goroutine blocks on. Sleeping the same
duration the goroutine takes is a zero-margin race: if the goroutine
finishes a hair after the fixed sleep elapses (scheduler jitter under load),
getGoroutineCount() has not decremented yet and the assertion flakes.
Replace the fixed sleep + point-in-time assert with is.Eventually polling
getGoroutineCount() (30s ceiling, 10ms tick). It returns as soon as the
goroutine has actually finished and no longer races the exact wait
duration. Test-only; no change to install behavior.
Signed-off-by: Nikolaus Schuetz <nikolauspschuetz@gmail.com>
5 days ago
Matthieu MOREL
24bbb46c62
chore: fix gofumpt issues
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
6 days ago
Terry Howe
8eb65528be
Merge pull request #32467 from mmorel-35/testify-assertions-pkg-3
...
chore(pkg): refactor: finer tests conversions to testify part 3
1 week ago
Matthieu MOREL
828d01a878
chore(pkg): refactor: finer tests conversions to testify part 1
...
refactor: finer tests conversions to testify in pkg/strvals
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
1 week ago
Matthieu MOREL
9a2be11e6f
chore(pkg): refactor: finer tests conversions to testify part 3
...
refactor: finer tests conversions to testify in pkg/cmd
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
1 week ago
Robert Sirchia
39231d01e1
Merge pull request #32435 from mmorel-35/testifylint-manual-assert-pkg-19
...
chore(pkg): refactor: convert tests to testify assert/require part 19
1 week ago
Terry Howe
f65e3b72b0
Merge pull request #32438 from mmorel-35/testifylint-manual-assert-pkg-22
...
chore(pkg): refactor: convert tests to testify assert/require part 22
2 weeks ago
Terry Howe
e5378ad47e
Merge pull request #32437 from mmorel-35/testifylint-manual-assert-pkg-21
...
chore(pkg): refactor: convert tests to testify assert/require part 21
2 weeks ago
Terry Howe
bfb074a601
Merge pull request #32434 from mmorel-35/testifylint-manual-assert-pkg-18
...
chore(pkg): refactor: convert tests to testify assert/require part 18
2 weeks ago
Terry Howe
54b915e38a
Merge pull request #32433 from mmorel-35/testifylint-manual-assert-pkg-17
...
chore(pkg): refactor: convert tests to testify assert/require part 17
2 weeks ago
Terry Howe
d8a4a8287b
Merge pull request #32432 from mmorel-35/testifylint-manual-assert-pkg-16
...
chore(pkg): refactor: convert tests to testify assert/require part 16
2 weeks ago
Terry Howe
da9e2b6bab
Merge pull request #32428 from mmorel-35/testifylint-manual-assert-pkg-13
...
chore(pkg): refactor: convert tests to testify assert/require part 13
2 weeks ago
Terry Howe
f416c3b830
Merge pull request #32427 from mmorel-35/testifylint-manual-assert-pkg-12
...
chore(pkg): refactor: convert tests to testify assert/require part 12
2 weeks ago
Matthieu MOREL
33c2839569
chore(pkg): refactor: convert tests to testify assert/require part 19
...
refactor: convert tests to testify assert/require in pkg/action
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2 weeks ago
Matthieu MOREL
0b1aa55cbb
chore(pkg): refactor: convert tests to testify assert/require part 22
...
#### Description
refactor: convert tests to testify assert/require in pkg/action
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2 weeks ago
Matthieu MOREL
a934b827fa
chore(pkg): refactor: convert tests to testify assert/require part 21
...
#### Description
refactor: convert tests to testify assert/require in pkg/cmd
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2 weeks ago
Matthieu MOREL
fb8a62bf13
chore(pkg): refactor: convert tests to testify assert/require part 18
...
#### Description
refactor: convert tests to testify assert/require in pkg/cmd
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2 weeks ago
Matthieu MOREL
0fa9f7d427
chore(pkg): refactor: convert tests to testify assert/require part 16
...
#### Description
refactor: convert tests to testify assert/require in pkg/cmd
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2 weeks ago
Matthieu MOREL
4073566e28
chore(pkg): refactor: convert tests to testify assert/require part 17
...
#### Description
refactor: convert tests to testify assert/require in pkg/cmd
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2 weeks ago
Matthieu MOREL
aae82bf97a
chore(pkg): refactor: convert tests to testify assert/require part 13
...
refactor: convert tests to testify assert/require in pkg
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2 weeks ago
Matthieu MOREL
a3fa28ae22
chore(pkg): refactor: convert tests to testify assert/require part 12
...
refactor: convert tests to testify assert/require in pkg
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2 weeks ago
Matthieu MOREL
dc3e3a5e7e
chore(pkg): refactor: convert tests to testify assert/require part 11
...
refactor: convert tests to testify assert/require in pkg
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2 weeks ago
Akanksha Trehun
13700e404c
fix: prevent plugin tarball corruption, file descriptor leak, and error swallowing
...
Signed-off-by: Akanksha Trehun <akankshatrehun@gmail.com>
2 weeks ago
George Jenkins
9c373bf4fc
Merge pull request #32327 from fluxcd/fix-32326
...
Fix vanishing empty lines
3 weeks ago
Lohit Kolluri
ad93b7df63
feat: honor SOURCE_DATE_EPOCH for chart archives ( #32162 )
...
* feat: honor SOURCE_DATE_EPOCH for chart archives
Add StampModTimes() on Chart struct to recursively set ModTime on
all chart file entries. CLI reads SOURCE_DATE_EPOCH env var and wires
through all 5 commands: package, install, upgrade, dep build, dep update.
Removes unused v3 duplicate source_date_epoch.go (YAGNI).
Inlines env var parsing to CLI layer from chart util.
Signed-off-by: Lohit Kolluri <lohitkolluri@gmail.com>
* docs: document SOURCE_DATE_EPOCH in environment variables help
Add a short entry for $SOURCE_DATE_EPOCH to the env var table shown
in 'helm help'. The variable is honored by 'helm package', 'install',
'upgrade', 'dep build', and 'dep update' to produce reproducible chart
archives. Full documentation belongs in helm-www.
Signed-off-by: Lohit Kolluri <lohitkolluri@gmail.com>
* fix: adapt SourceDateEpoch to upstream refactored dep check
Upstream/main restructured the dependency error handling in install.go
and upgrade.go from a nested-if block (if DependencyUpdate) to an
early-return pattern (if !DependencyUpdate). Adapt the feature's
Manager construction to match the new code structure.
Signed-off-by: Lohit Kolluri <lohitkolluri@gmail.com>
---------
Signed-off-by: Lohit Kolluri <lohitkolluri@gmail.com>
3 weeks ago
George Jenkins
7a7b328ba5
Merge pull request #32319 from mmorel-35/revive
...
feat(linters): add new revive rules for better code quality
3 weeks ago
Matheus Pimenta
73c1fb2451
Address review comments
...
Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
3 weeks ago
Matheus Pimenta
bfebbb7c1a
Fix vanishing empty lines
...
Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
3 weeks ago
Matthieu MOREL
16787d65f5
feat(linters): add new revive rules for better code quality
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
3 weeks ago
Matthieu MOREL
9662fdd73b
refactor: enable several checks from gocritic
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
3 weeks ago
Terry Howe
d262c7ca79
Merge pull request #32296 from mmorel-35/gocritic-singleCaseSwitch
...
chore: fix emptyStringTest, nestingReduce and singleCaseSwitch checks issues from gocritic
4 weeks ago
Matthieu MOREL
96b315f188
chore: fix emptyStringTest, nestingReduce and singleCaseSwitch checks issues from gocritic
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
4 weeks ago
Matthieu MOREL
4ade4a5495
test: replace assert.Contains with assert.ErrorContains for better error handling
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
4 weeks ago
Matthieu MOREL
f34ad6c337
chore: fix several checks issues from testifylint
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
4 weeks ago
Matthieu MOREL
07259ecc86
chore: fix several checks issues from gocritic
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
4 weeks ago
Matthieu MOREL
34cfdfdbe5
chore: enable contextcheck, fatcontext and noctx linters
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
1 month ago
Terry Howe
a092a1bd09
Merge pull request #31859 from biagiopietro/feature/rollback-revision-history
...
feat(history): add rollback revision column to helm history output
2 months ago
Terry Howe
c36e4d52bd
test: use assert.Empty for zero-length assertions in validate_test
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
2 months ago
George Jenkins
253da5106a
Merge pull request #32171 from mmorel-35/empty-len
...
Fix empty and len testifylint violations across test files
2 months ago
George Jenkins
422773cd49
Merge pull request #32129 from gregory-m/fix-test-logs-non-pod-hooks
2 months ago
Terry Howe
b3fbf8d0f7
Merge pull request #30808 from mmorel-35/errorlint
...
chore: enable errorlint
2 months ago
Evans Mungai
a6179d0dd1
Merge branch 'main' into em/check-ownership-before-delete
...
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
2 months ago
MrJack
1b360574a9
Merge branch 'helm:main' into feature/rollback-revision-history
2 months ago
Terry Howe
59b57c5c31
Merge pull request #31885 from mmorel-35/whitespace
...
chore: fix whitespace linter
2 months ago
Matthieu MOREL
488c4a805d
Fix empty and len testifylint violations across test files
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2 months ago
Evans Mungai
d374e823b2
Merge pull request #32086 from mmorel-35/error-is-as
...
testifylint: enable error-is-as and error-nil rules
2 months ago
MrJack
291a1a3b26
Merge branch 'helm:main' into feature/rollback-revision-history
3 months ago
Gregory Man
1a1ec6e3cc
fix: skip non-Pod test hooks in GetPodLogs
...
Before this change, hooks with `helm.sh/hook: test` but Kind != Pod
(ConfigMap, Secret, ...) led to `helm test --logs` fail with
`unable to get pod <name>`.
Signed-off-by: Gregory Man <man.gregory@gmail.com>
3 months ago
box4wangjing
432fc8a217
refactor: use slices.Backward to simplify the code
...
Signed-off-by: box4wangjing <box4wangjing@outlook.com>
3 months ago