Simon Alling
2a462aef2d
fix(pkg/chartutil): add tests according to feedback
...
The seemingly redundant `return filename, err` line is related to how
the name `err` is used throughout the function: there is a "global" (to
the function) `err` variable, as well as several locally block-scoped
ones. It took me hours to understand why my code did not work without
that line, but I decided not to clean up the `err` code in this commit.
Signed-off-by: Simon Alling <alling.simon@gmail.com>
5 years ago
Simon Alling
50675e7cd7
fix(pkg/chartutil): include values.schema.json in packaged chart
...
Before this commit:
$ helm lint my-chart # Finds errors in values.yaml
$ helm package my-chart
$ helm lint my-chart-1.0.0.tgz # Does not find errors in values.yaml
Signed-off-by: Simon Alling <alling.simon@gmail.com>
Co-authored-by: Andreas Lindhé <andreas@lindhe.io>
5 years ago
Matthew Fisher
0141f9c806
Merge pull request #6628 from VilledeMontreal/fix/impossibleCond
...
Remove impossible condition reported by linter
5 years ago
Adam Reese
2cc58560c1
Merge pull request #6627 from adamreese/fix/go-mod-tidy
...
fix(go.mod): run go mod tidy
5 years ago
KUOKA Yusuke
4c351c7248
fix(v3): fix type error while merging map loaded with `fromYaml` template func ( #6630 )
...
Fixes #6626
Signed-off-by: Yusuke Kuoka <ykuoka@gmail.com>
5 years ago
Dmitry Tokarev
1da0d011f9
Added NetworkPolicy, PodDisruptionBudget, and PodSecurityPolicy to InstallOrder. ( #6624 )
...
Port #6266 #4769 #3899 to Helm 3.
Signed-off-by: Dmitry Tokarev <dm.tokarev@yahoo.com>
5 years ago
Marc Khouzam
e2d5ec8397
feat(comp): Dynamic completion for --output flag ( #6580 )
...
Signed-off-by: Marc Khouzam <marc.khouzam@montreal.ca>
5 years ago
Marc Khouzam
adbc39beb5
Remove impossible condition reported by linter
...
Signed-off-by: Marc Khouzam <marc.khouzam@montreal.ca>
5 years ago
Adam Reese
ec870d0a3d
fix(go.mod): run go mod tidy
...
Signed-off-by: Adam Reese <adam@reese.io>
5 years ago
Taylor Thomas
6cfd47784b
Merge pull request #6625 from Dean-Coakley/get-output-cmd
...
fix(cmd): Add --output option to get values
5 years ago
Dean Coakley
c7a3974d3b
Add get values yaml output test case
...
Signed-off-by: Dean Coakley <dean.s.coakley@gmail.com>
5 years ago
Dean Coakley
a831747dde
Refactor get values table header writer
...
Signed-off-by: Dean Coakley <dean.s.coakley@gmail.com>
5 years ago
Dean Coakley
df64ad1e10
Add get values --all test case
...
Signed-off-by: Dean Coakley <dean.s.coakley@gmail.com>
5 years ago
Dean Coakley
3c899d0bde
Add get values table output headers
...
Signed-off-by: Dean Coakley <dean.s.coakley@gmail.com>
5 years ago
Dean Coakley
66268d9eee
fix(cmd): Add --output option to get values
...
Signed-off-by: Dean Coakley <dean.s.coakley@gmail.com>
5 years ago
Adam Reese
c3ac13a1f2
Merge pull request #6622 from adamreese/fix/validate
...
fix(pkg/kube): validate with OpenAPI on install
5 years ago
Adam Reese
1e20ebae35
fix(pkg/kube): validate with OpenAPI on install
...
Signed-off-by: Adam Reese <adam@reese.io>
5 years ago
Adam Reese
442c3588e4
Merge pull request #6599 from adamreese/feat/validation
...
feat(pkg/kube): add openapi validation for k8s objects
5 years ago
Martin Hickey
f2aa97e313
fix(helm): Port accept dependency in requirements.yaml from charts directory ( #6611 )
...
* Port #6578 to Helm 3
Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com>
* Update after reviw
Review comments:
- https://github.com/helm/helm/pull/6611#discussion_r332745703
Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com>
5 years ago
Adam Reese
572b92dc8a
feat(pkg/kube): add openapi validation for k8s objects
...
Add back OpenAPI validation for kubernetes objects.
Fixes : #6382
Signed-off-by: Adam Reese <adam@reese.io>
5 years ago
Matthew Fisher
7ffc879f13
Merge pull request #6607 from thomastaylor312/fix/missing_path_validation
...
fix(chart): Ports security fix for invalid paths in tarballs
5 years ago
Taylor Thomas
62ed7b3764
Merge pull request #6594 from thomastaylor312/feat/template_api_versions
...
feat(template): Ports api-versions flag to v3
5 years ago
Taylor Thomas
3637996dcd
fix(chart): Ports security fix for invalid paths in tarballs
...
This is a port of #5165 and the small refactor in #5610 . This is the issue
where carefully crafted paths can reach outside of the intended chart directory
Signed-off-by: Taylor Thomas <taylor.thomas@microsoft.com>
5 years ago
Taylor Thomas
b9d504dd67
Merge pull request #6596 from thomastaylor312/feat/get_repo_file
...
feat(repo): Ports repo file `Get` method from v2
5 years ago
wxdao
c00890cae1
Fix Save misbehavior on nonexistent directory ( #6360 )
...
Signed-off-by: wxdao <waxiadao@gmail.com>
5 years ago
Rimas Mocevicius
648fa876ad
Remove Tiller reference from --install ( #6604 )
...
Signed-off-by: rimas <rmocius@gmail.com>
5 years ago
Taylor Thomas
cc45056383
Merge pull request #6598 from thomastaylor312/feat/tarball_perms
...
feat(plugin): Ports file mode preservation for tarballs from v3
5 years ago
Taylor Thomas
5e2071caef
Merge pull request #6597 from thomastaylor312/feat/ingress_wait
...
feat(wait): Ports ingress wait to v3
5 years ago
Taylor Thomas
fca14bcb76
feat(plugin): Ports file mode preservation for tarballs from v3
...
This is a port of #5428 and readds a unit test for the `Extract` method
Signed-off-by: Taylor Thomas <taylor.thomas@microsoft.com>
5 years ago
Taylor Thomas
63c994343b
feat(wait): Ports ingress wait to v3
...
This is a port of #5264 with extra support for the networking/v1beta1 API
Signed-off-by: Taylor Thomas <taylor.thomas@microsoft.com>
5 years ago
Taylor Thomas
854919fae8
feat(repo): Ports repo file `Get` method from v2
...
This is a port of #3478 with some slight refactors to make it a bit more friendly.
It is technically a breaking change as it is changing the method signature from v2
Signed-off-by: Taylor Thomas <taylor.thomas@microsoft.com>
5 years ago
Taylor Thomas
0210d43a66
Merge pull request #6550 from thomastaylor312/fix/missing_debug
...
fix(cmd): Fix all the outputs
5 years ago
Taylor Thomas
59d3488d1c
feat(template): Ports api-versions flag to v3
...
This is a port of #5392 . It also takes care of the small chore to update the default k8s
version to 1.16, which is the latest supported version
Signed-off-by: Taylor Thomas <taylor.thomas@microsoft.com>
5 years ago
Taylor Thomas
3d64c6bb54
ref(cmd): Implement flag parsing for output format
...
Signed-off-by: Taylor Thomas <taylor.thomas@microsoft.com>
5 years ago
Taylor Thomas
768d27b387
ref(*): Refactors output into its own package
...
Signed-off-by: Taylor Thomas <taylor.thomas@microsoft.com>
5 years ago
Martin Hickey
335d27a976
Fix ingress API group in scaffold chart ( #6591 )
...
Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com>
5 years ago
Efrat Levitan
98a33fb683
helm repo subcommands aliases ( #6589 )
...
* helm repo subcommands aliases
Signed-off-by: Efrat19 <efrat890089@gmail.com>
* lint
Signed-off-by: Efrat19 <efrat890089@gmail.com>
5 years ago
Matthew Fisher
f35881d299
Merge pull request #6588 from Efrat19/feature/6558
...
helm plugin subcommands aliases - helm3
5 years ago
Efrat19
f9175ea5d5
run golint
...
Signed-off-by: Efrat19 <efrat890089@gmail.com>
5 years ago
Efrat19
2cbbc018e7
remove trailing whitespace
...
Signed-off-by: Efrat19 <efrat890089@gmail.com>
5 years ago
Efrat19
58043d8657
helm plugin subcommands aliases
...
Signed-off-by: Efrat19 <efrat890089@gmail.com>
5 years ago
Matthew Fisher
9de0bd6994
Merge pull request #6584 from bacongobbler/fixup-package-import
...
fix(action): fix import statement
5 years ago
Matthew Fisher
0ae0f0742d
fix(action): fix import statement
...
Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>
5 years ago
Matthew Fisher
02999565a4
Merge pull request #6556 from karuppiah7890/conditional-dependencies-not-working-v3
...
fix(pkg/action): fix conditional dependencies not working with reuse values
5 years ago
Matthew Fisher
c1e63a2a17
Merge pull request #6536 from karuppiah7890/fix-lint-for-no-package-found
...
fix silent lint ignore for non existing packaged charts
5 years ago
Matthew Fisher
29765f4afe
Merge pull request #6490 from bacongobbler/port-create-enhancements
...
fix(chartutil): port over enhancements to `helm create` from Helm 2
5 years ago
Taylor Thomas
f8ab189515
Merge pull request #6582 from jonasrutishauser/fix/hooks_output
...
Use same output format for hooks as for manifest
5 years ago
Jonas Rutishauser
9ea75a9f59
Use same output format for hooks as for manifest
...
Signed-off-by: Jonas Rutishauser <jonas.rutishauser@alumni.ethz.ch>
5 years ago
Martin Hickey
2d5faff6a1
Create file locking directory if it does not exist ( #6555 )
...
* Create file locking directory if it does not exist
As Helm v3 uses lazy creation for configuration then
directories and files are not created until required.
File locking when doing repo add was introduced in
v2 and ported to v3 in #6492 . It locks on the config
directory where the repo file resides and therefore
needs the directory to be created if it doesn't exist.
This fix adds the directory if need be,
Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com>
* Add unit test
Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com>
5 years ago
Taylor Thomas
07c950fc41
Merge pull request #6571 from cgetzen/cg/dev-v3/kube_create_goroutine
...
v3: Performance: Batch kube API operations
5 years ago