46806c8217
Merge branch 'dev-v3' into advisory-fix-1a
...
Signed-off-by: Robert Sirchia <rsirchia@outlook.com>
5 months ago
7977a48fb4
Merge commit from fork
...
fix for dev-v3
5 months ago
f13afaacd6
fix Chart.yaml handling
...
Signed-off-by: Matt Farina <matt.farina@suse.com>
5 months ago
039b0b18d3
Handle messy index files
...
Signed-off-by: Matt Farina <matt.farina@suse.com>
(cherry picked from commit 69efc0d4fb
5 months ago
6d9509aadc
json schema fix
...
Signed-off-by: Robert Sirchia <rsirchia@outlook.com>
5 months ago
807225ed62
fix: k8s version parsing to match original
...
Signed-off-by: Borys Hulii <borys.hulii@bitvavo.com>
5 months ago
227c9cb6b6
Disabling linter due to unknown issue
...
Signed-off-by: Matt Farina <matt.farina@suse.com>
6 months ago
4389fa639a
Updating link handling
...
Signed-off-by: Matt Farina <matt.farina@suse.com>
(cherry picked from commit 76fdba4c8c
6 months ago
2c55a4e8ce
fix: user username password for login
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
7 months ago
a16e986d4e
Update pkg/registry/transport.go
...
Co-authored-by: Scott Rigby <scott@r6by.com>
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
7 months ago
cea26d8bca
Update pkg/registry/transport.go
...
Co-authored-by: Scott Rigby <scott@r6by.com>
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
7 months ago
b52bb41484
fix: add debug logging to oci transport
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
Co-authored-by: Billy Zha <jinzha1@microsoft.com>
7 months ago
733f94c86a
fix: legacy docker support broken for login
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
7 months ago
9d56978f65
Merge pull request #30938 from TerryHowe/backport-fix-plugin-install-no-internet
...
fix: backport plugin installer test with no Internet
7 months ago
fc36041702
fix: plugin installer test with no Internet
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
7 months ago
62759a819e
Merge pull request #30916 from jessesimpson36/v3-remove-registry-login-url-with-tests
...
test: add functional tests for "Fix 3.18.0 regression: registry login with scheme"
7 months ago
cfe8cef46f
Handle an empty registry config file.
...
In the move to oras v2, an existing but empty registry config file
became an uncaught error. A missing file caused no error. This
change catches the error and works around it so that Helm can
continue to be fault tolerant to this issue.
Signed-off-by: Matt Farina <matt.farina@suse.com>
7 months ago
c33215d765
Prevent fetching newReference again as we have in calling method
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
7 months ago
f552b67230
Prevent failure when resolving version tags in oras memory store
...
- The newReference() function transforms version tags by replacing + with _ for OCI compatibility
- But the code was using the original ref (with +) for TagBytes()
- Then it tries to find the tagged reference using parsedRef.String() (with _)
- This mismatch causes the Resolve method to fail with "not found"
- By using parsedRef.String() consistently in both places, the references will match and the lookup will succeed.
I extracted the TagBytes function to improve testability.
Push() includes several external calls that are hard to mock,
so isolating this logic makes testing more manageable.
Close : #30881
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
7 months ago
806d59750a
Merge pull request #30902 from brandtkeller/30890_prov_mediatype_allow
...
fix(client): allow layer selection permissive
7 months ago
e37962522c
Merge pull request #30887 from scottrigby/v3-remove-registry-login-url
...
Fix 3.18.0 regression: registry login with scheme
7 months ago
a18a52e898
fix(client): skipnode utilization for PreCopy
...
Co-authored-by: George Jenkins <gvjenkins@gmail.com>
Signed-off-by: Brandt Keller <43887158+brandtkeller@users.noreply.github.com>
7 months ago
fedf5024d6
test: Skip instead of returning early. looks more intentional
...
Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>
7 months ago
fe512bae43
test: tests repo stripping functionality
...
Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>
7 months ago
099a9e18f3
test: include tests for Login based on different protocol prefixes
...
Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>
7 months ago
b07ab77da3
fix(client): layers now returns manifest - remove duplicate from descriptors
...
Signed-off-by: Brandt Keller <brandt.keller@defenseunicorns.com>
7 months ago
c225c124ac
fix(client): return nil on non-allowed media types
...
Signed-off-by: Brandt Keller <brandt.keller@defenseunicorns.com>
7 months ago
c0f3ace52d
Fix 3.18.0 regression: registry login with scheme
...
Helm 3.18.0 released an upgrade of ORAS from v1 to v2.
ORAS v2 correctly does not accept http/https scheme for registry login, while
ORAS v1 previously did. Even if v1 should not have, we want to preserve
backwards compatibility for Helm 3 users who pass the scheme.
This will be removed in Helm 4, where registry login will not accept http/https
scheme.
Co-authored-by: Andrew Block <andy.block@gmail.com>
Co-authored-by: Terry Howe <terrylhowe@gmail.com>
Signed-off-by: Scott Rigby <scott@r6by.com>
7 months ago
f147277a59
Merge pull request #30885 from helm/revert-13534-dev-v3-12987
...
Revert "fix (helm) : toToml` renders int as float [ backport to v3 ]"
7 months ago
dce60adb51
Update pkg/plugin/plugin.go
...
Co-authored-by: George Jenkins <gvjenkins@gmail.com>
Signed-off-by: Benoit Tigeot <benoittgt@users.noreply.github.com>
8 months ago
cda0865d64
Update pkg/plugin/plugin.go
...
Co-authored-by: George Jenkins <gvjenkins@gmail.com>
Signed-off-by: Benoit Tigeot <benoittgt@users.noreply.github.com>
8 months ago
5d9d9a0fb8
Wait for Helm v4 before raising when platformCommand and Command are set
...
same for `PlatformHooks` and `hooks`.
When backporting a feature for Helm v3 we forgot to mark as deprecation
validations that will enforced in v4.
See (search for "Remove in Helm 4."):
- https://github.com/helm/helm/pull/13592/files#diff-fc137d62147eb6a9c89c0566479ff219320ca691f2505631ebacbe513bcc8108R268-R270
Fix:
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
8 months ago
c5249c1f8d
Revert "fix (helm) : toToml` renders int as float [ backport to v3 ]"
...
This change has caused issues with numerous charts around things
unrelated to toml. This is because of functions like typeIs/typeOf
being used and acted upon.
The change caused a significant regression.
Closes #30880
Signed-off-by: Matt Farina <matt@mattfarina.com>
8 months ago
afefca8b2d
chore: update generalization warning message
...
Signed-off-by: Feng Cao <24779889+shfc@users.noreply.github.com>
8 months ago
eb5b6d5047
fix: move warning to top of block
...
Emit the warning first to ensure it's always logged. This clarifies that any following errors are due to using a local chart instead of a remote repository.
Signed-off-by: Feng Cao <24779889+shfc@users.noreply.github.com>
8 months ago
6b5c94475d
fix: replace fmt warning with slog
...
Signed-off-by: Feng Cao <24779889+shfc@users.noreply.github.com>
8 months ago
247bf7c2e0
fix: add warning when ignore repo flag
...
Signed-off-by: Feng Cao <24779889+shfc@users.noreply.github.com>
8 months ago
b4e06a11d2
Merge pull request #30658 from helm/gjenkins/backport_12912
...
[v3 backport] feat: add httproute from gateway-api to create chart template
8 months ago
a69eaf6098
Merge pull request #30764 from nvanthao/backport-30673
...
v3 backport: Process all hook deletions on failure
8 months ago
94044595c7
bump version to v3.18.0
...
(cherry picked from commit 74c3d1dc0de0335f941362c80447871e7d6bc78e)
Signed-off-by: Robert Sirchia <rsirchia@outlook.com>
8 months ago
cdd7c105a6
docs: Note about http fallback for OCI registries
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
8 months ago
e4bc4a31b9
Merge pull request #30768 from banjoh/em/fix-take-ownership
...
v3 backport - fix --take-ownership
8 months ago
087fa18276
Bump toml
...
Looking at the [toml diff](https://github.com/BurntSushi/toml/compare/v1.4.0...v1.5.0 ). I think it's safe to change the test here.
For main: https://github.com/helm/helm/pull/30775
Closes: https://github.com/helm/helm/pull/30683
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
9 months ago
0906fe7f6b
Add install test for TakeOwnership flag
...
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
9 months ago
4ee3a19e9a
Fix --take-ownership
...
If a resource exists in the cluster and is to be adopted by helm install
--take-ownership, it is left unchanged while helm reports the
installation to have succeeded.
This is due to CRs and CRDs being merged without three-way-merge, which
results in an empty patch.
By using a three-way-merge transparently when --take-ownership is used,
the helm behaves as expected without breaking previous behavior.
Fixes #30622
Signed-off-by: Patrick Seidensal <pseidensal@suse.com>
9 months ago
0a800e84b0
backport #30673 to dev-v3
...
Signed-off-by: Gerard Nguyen <gerard@replicated.com>
9 months ago
3ce10e4f81
Unarchiving fix
...
Signed-off-by: Matt Farina <matt@mattfarina.com>
(cherry picked from commit 7cc4dcf94ee410c8e0d64f3e726dda199c24ccb2)
9 months ago
422c58e4a2
Fix typo
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
10 months ago
5e7f12d4c3
Report as debug log, the time spent waiting for resources
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
10 months ago
1435ec7c77
Update pkg/registry/fallback.go
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
10 months ago
Robert Sirchia
Matt Farina
Borys Hulii
Terry Howe
Scott Rigby
Benoit Tigeot
Brandt Keller
Jesse Simpson
Brandt Keller
Benoit Tigeot
Matt Farina
Feng Cao
George Jenkins
Evans Mungai
Patrick Seidensal
Gerard Nguyen