Karthik Chowdary
1c632eee59
fix(cmd): report implicit watcher waits
...
Signed-off-by: Karthik Chowdary <21139050+Karthik-Chowdary@users.noreply.github.com>
4 weeks ago
Karthik Chowdary
f590c59930
fix(cmd): suppress wait progress during dry runs
...
Signed-off-by: Karthik Chowdary <21139050+Karthik-Chowdary@users.noreply.github.com>
4 weeks ago
Karthik Chowdary
a2504521ab
feat(cmd): show progress before waiting for resources
...
Signed-off-by: Karthik Chowdary <21139050+Karthik-Chowdary@users.noreply.github.com>
4 weeks ago
Ruslan Shaydullin
67d54fd880
fix(provenance): support GnuPG keybox (pubring.kbx) keyrings ( #32281 )
...
* fix(provenance): support GnuPG keybox (pubring.kbx) keyrings
Starting with GnuPG 2.1, file-backed public keyrings can use
~/.gnupg/pubring.kbx instead of the legacy pubring.gpg. Helm only read
the legacy format, so chart and plugin verification failed on
installations using the file-backed keybox.
Make the keyring loader format-aware:
- GnuPG keybox (pubring.kbx): extract OpenPGP keyblocks from the
keybox container without adding a dependency. Skip ephemeral blobs,
matching GnuPG's own read behavior.
- ASCII-armored keyrings: load single or concatenated exports.
- Legacy binary packet streams (pubring.gpg): retain the existing path.
defaultKeyring() falls back to pubring.kbx when pubring.gpg is absent.
pubring.gpg keeps precedence when both files exist.
This change covers file-backed public keyrings. It does not read the
SQLite database used by keyboxd, which needs a separate design.
Related to #31836
Signed-off-by: Ruslan Shaydullin <shaydullin.r.d@outlook.com>
* fix(provenance): treat only not-exist as keyring absence in defaultKeyring
A stat error other than 'not exist' (e.g. a permission problem) meant
the file may well be present, but defaultKeyring() skipped past it: an
unreadable pubring.gpg silently lost precedence to pubring.kbx, and the
surfaced error could point at the wrong file. Treat only fs.ErrNotExist
as absence. For any other stat error, return that path unchanged so the
real error surfaces when the keyring is opened.
Signed-off-by: Ruslan Shaydullin <shaydullin.r.d@outlook.com>
---------
Signed-off-by: Ruslan Shaydullin <shaydullin.r.d@outlook.com>
Co-authored-by: George Jenkins <gvjenkins@gmail.com>
4 weeks ago
MrJack
2b239b84e4
Merge branch 'helm:main' into feature/rollback-description-flag
2 months ago
Matthieu MOREL
24bbb46c62
chore: fix gofumpt issues
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2 months ago
MrJack
f3edb83df4
Make golangci-lint happy
...
Signed-off-by: MrJack <36191829+biagiopietro@users.noreply.github.com>
2 months ago
MrJack
94a3315f4d
Added missing import
...
Signed-off-by: MrJack <36191829+biagiopietro@users.noreply.github.com>
2 months ago
MrJack
500f02d597
Readded "unicode/utf8"
...
Signed-off-by: MrJack <36191829+biagiopietro@users.noreply.github.com>
2 months ago
MrJack
f1ede7c9c1
Potential fix for pull request finding
...
If the CLI-side description validation is removed, the unicode/utf8 import becomes unused and should also be dropped.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Signed-off-by: MrJack <36191829+biagiopietro@users.noreply.github.com>
2 months ago
MrJack
e73dfab5fb
refactor(test): reuse existing rollback.txt golden file
...
Remove duplicate rollback-with-description.txt fixture that had
identical content to rollback.txt.
Signed-off-by: MrJack <36191829+biagiopietro@users.noreply.github.com>
2 months ago
MrJack
b177a8e906
Removed extra space in rollback-with-description.txt
...
Signed-off-by: MrJack <36191829+biagiopietro@users.noreply.github.com>
2 months ago
MrJack
a92611c202
Enhance rune count in pkg/cmd/rollback.go and pkg/action/rollback.go
...
Signed-off-by: MrJack <36191829+biagiopietro@users.noreply.github.com>
2 months ago
MrJack
8a34f3b7b4
Use rune count to count properly multi-byte UTF-8 characters
...
Signed-off-by: MrJack <36191829+biagiopietro@users.noreply.github.com>
2 months ago
MrJack
cb91040c44
Enhanced rollback description length
...
Signed-off-by: MrJack <36191829+biagiopietro@users.noreply.github.com>
2 months ago
MrJack
b606955f09
Set 256 as limit for maxDescriptionLength. 256 comes from MAX value for key and value
...
Signed-off-by: MrJack <36191829+biagiopietro@users.noreply.github.com>
2 months ago
MrJack
f8180e6de4
feat(rollback): add --description flag to provide rollback reason
...
Add a new --description flag to the helm rollback command that allows
users to specify a custom description explaining why the rollback was
performed. This description is stored in the release metadata.
Changes:
- Add Description field to the Rollback action struct
- Add --description flag to the rollback CLI command
- Add 512 character limit validation for the description
- Default to 'Rollback to <version>' when no description is provided
The description flag is optional and follows the same pattern used by
the install and upgrade commands.
Closes #XXXX
Signed-off-by: MrJack <36191829+biagiopietro@users.noreply.github.com>
2 months ago
Terry Howe
8eb65528be
Merge pull request #32467 from mmorel-35/testify-assertions-pkg-3
...
chore(pkg): refactor: finer tests conversions to testify part 3
2 months ago
Matthieu MOREL
bfca0688b1
Update show_test.go
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2 months ago
Matthieu MOREL
b59dfd3901
Update rollback_test.go
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2 months ago
Matthieu MOREL
a27f3a0620
Potential fix for pull request finding
...
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2 months ago
Matthieu MOREL
9a2be11e6f
chore(pkg): refactor: finer tests conversions to testify part 3
...
refactor: finer tests conversions to testify in pkg/cmd
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2 months ago
Matthieu MOREL
4d9c03f51c
chore(pkg): refactor: finer tests conversions to testify part 2
...
#### Description
refactor: finer tests conversions to testify in pkg/storage/driver
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2 months ago
Robert Sirchia
39231d01e1
Merge pull request #32435 from mmorel-35/testifylint-manual-assert-pkg-19
...
chore(pkg): refactor: convert tests to testify assert/require part 19
2 months ago
Terry Howe
f65e3b72b0
Merge pull request #32438 from mmorel-35/testifylint-manual-assert-pkg-22
...
chore(pkg): refactor: convert tests to testify assert/require part 22
2 months ago
Terry Howe
e5378ad47e
Merge pull request #32437 from mmorel-35/testifylint-manual-assert-pkg-21
...
chore(pkg): refactor: convert tests to testify assert/require part 21
2 months ago
Terry Howe
76bf75c956
Merge pull request #32436 from mmorel-35/testifylint-manual-assert-pkg-20
...
chore(pkg): refactor: convert tests to testify assert/require part 20
2 months ago
Terry Howe
bfb074a601
Merge pull request #32434 from mmorel-35/testifylint-manual-assert-pkg-18
...
chore(pkg): refactor: convert tests to testify assert/require part 18
2 months ago
Terry Howe
54b915e38a
Merge pull request #32433 from mmorel-35/testifylint-manual-assert-pkg-17
...
chore(pkg): refactor: convert tests to testify assert/require part 17
2 months ago
Terry Howe
d8a4a8287b
Merge pull request #32432 from mmorel-35/testifylint-manual-assert-pkg-16
...
chore(pkg): refactor: convert tests to testify assert/require part 16
2 months ago
Terry Howe
a6409a7eba
Merge pull request #32430 from mmorel-35/testifylint-manual-assert-pkg-15
...
chore(pkg): refactor: convert tests to testify assert/require part 15
2 months ago
Terry Howe
da9e2b6bab
Merge pull request #32428 from mmorel-35/testifylint-manual-assert-pkg-13
...
chore(pkg): refactor: convert tests to testify assert/require part 13
2 months ago
Terry Howe
f416c3b830
Merge pull request #32427 from mmorel-35/testifylint-manual-assert-pkg-12
...
chore(pkg): refactor: convert tests to testify assert/require part 12
2 months ago
Terry Howe
5d4165bfaf
Merge pull request #32425 from mmorel-35/testifylint-manual-assert-pkg-10
...
chore(pkg): refactor: convert tests to testify assert/require part 10
2 months ago
Terry Howe
00c2e025e5
Merge pull request #32424 from mmorel-35/testifylint-manual-assert-pkg-9
...
chore(pkg): refactor: convert tests to testify assert/require part 9
2 months ago
Terry Howe
eea1defc88
Merge pull request #32422 from mmorel-35/testifylint-manual-assert-pkg-7
...
chore(pkg): refactor: convert tests to testify assert/require part 7
2 months ago
Matt Farina
598f567f83
Merge pull request #32400 from SetagGnaw/fix/upgrade-dependency-update-oci-panic
...
fix: pass registry client to downloader.Manager in upgrade
2 months ago
Matthieu MOREL
33c2839569
chore(pkg): refactor: convert tests to testify assert/require part 19
...
refactor: convert tests to testify assert/require in pkg/action
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2 months ago
Matthieu MOREL
0b1aa55cbb
chore(pkg): refactor: convert tests to testify assert/require part 22
...
#### Description
refactor: convert tests to testify assert/require in pkg/action
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2 months ago
Matthieu MOREL
a934b827fa
chore(pkg): refactor: convert tests to testify assert/require part 21
...
#### Description
refactor: convert tests to testify assert/require in pkg/cmd
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2 months ago
Matthieu MOREL
1d4665e54c
chore(pkg): refactor: convert tests to testify assert/require part 20
...
#### Description
refactor: convert tests to testify assert/require in pkg/cmd
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2 months ago
Matthieu MOREL
fb8a62bf13
chore(pkg): refactor: convert tests to testify assert/require part 18
...
#### Description
refactor: convert tests to testify assert/require in pkg/cmd
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2 months ago
Matthieu MOREL
0fa9f7d427
chore(pkg): refactor: convert tests to testify assert/require part 16
...
#### Description
refactor: convert tests to testify assert/require in pkg/cmd
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2 months ago
Matthieu MOREL
4073566e28
chore(pkg): refactor: convert tests to testify assert/require part 17
...
#### Description
refactor: convert tests to testify assert/require in pkg/cmd
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2 months ago
Matthieu MOREL
71733656a5
chore(pkg): refactor: convert tests to testify assert/require part 15
...
#### Description
refactor: convert tests to testify assert/require in pkg/cmd
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2 months ago
Matthieu MOREL
aae82bf97a
chore(pkg): refactor: convert tests to testify assert/require part 13
...
refactor: convert tests to testify assert/require in pkg
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2 months ago
Matthieu MOREL
a3fa28ae22
chore(pkg): refactor: convert tests to testify assert/require part 12
...
refactor: convert tests to testify assert/require in pkg
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2 months ago
Matthieu MOREL
2f5a33fb77
chore(pkg): refactor: convert tests to testify assert/require part 10
...
#### Description
refactor: convert tests to testify assert/require in pkg
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2 months ago
Matthieu MOREL
13d1edc5f3
chore(pkg): refactor: convert tests to testify assert/require part 9
...
refactor: convert tests to testify assert/require in pkg/chart/common/util
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2 months ago
Matthieu MOREL
ca1767b813
chore(pkg): refactor: convert tests to testify assert/require part 7
...
refactor: convert tests to testify assert/require in pkg
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2 months ago