8b53467dd9
Merge pull request #31416 from MarcAntoineRaymond/dev-v3
...
[v3 backport] Fix `helm pull` untar dir check with repo urls
4 months ago
6a67b553b4
Revert "pkg/registry: Login option for passing TLS config in memory"
...
Signed-off-by: Scott Rigby <scott@r6by.com>
4 months ago
e5e101cced
Fix `helm pull` untar dir check with repo urls
...
The existing check worked for `helm pull downloaded-repo/chart-name`,
but often does not work when using `--repo-url`, depending on the urls
used by the charts.
Signed-off-by: Luna Stadler <luc@spreadshirt.net>
5 months ago
73c269f31d
Merge pull request #31257 from benoittgt/fix-31202-panic-backport
...
[backport] Avoid panic in helm.sh/helm/v3/pkg/chartutil.ValidateAgainstSchema
5 months ago
68e20cac13
Merge pull request #31284 from matheuscscp/backport-31076-dev-v3
...
pkg/registry: Login option for passing TLS config in memory
5 months ago
0111c25229
Merge pull request #31048 from unguiculus/issue-12952
...
fix(v3 backport): Add timeout flag to repo add and update flags
6 months ago
b80959f24f
pkg/registry: Login option for passing TLS config in memory
...
Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
6 months ago
2fe49f99ce
Avoid "panic: interface conversion: interface {} is nil"
...
Closes : #31202
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
6 months ago
c3610abd2d
bump version to v3.19.0
...
Signed-off-by: Scott Rigby <scott@r6by.com>
(cherry picked from commit 3d8990f083
6 months ago
9a54bf1df6
fix: use username and password if provided
...
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
6 months ago
b278020311
fix(helm-lint): fmt
...
Signed-off-by: Isaiah Lewis <isaiah@roof12.com>
(cherry picked from commit 62e0c78ef8
7 months ago
d33ac5e44b
fix(helm-lint): Add TLSClientConfig
...
Signed-off-by: Isaiah Lewis <isaiah@roof12.com>
(cherry picked from commit fb12b44493
7 months ago
854370978e
fix(helm-lint): Add HTTP/HTTPS URL support for json schema references
...
Signed-off-by: Isaiah Lewis <isaiah@roof12.com>
(cherry picked from commit fa73b6743b
7 months ago
093c885548
Merge pull request #31087 from TerryHowe/backport-fix-httpgetter
...
Backport of fix httpgetter
7 months ago
46806c8217
Merge branch 'dev-v3' into advisory-fix-1a
...
Signed-off-by: Robert Sirchia <rsirchia@outlook.com>
7 months ago
7977a48fb4
Merge commit from fork
...
fix for dev-v3
7 months ago
f13afaacd6
fix Chart.yaml handling
...
Signed-off-by: Matt Farina <matt.farina@suse.com>
7 months ago
039b0b18d3
Handle messy index files
...
Signed-off-by: Matt Farina <matt.farina@suse.com>
(cherry picked from commit 69efc0d4fb
7 months ago
6d9509aadc
json schema fix
...
Signed-off-by: Robert Sirchia <rsirchia@outlook.com>
8 months ago
807225ed62
fix: k8s version parsing to match original
...
Signed-off-by: Borys Hulii <borys.hulii@bitvavo.com>
8 months ago
5e8ff72b71
Do not explicitly set SNI in HTTPGetter
...
Co-authored-by: Wahab Ali <wahabalimk@gmail.com>
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
8 months ago
79a9cc5653
Add timeout flag to repo add and update flags
...
Backport of #30900 to v3.
(cherry picked from commit d448cf1943
8 months ago
227c9cb6b6
Disabling linter due to unknown issue
...
Signed-off-by: Matt Farina <matt.farina@suse.com>
8 months ago
4389fa639a
Updating link handling
...
Signed-off-by: Matt Farina <matt.farina@suse.com>
(cherry picked from commit 76fdba4c8c
8 months ago
2c55a4e8ce
fix: user username password for login
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
9 months ago
a16e986d4e
Update pkg/registry/transport.go
...
Co-authored-by: Scott Rigby <scott@r6by.com>
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
9 months ago
cea26d8bca
Update pkg/registry/transport.go
...
Co-authored-by: Scott Rigby <scott@r6by.com>
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
9 months ago
b52bb41484
fix: add debug logging to oci transport
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
Co-authored-by: Billy Zha <jinzha1@microsoft.com>
9 months ago
733f94c86a
fix: legacy docker support broken for login
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
9 months ago
9d56978f65
Merge pull request #30938 from TerryHowe/backport-fix-plugin-install-no-internet
...
fix: backport plugin installer test with no Internet
9 months ago
fc36041702
fix: plugin installer test with no Internet
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
10 months ago
62759a819e
Merge pull request #30916 from jessesimpson36/v3-remove-registry-login-url-with-tests
...
test: add functional tests for "Fix 3.18.0 regression: registry login with scheme"
10 months ago
cfe8cef46f
Handle an empty registry config file.
...
In the move to oras v2, an existing but empty registry config file
became an uncaught error. A missing file caused no error. This
change catches the error and works around it so that Helm can
continue to be fault tolerant to this issue.
Signed-off-by: Matt Farina <matt.farina@suse.com>
10 months ago
c33215d765
Prevent fetching newReference again as we have in calling method
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
10 months ago
f552b67230
Prevent failure when resolving version tags in oras memory store
...
- The newReference() function transforms version tags by replacing + with _ for OCI compatibility
- But the code was using the original ref (with +) for TagBytes()
- Then it tries to find the tagged reference using parsedRef.String() (with _)
- This mismatch causes the Resolve method to fail with "not found"
- By using parsedRef.String() consistently in both places, the references will match and the lookup will succeed.
I extracted the TagBytes function to improve testability.
Push() includes several external calls that are hard to mock,
so isolating this logic makes testing more manageable.
Close : #30881
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
10 months ago
806d59750a
Merge pull request #30902 from brandtkeller/30890_prov_mediatype_allow
...
fix(client): allow layer selection permissive
10 months ago
e37962522c
Merge pull request #30887 from scottrigby/v3-remove-registry-login-url
...
Fix 3.18.0 regression: registry login with scheme
10 months ago
a18a52e898
fix(client): skipnode utilization for PreCopy
...
Co-authored-by: George Jenkins <gvjenkins@gmail.com>
Signed-off-by: Brandt Keller <43887158+brandtkeller@users.noreply.github.com>
10 months ago
fedf5024d6
test: Skip instead of returning early. looks more intentional
...
Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>
10 months ago
fe512bae43
test: tests repo stripping functionality
...
Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>
10 months ago
099a9e18f3
test: include tests for Login based on different protocol prefixes
...
Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>
10 months ago
b07ab77da3
fix(client): layers now returns manifest - remove duplicate from descriptors
...
Signed-off-by: Brandt Keller <brandt.keller@defenseunicorns.com>
10 months ago
c225c124ac
fix(client): return nil on non-allowed media types
...
Signed-off-by: Brandt Keller <brandt.keller@defenseunicorns.com>
10 months ago
c0f3ace52d
Fix 3.18.0 regression: registry login with scheme
...
Helm 3.18.0 released an upgrade of ORAS from v1 to v2.
ORAS v2 correctly does not accept http/https scheme for registry login, while
ORAS v1 previously did. Even if v1 should not have, we want to preserve
backwards compatibility for Helm 3 users who pass the scheme.
This will be removed in Helm 4, where registry login will not accept http/https
scheme.
Co-authored-by: Andrew Block <andy.block@gmail.com>
Co-authored-by: Terry Howe <terrylhowe@gmail.com>
Signed-off-by: Scott Rigby <scott@r6by.com>
10 months ago
f147277a59
Merge pull request #30885 from helm/revert-13534-dev-v3-12987
...
Revert "fix (helm) : toToml` renders int as float [ backport to v3 ]"
10 months ago
dce60adb51
Update pkg/plugin/plugin.go
...
Co-authored-by: George Jenkins <gvjenkins@gmail.com>
Signed-off-by: Benoit Tigeot <benoittgt@users.noreply.github.com>
10 months ago
cda0865d64
Update pkg/plugin/plugin.go
...
Co-authored-by: George Jenkins <gvjenkins@gmail.com>
Signed-off-by: Benoit Tigeot <benoittgt@users.noreply.github.com>
10 months ago
5d9d9a0fb8
Wait for Helm v4 before raising when platformCommand and Command are set
...
same for `PlatformHooks` and `hooks`.
When backporting a feature for Helm v3 we forgot to mark as deprecation
validations that will enforced in v4.
See (search for "Remove in Helm 4."):
- https://github.com/helm/helm/pull/13592/files#diff-fc137d62147eb6a9c89c0566479ff219320ca691f2505631ebacbe513bcc8108R268-R270
Fix:
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
10 months ago
c5249c1f8d
Revert "fix (helm) : toToml` renders int as float [ backport to v3 ]"
...
This change has caused issues with numerous charts around things
unrelated to toml. This is because of functions like typeIs/typeOf
being used and acted upon.
The change caused a significant regression.
Closes #30880
Signed-off-by: Matt Farina <matt@mattfarina.com>
10 months ago
afefca8b2d
chore: update generalization warning message
...
Signed-off-by: Feng Cao <24779889+shfc@users.noreply.github.com>
10 months ago
Scott Rigby
Luna Stadler
Matt Farina
George Jenkins
Matheus Pimenta
Benoit Tigeot
Evans Mungai
Isaiah Lewis
Robert Sirchia
Borys Hulii
Terry Howe
Reinhard Nägele
Brandt Keller
Jesse Simpson
Brandt Keller
Benoit Tigeot
Matt Farina
Feng Cao