26 Commits (18ed620bc219bb36752747d9eef78de3fa25303e)

Author	SHA1	Message	Date
Simon Alling	a7c285bf7e	ref(pkg/chartutil): Improve error handling code in Save ... While working on #6519, it took me hours to figure out why the error returned from `Save` was nil even though `writeTarContents` returned a non-nil error. I fixed the bug as part of that PR; the purpose of this commit is to prevent it from happening again. What made me (as a Go beginner) so confused was the impression that there was only ever one `err` variable, global to the entire `Save` function, when in fact there were also several local ones shadowing it. (I thought := could be used to reassign an existing variable.) This commit makes it clear that any `err` defined locally in the last `if` statement will not be returned at the end, and hence must be explicitly returned in the body of said `if` statement. (This commit initially was larger; see #6669.) Signed-off-by: Simon Alling <alling.simon@gmail.com>	6 years ago
Simon Alling	2a462aef2d	fix(pkg/chartutil): add tests according to feedback ... The seemingly redundant `return filename, err` line is related to how the name `err` is used throughout the function: there is a "global" (to the function) `err` variable, as well as several locally block-scoped ones. It took me hours to understand why my code did not work without that line, but I decided not to clean up the `err` code in this commit. Signed-off-by: Simon Alling <alling.simon@gmail.com>	6 years ago
Simon Alling	50675e7cd7	fix(pkg/chartutil): include values.schema.json in packaged chart ... Before this commit: $ helm lint my-chart # Finds errors in values.yaml $ helm package my-chart $ helm lint my-chart-1.0.0.tgz # Does not find errors in values.yaml Signed-off-by: Simon Alling <alling.simon@gmail.com> Co-authored-by: Andreas Lindhé <andreas@lindhe.io>	6 years ago
wxdao	c00890cae1	Fix Save misbehavior on nonexistent directory (#6360) ... Signed-off-by: wxdao <waxiadao@gmail.com>	6 years ago
Matt Farina	9bc7934f35	Updating the module for v3 as the major version ... Signed-off-by: Matt Farina <matt@mattfarina.com>	6 years ago
Simon Alling	43bb10cd24	ref(pkg/chartutil): Dry up file and path names (#6554) ... Signed-off-by: Simon Alling <alling.simon@gmail.com>	6 years ago
Adam Reese	b6fdd8783b	feat(cmd/helm): remove need for helm init command ... * allow repository config via cli * make `helm repo add` create repo config file if it does not exist * squash a ton of bugs Signed-off-by: Adam Reese <adam@reese.io>	6 years ago
Matthew Fisher	d99edbfb3e	fix(chartutil): remove executable bits from chartutil generated files ... Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>	6 years ago
Josh Dolitsky	cc5dece910	fix(chartutil): Ensure nested template dir on save (#6177) ... If a templates/ dir of a chart contained a subdirectory, for example "templates/tests/test-db.yaml", an error was being thrown on export due to missing the "templates/test" directory prior to saving the template file itself. Fixes #5757 Signed-off-by: Josh Dolitsky <jdolitsky@gmail.com>	6 years ago
Oleg Sidorov	ec440d446d	Replaced ghodss/yaml with sigs.k8s.io/yaml ... This commit replaces usage of github.com/ghodss/yaml with it's forked version maintained by SIG community. The replaced library has low-to-none support activity unlike the latter. We believe the new Helm branch could benefit from using the community-supported version on a long-term run as yaml parser is a key component of Helm chart rendering engine. This commit locks sigs.k8s.io/yaml dependency version on 1.1.0 which is backwards compatible with ghodss/yaml 1.0.0. This change also resolves the outdated dependency version lock for ghodss/yaml (currently 1.0.0) and makes it possible to port changes from https://github.com/helm/helm/pull/6010 to dev-v3. Signed-off-by: Oleg Sidorov <oleg.sidorov@booking.com>	6 years ago
Matthew Fisher	d3f0ac9343	ref(create): app version should be 0.1.0 ... When creating a Helm chart for the first time, the assumption should be that the app version is also 0.1.0, implying this is for a new application. Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>	7 years ago
Adam Reese	e458a67f0c	ref(pkg/chart): add validation method to chart ... Consolidate validation of Chart.yaml. Signed-off-by: Adam Reese <adam@reese.io>	7 years ago
Adam Reese	895e9192d4	feat(*): use vanity import helm.sh/helm ... Signed-off-by: Adam Reese <adam@reese.io>	7 years ago
Adam Reese	516c53dae6	ref(chart): use map for chart.Values ... Signed-off-by: Adam Reese <adam@reese.io>	7 years ago
Adam Reese	4f26b658d8	change copyright to "Copyright The Helm Authors"	7 years ago
Adam Reese	f012940d9c	ref(*): refactor chart/chartutil ... ref(chartutil): move chart loading out of chartutil into new package add chart loader interface to allow lazy loading feat(chart): create chart accessors ref(*): cleanup requirements ref(tiller): remove optional template engines ref(tiller): simplify sorting releases and hooks ref(*): code simplification ref(hapi): move chart package out of hapi ref(chart): add requirements and lock to Chart struct	7 years ago
Adam Reese	726e3c41be	feat(*): print stacktrace on error with debug enabled	8 years ago
Adam Reese	4c95185164	ref(*): replace chart.config with []byte	8 years ago
Adam Reese	36536d77ba	ref(*): remove protobuf any type	8 years ago
Adam Reese	6345f04190	ref(hapi): convert protobuf to go types	8 years ago
Jean-Philippe Courson	5b77335415	Create missing directories when saving files in chartutil.SaveDir	8 years ago
Amanda Cameron	415e52bf55	Add support for sub-directory scanning as in issue #1401	8 years ago
Matt Butcher	784a339627	feat(helm): support 'helm create --pack=mypack' ... This adds support for packs, pre-configured chart patterns that can be used to quickly create a custom layout for your new chart.	9 years ago
Matt Butcher	e757b24aed	fix(*): add license header	9 years ago
Adam Reese	818c878700	chore(*): use k8s.io as the import path	9 years ago
Matt Butcher	15a1cb4816	feat(chartutil): add Save function ... This replicates the previous Save function, which can save an in-memory Chart proto to a tgz.	9 years ago