188ac4e834
Merge pull request #31635 from banjoh/em/fix-ssa-upgrade-install-cmd
...
fix(upgrade): pass --server-side flag to install when using upgrade --install
2 weeks ago
5d2ab10caa
Merge pull request #12564 from hiddeco/supersede-on-uninstall
...
fix(uninstall): supersede deployed releases
2 weeks ago
b52b6615f0
Merge pull request #31207 from zyfy29/delete-unused-var
...
chore: delete unused var in installer.go
2 weeks ago
2597088a20
Merge pull request #31586 from calvinbui/main
...
fix: use length check for MetaDependencies instead of nil comparison
2 weeks ago
4cf7d8d025
Merge pull request #31641 from wangjingcun/main
...
chore: fix some comments to improve readability
2 weeks ago
d28853e206
Merge pull request #31624 from atombrella/feature/sloglint
...
Enable the `sloglint` linter
2 weeks ago
642462e9fe
Merge pull request #11991 from twz123/no-bash-in-testscripts
...
Make test scripts run without /bin/bash
2 weeks ago
858cf31583
chore: fix some comments to improve readability
...
Signed-off-by: wangjingcun <wangjingcun@aliyun.com>
2 weeks ago
2dc581dc1c
fix(upgrade): pass --server-side flag to install when using upgrade --install
...
When running `helm upgrade --install` on a non-existent release, the
--server-side flag was not being passed to the install action. This
caused the install to always use server-side apply (the default),
ignoring --server-side=false.
Copy ServerSideApply and ForceConflicts from the upgrade client to the
install client when falling back to install.
Fixes #31627
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
2 weeks ago
a18e59e465
Enable the sloglint linter
...
Signed-off-by: Mads Jensen <atombrella@users.noreply.github.com>
2 weeks ago
7edfdb6c5e
Merge pull request #31549 from benoittgt/31548
...
fix: prevent reporting fallback on version when none specified
3 weeks ago
3165e5463a
Merge pull request #31528 from benoittgt/31423-git-version
...
fix: preserve vendor suffixes in KubeVersion.GitVersion
3 weeks ago
ff35414bed
Merge pull request #31546 from benoittgt/31544-nil-pointer
...
fix(lint): prevent segmentation violation on only comment yaml in multidoc
4 weeks ago
dfa1e3c3c5
Merge pull request #31562 from atombrella/feature/modernize
...
Use modernize to use newer Golang features.
4 weeks ago
51076a073a
Merge pull request #31519 from TerryHowe/chore-add-warning-for-registry-login
...
chore: add warning for registry login with namespace
4 weeks ago
b33d4ae0c0
Use length check for MetaDependencies instead of nil comparison
...
Signed-off-by: Calvin Bui <3604363+calvinbui@users.noreply.github.com>
4 weeks ago
e71a29ce4f
chore: fix typo in pkg/downloader/chart_downloader.go
...
Signed-off-by: megha1906 <meghabansal135@gmail.com>
1 month ago
722482b77d
Merge pull request #31561 from atombrella/feature/nilness_cleanup
...
Remove two redundant if-checks.
1 month ago
6cceead399
Use modernize to use newer Golang features.
...
The rangeint suggestion is faster.
The maps.Copy and slices.Contains are just syntatic sugar.
Signed-off-by: Mads Jensen <atombrella@users.noreply.github.com>
1 month ago
380abe2b16
Remove two redundant if-checks.
...
These were found with the nilness checker.
Signed-off-by: Mads Jensen <atombrella@users.noreply.github.com>
1 month ago
936cd328ac
Fix kube client logging
...
The kube client logging is based on the actionConfig logging. This
is setup to use slog.Default() before the logging flags are parsed
and logging is setup.
newRootCmdWithConfig changes the logging but it wasn't picked up
for actionConfig or the kube client. This change updates the logging
to include any changes.
Signed-off-by: Matt Farina <matt.farina@suse.com>
1 month ago
61d289c119
Merge pull request #31518 from gjenkins8/gjenkins/fix_update_create
...
fix: Use server-side apply for object create during update
1 month ago
698fcd2290
Merge pull request #31515 from gjenkins8/gjenkins/copy_adopted
...
fix: Copy adopted resource info
1 month ago
81d244ca21
fix: prevent segmentation violation on empty yaml in multidoc
...
Fixes: https://github.com/helm/helm/issues/31544
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
1 month ago
40e22dedb2
fix: prevent reporting fallback on version when none specified
...
Fixes: https://github.com/helm/helm/issues/31548
```
❯ helm pull rancher/longhorn-crd --version 106.2.0+up1.8.2 --destination /tmp/
level=WARN msg="unable to find exact version; falling back to closest available version" chart=longhorn-crd requested=106.2.0+up1.8.2 selected=106.2.0+up1.8.1
❯ bin/helm show chart brigade/brigade
apiVersion: v1
appVersion: v1.5.0
dependencies:
- condition: kashti.enabled
name: kashti
repository: https://brigadecore.github.io/charts
version: 0.7.0
- condition: brigade-github-app.enabled
name: brigade-github-app
repository: https://brigadecore.github.io/charts
version: 0.8.0
- alias: gw
condition: gw.enabled
name: brigade-github-oauth
repository: https://brigadecore.github.io/charts
version: 0.4.0
description: Brigade provides event-driven scripting of Kubernetes pipelines.
name: brigade
version: 1.10.0
```
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
1 month ago
df6aafeeee
Merge pull request #31462 from mattfarina/load-archive
...
Adding a LoadArchive to common loader
1 month ago
63858b383f
Merge pull request #31535 from mattfarina/bump-4.1
...
bump version to 4.1
1 month ago
eb3da36e2e
Merge pull request #31530 from shuv0id/improve-debug-logging
...
fix: add missing context to debug logs
1 month ago
63dcb5c74c
Merge pull request #31464 from benoittgt/fix-test
...
Properly test error messages on pull command's test
1 month ago
63e060fb05
bump version to 4.1
...
Signed-off-by: Matt Farina <matt.farina@suse.com>
1 month ago
2dc5864f44
fix: add missing context to debug logs
...
Adds chart name to dependency logs, namespace to resource waiting logs,
and confirmation message when all resources are ready.
Addresses #31520
Signed-off-by: shuv0id <110290476+shuv0id@users.noreply.github.com>
1 month ago
ce273eea48
fix: preserve vendor suffixes in KubeVersion.GitVersion
...
Helm 3.19.0 introduced a regression where vendor-specific suffixes
(e.g., -gke.1245000, -eks-4096722, +) are stripped from
.Capabilities.KubeVersion.GitVersion, breaking charts that detect
managed Kubernetes platforms.
The root cause was using k8sversion.ParseGeneric().String() which
intentionally discards vendor suffixes. The fix stores both the full
version (with vendor suffix) and a normalized version. String() returns
the normalized version for constraint checking (e.g., ">= 1.21.0"),
while Version/GitVersion preserve the full string for template access.
Fixes #31423
Related to #31063 , #31078
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
1 month ago
f8a49f1852
fixup test
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
1 month ago
a9cdc78116
logs
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
1 month ago
b1a976073f
fix
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
1 month ago
5f3c617940
chore: add warning for registry login with namespace
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
1 month ago
a75fcc2948
Merge pull request #31478 from promalert/main
...
refactor: use strings.Builder to improve performance
1 month ago
18616e6ce9
fix: Use server-side apply for object create during update
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
1 month ago
ebd5f53fc3
Merge pull request #31421 from benoittgt/improve-doc-wait-strategy
...
Unify --wait strategy inputs, clarify defaults and docs; avoid SDK timeout footgun
1 month ago
855ebb6884
Copy adopted resource info
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
1 month ago
b740071279
Merge pull request #31342 from TerryHowe/chore-remove-mitchellh-dependency-3
...
chore: replace github.com/mitchellh/copystructure
1 month ago
e7ac8fe3b8
Merge pull request #30984 from fm1ck3y/bug/index-concurrency
...
feat(concurrency): allow concurrent dependency build with atomic file write
1 month ago
d57fb45648
Merge pull request #31469 from saimanojk1/issue-31454
...
Convert pkg/cmd/load_plugins.go to slog
1 month ago
d8c4040336
refactor: use strings.Builder to improve performance
...
Signed-off-by: promalert <promalert@outlook.com>
2 months ago
0ee89d2d4e
Merge pull request #31418 from tisonkun/typo
...
chore: fix typo of public field
2 months ago
02312a1cf2
Update pkg/cmd/flags.go
...
Co-authored-by: George Jenkins <gvjenkins@gmail.com>
Signed-off-by: Benoit Tigeot <benoittgt@users.noreply.github.com>
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
2 months ago
277c140c87
Error strategy list match help
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
2 months ago
5f6fa437b2
Prevent surprising failure with SDK when timeout is not set
...
While testing SDK features for v4. I was surprised with the error:
"reporter failed to start: event funnel closed: context deadline exceeded"
This occurs when no timeout is set:
```
upgradeClient := action.NewUpgrade(actionConfig)
upgradeClient.WaitStrategy = kube.StatusWatcherStrategy
// When Timeout is zero, the status wait uses a context with zero timeout which
// immediately expires causing "context deadline exceeded" errors.
upgradeClient.Timeout = 2 * time.Minute
```
With this patch it will work without specifying.
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
2 months ago
52a282832f
Do not change the default waiting strategy when --wait is not set
...
It is too much a breaking change for a new RC of beta V4.
See comment: https://github.com/helm/helm/pull/31421#discussion_r2465121438
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
2 months ago
11128659aa
Provide more help for SDK user when setting up WaitStrategy
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
2 months ago
Terry Howe
Robert Sirchia
wangjingcun
Evans Mungai
Mads Jensen
George Jenkins
Matt Farina
Calvin Bui
megha1906
Benoit Tigeot
shuv0id
Scott Rigby
promalert
Benoit Tigeot