6c45810119
chore(internal): refactor: convert tests to testify assert/require part 4 ( #32408 )
...
refactor: convert tests to testify assert/require in internal/chart/v3/util
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
1 week ago
82be04d7f2
remove legacy import comments from remaining packages ( #31933 )
...
Pre-Go-modules import path comments (e.g. `// import "helm.sh/helm/v4/..."`)
are obsolete since Go 1.11 where go.mod is the authoritative module path.
These stale comments cause issues with downstream tooling such as Kythe.
Removes the legacy import comments from 64 files across 20 packages:
- cmd/helm
- internal/chart/v3/lint and sub-packages
- internal/plugin and sub-packages
- internal/release/v2/util
- pkg/chart/v2/lint and sub-packages
- pkg/cmd, pkg/engine, pkg/ignore, pkg/provenance
- pkg/registry
- pkg/release/v1/util
- pkg/repo/v1
- pkg/storage and pkg/storage/driver
Follows up on #31931 and #31932 which addressed pkg/kube.
Fixes #31846
Signed-off-by: abhay1999 <abhay.chaurasiya@example.com>
Signed-off-by: abhay1999 <abhaychaurasiya19@gmail.com>
1 week ago
a2b1a60d51
fix: enhance error handling and improve test assertions ( #32352 )
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
1 week ago
1367d76f0a
Merge pull request #32343 from mmorel-35/testifylint-manual-assert-internal-3
...
chore(internal): refactor: convert tests to testify assert/require part 3
2 weeks ago
9c373bf4fc
Merge pull request #32327 from fluxcd/fix-32326
...
Fix vanishing empty lines
2 weeks ago
caac755f19
chore(internal): refactor: convert tests to testify assert/require part 3
...
refactor: convert tests to testify assert/require in internal/chart/v3/lint/rules
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2 weeks ago
9aa7778886
Merge pull request #32342 from mmorel-35/testifylint-manual-assert-internal-2
...
chore(internal): refactor: convert tests to testify assert/require part 2
2 weeks ago
a02a5713de
chore: fix elseif and ifElseChain issues from gocritic ( #32289 )
...
* chore: fix elseif and ifElseChain issues from gocritic
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
* test: enhance assertions in OCIInstaller and list tests using testify
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
---------
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2 weeks ago
7a7b328ba5
Merge pull request #32319 from mmorel-35/revive
...
feat(linters): add new revive rules for better code quality
2 weeks ago
66c1232dc7
Merge pull request #32321 from mmorel-35/gocritic
...
refactor: enable several checks from gocritic
2 weeks ago
f280d9c1b5
chore(internal): refactor: convert tests to testify assert/require part 2
...
refactor: convert tests to testify assert/require in internal/chart/v3/util
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2 weeks ago
d72b28ebcb
chore(internal): refactor: convert tests to testify assert/require part 1
...
refactor: convert tests to testify assert/require in internal/chart/v3/lint/rules
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2 weeks ago
bfebbb7c1a
Fix vanishing empty lines
...
Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
3 weeks ago
16787d65f5
feat(linters): add new revive rules for better code quality
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
3 weeks ago
9662fdd73b
refactor: enable several checks from gocritic
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
3 weeks ago
d262c7ca79
Merge pull request #32296 from mmorel-35/gocritic-singleCaseSwitch
...
chore: fix emptyStringTest, nestingReduce and singleCaseSwitch checks issues from gocritic
3 weeks ago
96b315f188
chore: fix emptyStringTest, nestingReduce and singleCaseSwitch checks issues from gocritic
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
3 weeks ago
4ade4a5495
test: replace assert.Contains with assert.ErrorContains for better error handling
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
3 weeks ago
f34ad6c337
chore: fix several checks issues from testifylint
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
3 weeks ago
07259ecc86
chore: fix several checks issues from gocritic
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
3 weeks ago
addbab2e64
refactor(internal): convert tests to testify assert/require
...
Convert internal/urlutil, internal/cli/output, internal/monocular,
and internal/sympath test files from native Go testing patterns
(t.Errorf, t.Fatalf, t.Error, t.Fatal) to github.com/stretchr/testify
equivalents (assert.X, require.X).
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
1 month ago
dd31a27000
Merge pull request #32256 from gjenkins8/refactor/testify-internal-util
...
refactor(internal): convert tests to testify assert/require
1 month ago
7ab295fcfc
refactor(internal/release): convert tests to testify assert/require
...
Replace native Go testing patterns (t.Errorf, t.Fatalf, t.Error,
t.Fatal) with github.com/stretchr/testify equivalents (assert.X,
require.X) for improved test readability and error messages.
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
1 month ago
3ce02c585a
refactor(internal): convert tests to testify assert/require
...
Convert internal/fileutil, internal/tlsutil, and internal/resolver
test files from native Go testing patterns (t.Errorf, t.Fatalf,
t.Error, t.Fatal) to github.com/stretchr/testify equivalents
(assert.X, require.X).
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
1 month ago
34cfdfdbe5
chore: enable contextcheck, fatcontext and noctx linters
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
1 month ago
a092a1bd09
Merge pull request #31859 from biagiopietro/feature/rollback-revision-history
...
feat(history): add rollback revision column to helm history output
1 month ago
253da5106a
Merge pull request #32171 from mmorel-35/empty-len
...
Fix empty and len testifylint violations across test files
1 month ago
81d6f04c82
Merge pull request #30867 from mmorel-35/gocritic
...
chore: fix deprecatedComment issues from gocritic
2 months ago
1b360574a9
Merge branch 'helm:main' into feature/rollback-revision-history
2 months ago
59b57c5c31
Merge pull request #31885 from mmorel-35/whitespace
...
chore: fix whitespace linter
2 months ago
488c4a805d
Fix empty and len testifylint violations across test files
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2 months ago
d374e823b2
Merge pull request #32086 from mmorel-35/error-is-as
...
testifylint: enable error-is-as and error-nil rules
2 months ago
8250ba6152
Merge branch 'helm:main' into feature/rollback-revision-history
2 months ago
979e68fbbd
internal/plugin: remove zero-width spaces from plugin name comment
...
The comment describing allowed plugin name characters contained three
U+200B (zero-width space) characters around the '_' and '-' literals.
The rendered comment is identical without them; the ZWSP were likely
copy-pasted from a rich-text source.
Downstream impact: every project that vendors helm.sh/helm/v4 and runs
Renovate gets a repo-wide warning on its Dependency Dashboard about
hidden Unicode characters. Renovate scans the whole tree (including
vendor/) for ZWSP/bidi-override codepoints and cannot be told to skip
a path for this specific check. Removing the characters here clears
the warning everywhere downstream.
Signed-off-by: Aleksei Sviridkin <f@lex.la>
2 months ago
6c3f397d2c
Merge pull request #32122 from quyentonndbs/chore/lint-deprecations-comment-typo
...
docs: fix typo in deprecated API godoc
2 months ago
291a1a3b26
Merge branch 'helm:main' into feature/rollback-revision-history
2 months ago
2032ec5cba
docs: fix 'than'->'that' typo in deprecatedAPIError godoc
...
Signed-off-by: Kai Tanaka <275430420+quyentonndbs@users.noreply.github.com>
3 months ago
432fc8a217
refactor: use slices.Backward to simplify the code
...
Signed-off-by: box4wangjing <box4wangjing@outlook.com>
3 months ago
38336f84ec
Merge branch 'helm:main' into feature/rollback-revision-history
3 months ago
19b3656306
Bump to version v4.2 ( #32102 )
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
3 months ago
dc04059ea3
Merge branch 'helm:main' into feature/rollback-revision-history
3 months ago
f8ba28bb17
testifylint: enable error-is-as and error-nil rules
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
3 months ago
a4a9cc7a31
Upgrade Go to 1.26, Kubernetes to 1.36, kstatus to 1.1
...
Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
3 months ago
4bd9e90aa0
Merge pull request #30811 from mmorel-35/testifylint
...
chore: fix bool-compare issues from testifylint
3 months ago
3838d2d2dd
Merge branch 'helm:main' into feature/rollback-revision-history
3 months ago
265c5eb530
fix(templating): SplitManifests must preserve line endings for downstream YAML parsers ( #31952 )
...
* fix(templating): SplitManifests must preserve line endings for downstream YAML parsers
Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
* Address copilot comment about skipping empty docs
Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
* Port fix to release v2
Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
* Address copilot comments
Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
---------
Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
3 months ago
41ba370236
Merge branch 'helm:main' into feature/rollback-revision-history
4 months ago
087736b66e
fix: unnecessary-format lint issues from merge
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
4 months ago
586eb57338
fix: Plugin missing provenance bypass
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
4 months ago
f7c4d75574
Merge commit from fork
...
fix: Chart dot-name path bug
4 months ago
Matthieu MOREL
Abhay Chaurasiya
George Jenkins
Matheus Pimenta
Terry Howe
MrJack
Evans Mungai
Aleksei Sviridkin
Robert Sirchia
Kai Tanaka
box4wangjing