naving1989
4310b2bc36
Fixed linting issues
...
Signed-off-by: naving1989 <navinag1989@gmail.com>
3 months ago
Zach Burgess
1002ec5ae9
Update tests in lint_test.go
...
Signed-off-by: Zach Burgess <zachburg@google.com>
3 months ago
Zach Burgess
35434947a3
Return a lint warning if `templates/` does not exist.
...
Signed-off-by: Zach Burgess <zachburg@google.com>
3 months ago
Zach Burgess
b6e3301bef
Merge branch 'helm:main' into templates_lint
3 months ago
Zach Burgess
fe11438715
Raise error instead of warning if `crds/` is not a valid directory
...
Signed-off-by: Zach Burgess <zachburg@google.com>
3 months ago
Zach Burgess
eea2d4577b
Raise an error if the `templates/` dir is not valid and return early.
...
Signed-off-by: Zach Burgess <zachburg@google.com>
3 months ago
Mohammadreza Asadollahifard
1e00790b8c
refactor tests to use t.Setenv for NO_COLOR environment variable
...
Signed-off-by: Mohammadreza Asadollahifard <mazafard@gmail.com>
3 months ago
Mohammadreza Asadollahifard
c547d1f2ae
add color output functionality and tests for release statuses
...
Signed-off-by: Mohammadreza Asadollahifard <mazafard@gmail.com>
3 months ago
Zach Burgess
3a318c2fa3
Update crds.go after https://github.com/helm/helm/pull/31029
...
Signed-off-by: Zach Burgess <zachburg@google.com>
3 months ago
Zach Burgess
81af3c9570
Merge branch 'helm:main' into crds_lint
3 months ago
George Jenkins
d21a8a04cb
Merge pull request #31029 from gjenkins8/gjenkins/k8s_yaml_struct
...
chore(refactor): Privatize 'k8sYamlStruct'
3 months ago
Zach Burgess
cc85352a0e
Use `assert.Len` instead of `assert.Lenf`
...
The default message from testify is descriptive enough.
Signed-off-by: Zach Burgess <zachburg@google.com>
3 months ago
Zach Burgess
c59a097209
Remove duplicate test case from crds_test.go
...
The "good" test case for CRDs is done in `TestGoodChart` in lint_test.go.
Signed-off-by: Zach Burgess <zachburg@google.com>
3 months ago
naving1989
3b2f9e7d6f
test: increase test coverage for pkg/cli/options.go file
...
Signed-off-by: naving1989 <navinag1989@gmail.com>
3 months ago
Zach Burgess
bf9084a16a
Rename `validateCrdApiVersion` to `validateCrdAPIVersion`
...
Signed-off-by: Zach Burgess <zachburg@google.com>
3 months ago
Zach Burgess
357957b0d3
Use testify and add a CRD to the `goodone` test case.
...
Signed-off-by: Zach Burgess <zachburg@google.com>
3 months ago
Zach Burgess
dadaff716a
Merge branch 'helm:main' into crds_lint
3 months ago
Zach Burgess
6e30619d8f
Merge branch 'helm:main' into templates_lint
3 months ago
Matt Farina
76fdba4c8c
Updating link handling
...
Signed-off-by: Matt Farina <matt.farina@suse.com>
3 months ago
George Jenkins
bbea98ed6b
Merge pull request #30898 from fidelity-contributions/fix-issue-13198
...
Fix issue 13198
3 months ago
George Jenkins
4c674728d2
Privatize 'k8sYamlStruct'
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
3 months ago
George Jenkins
edd0dabe02
Merge pull request #31021 from zachburg/test_temp_dir
...
Update tests in create_test.go and package_test.go to work in a temp directory
3 months ago
Matt Farina
e8be2e540d
Merge pull request #31023 from gjenkins8/gjenkins/rm_recreate_pods
...
Remove deprecated '--create-pods' flag
3 months ago
Matt Farina
f684da6561
Merge pull request #31024 from helm/gjenkins/fix_lint_test_flake
...
fix: 'TestRunLinterRule' stateful test
3 months ago
George Jenkins
a3bcc5b184
fix: 'TestRunLinterRule' stateful test
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
3 months ago
George Jenkins
5283915c57
Remove deprecated '--create-pods' flag
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
3 months ago
George Jenkins
de1bdf5820
switch to slog
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
3 months ago
George Jenkins
62ca98f521
fix up verbiage
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
3 months ago
George Jenkins
5f9cbe6f4a
fix: Port pluginCommand & command warning
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
3 months ago
Zach Burgess
eaf40b4b4f
Call `ensure.HelmHome()` in package_test.go
...
Signed-off-by: Zach Burgess <zachburg@google.com>
3 months ago
Matt Farina
9517cfc5ce
Merge pull request #31009 from tpresa/test-coverage-pusher
...
test: increase test coverage for pkg/pusher
3 months ago
Zach Burgess
c48a3435f5
Remove unnecessary calls for changing directory to `helmpath.CachePath`.
...
This was only set on some tests in create_test.go and isn't
affecting the test.
Signed-off-by: Zach Burgess <zachburg@google.com>
3 months ago
Carlos Lima
6991a0a531
Make annotateAndMerge deterministic
...
Signed-off-by: Carlos Lima <carlos@cpan.org>
3 months ago
Carlos Lima
c01e76b5c3
review: change annotation name to postrenderer.helm.sh/postrender-filename
...
Signed-off-by: Carlos Lima <carlos@cpan.org>
3 months ago
Carlos Lima
a1416cf225
review: style changes
...
Signed-off-by: Carlos Lima <carlos@cpan.org>
3 months ago
Carlos Lima
859721bd77
review: rewrite error messages from the end-user perspective
...
Signed-off-by: Carlos Lima <carlos@cpan.org>
3 months ago
Carlos Lima
b26b473bf6
review: make splitAndDeannotate private
...
Signed-off-by: Carlos Lima <carlos@cpan.org>
3 months ago
Carlos Lima
855b5a44b7
review: make annotateAndMerge private
...
Signed-off-by: Carlos Lima <carlos@cpan.org>
3 months ago
Carlos Lima
1d993f9e2d
review: make filenameAnnotation private
...
Signed-off-by: Carlos Lima <carlos@cpan.org>
3 months ago
Carlos Lima
e6362d74c8
Allow post-renderer to process hooks
...
This annotates and merges all manifests before sending to the
postrender, reversing the process and recovering the filenames
afterwards.
closes #7891
Signed-off-by: Carlos Lima <carlos@cpan.org>
3 months ago
Zach Burgess
3b26ddc22b
Update tests in create_test.go and package_test.go to work in a temp dir.
...
Signed-off-by: Zach Burgess <zachburg@google.com>
3 months ago
Zach Burgess
b703d5b4bb
Return early when linting if the `templates/` dir does not exist
...
The `vaildateTemplatesDir` function would still return `nil` if the directory doesn't exist,
so the early return that was documented never occurs.
Signed-off-by: Zach Burgess <zachburg@google.com>
3 months ago
Zach Burgess
a99c3700f0
Return early if the `/crds` directory does not exist.
...
Don't silently discard the error from `os.Stat`.
Signed-off-by: Zach Burgess <zachburg@google.com>
3 months ago
Zach Burgess
562ff982cb
Early return if the `/crds` directory does not exist and don't silently discard the error from `os.Stat`.
...
Signed-off-by: Zach Burgess <zachburg@google.com>
3 months ago
Zach Burgess
d6ddd8e661
Document that attempting to parse YAML checks that the CRD is not a
...
template
Signed-off-by: Zach Burgess <zachburg@google.com>
3 months ago
Zach Burgess
e4c88faeff
Update test assertions
...
Signed-off-by: Zach Burgess <zachburg@google.com>
3 months ago
Zach Burgess
bc35ea5ad7
Fix comment in pkg/lint/rules/testdata/invalidcrdsdir/values.yaml
...
Signed-off-by: Zach Burgess <zachburg@google.com>
3 months ago
Zach Burgess
21b9aa3d94
Lint the `crds/` directory.
...
This checks that the `crds/` dir only contains YAML files that define
K8s resources with `kind: CustomResourceDefinition`.
Checking that the YAML files are not templates will be done in a
separate commit.
Signed-off-by: Zach Burgess <zachburg@google.com>
3 months ago
Matt Farina
ca769df369
Merge pull request #31018 from mattfarina/make-logging-configurable
...
Move logging setup to be configurable
3 months ago
Thiago Presa
afd63fed77
test: increase test coverage for pkg/pusher
...
Signed-off-by: Thiago Presa <thiago.addevico@gmail.com>
3 months ago