Evans Mungai
03b535d6b7
Merge branch 'main' into em/check-ownership-before-delete
...
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
6 days ago
Terry Howe
08f17fc947
Merge pull request #31683 from majiayu000/fix-13198---api-versions-is-undocumented-1230-2329
...
fix: `--api-versions` is undocumented
1 week ago
George Jenkins
fa41d60d73
Merge pull request #31239 from StephanieHhnbrg/test-actions-pkg
...
Add tests to action package to improve coverage
1 week ago
Mads Jensen
2d6d9c09c4
Replace reflect.Ptr with reflect.Pointer
...
The reflect package has a go:fix annotation for Ptr = Pointer.
Signed-off-by: Mads Jensen <atombrella@users.noreply.github.com>
2 weeks ago
majiayu000
c7cc77b68d
Add documentation for --api-versions flag in template command
...
The --api-versions flag was undocumented in the template command's
help text. This adds usage documentation and examples showing both
comma-separated and multiple flag usage patterns.
Fixes #13198
Signed-off-by: majiayu000 <1835304752@qq.com>
🤖 Generated with [Claude Code](https://claude.com/claude-code )
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Signed-off-by: majiayu000 <1835304752@qq.com>
2 weeks ago
Matt Farina
fe1c749183
Fixing failing tests for cli-tools update
...
Tests were failing for cli-utils watcher because upstream k8s made
changes that impacted cli-utils. In k8s WatchListClient is now
enabled by default. Fake clients used for testing don't know this
semantic. cli-utils leverages reflection in k8s to handle this.
The Helm tests didn't handle this well.
The tests are updated to use PrependReactor and PrependWatchReactor
in the same way that cli-utils does for testing. This works without
wrapping the client.
Signed-off-by: Matt Farina <matt.farina@suse.com>
2 weeks ago
George Jenkins
118d90e810
Merge pull request #31677 from gjenkins8/gjenkins/new_client_set
...
chore: Replace deprecated `NewSimpleClientset`
2 weeks ago
George Jenkins
a15db7f087
Replace deprecated `NewSimpleClientset`
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
3 weeks ago
Terry Howe
8802d959cb
Merge pull request #31104 from LinPr/fix
...
fix: assign KUBECONFIG environment variable value to env.Kubeconfig
3 weeks ago
George Jenkins
f05c21b6b6
Merge pull request #31296 from gjenkins8/gjenkins/runtime_kube_version
...
build: set kube version via `debug.BuildInfo`
3 weeks ago
George Jenkins
24e8297343
Merge pull request #31610 from mohsenmottaghi/fix-helm-4-watch-strategy
...
fix: use namespace-scoped watching to avoid cluster-wide LIST permiss…
3 weeks ago
Brenden Ehlers
1c119bcaa6
fix: add default casess to switch statements
...
Signed-off-by: Brenden Ehlers <brenden@theehlers.org>
3 weeks ago
Branch Vincent
c6d9a5bdc2
build: set kube version via `debug.BuildInfo`
...
Signed-off-by: Branch Vincent <branchevincent@gmail.com>
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
3 weeks ago
Matt Farina
2108bc5070
Merge pull request #31448 from laervn/feat/add-no-headers-option
...
feat(repo): add --no-headers option to 'helm repo list'
4 weeks ago
Deepak Chethan
55a4aed67f
doc: update based on review suggestion
...
Co-authored-by: Terry Howe <terrylhowe@gmail.com>
Signed-off-by: Deepak Chethan <deepakchethan@outlook.com>
4 weeks ago
Mohsen Mottaghi
d6b35cedeb
test(statuswait): fix Copilot code review suggestion for goroutine in tests
...
Signed-off-by: Mohsen Mottaghi <mohsenmottaghi@outlook.com>
4 weeks ago
Mohsen Mottaghi
a1543d5947
test(statuswait): add more tests suggested by Copilot code review
...
add missing coverage for the positive case where cluster-scoped resources (like ClusterRole or Namespace) should work correctly
Signed-off-by: Mohsen Mottaghi <mohsenmottaghi@outlook.com>
4 weeks ago
Mohsen Mottaghi
dd44f4ecd0
test(statuswait): add some tests for statuswait
...
Adding some tests for multi namespace deployment, simulate restrcited rbac access and mixed namespace scope and cluster scope resources
Signed-off-by: Mohsen Mottaghi <mohsenmottaghi@outlook.com>
4 weeks ago
Mohsen Mottaghi
3dd54ed0b6
fix: use namespace-scoped watching to avoid cluster-wide LIST permissions
...
Signed-off-by: Mohsen Mottaghi <mohsenmottaghi@outlook.com>
4 weeks ago
Deepak
f92ae18977
fix(doc): Update default wait strategy
...
fixes : #31652
Default wait strategy is hookOnly, so updated the docs to reflect the same
Signed-off-by: Deepak Chethan <deepakchethan@outlook.com>
4 weeks ago
Terry Howe
019e7e7145
Merge pull request #31650 from helm/gjenkins/fix_TestConcurrencyDownloadIndex
...
Fix `TestConcurrencyDownloadIndex` typo
4 weeks ago
George Jenkins
592815ea2b
Fix `TestConcurrencyDownloadIndex` typo
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
4 weeks ago
George Jenkins
d2ea7c4276
Merge pull request #31649 from atombrella/feature/errorlint_is_as
...
Use errors.Is to check for io.EOF and gzip.ErrHeader
4 weeks ago
Terry Howe
188ac4e834
Merge pull request #31635 from banjoh/em/fix-ssa-upgrade-install-cmd
...
fix(upgrade): pass --server-side flag to install when using upgrade --install
4 weeks ago
Mads Jensen
a490bb3c20
Use errors.Is to check for io.EOF and gzip.ErrHeader
...
In GoLang, using the == operator to check for a certain error will not
unwrap the error chain, and therefore may hide the problem.
Signed-off-by: Mads Jensen <atombrella@users.noreply.github.com>
1 month ago
Terry Howe
5d2ab10caa
Merge pull request #12564 from hiddeco/supersede-on-uninstall
...
fix(uninstall): supersede deployed releases
1 month ago
Terry Howe
b52b6615f0
Merge pull request #31207 from zyfy29/delete-unused-var
...
chore: delete unused var in installer.go
1 month ago
Terry Howe
2597088a20
Merge pull request #31586 from calvinbui/main
...
fix: use length check for MetaDependencies instead of nil comparison
1 month ago
Robert Sirchia
4cf7d8d025
Merge pull request #31641 from wangjingcun/main
...
chore: fix some comments to improve readability
1 month ago
Terry Howe
d28853e206
Merge pull request #31624 from atombrella/feature/sloglint
...
Enable the `sloglint` linter
1 month ago
Terry Howe
642462e9fe
Merge pull request #11991 from twz123/no-bash-in-testscripts
...
Make test scripts run without /bin/bash
1 month ago
wangjingcun
858cf31583
chore: fix some comments to improve readability
...
Signed-off-by: wangjingcun <wangjingcun@aliyun.com>
1 month ago
Evans Mungai
2dc581dc1c
fix(upgrade): pass --server-side flag to install when using upgrade --install
...
When running `helm upgrade --install` on a non-existent release, the
--server-side flag was not being passed to the install action. This
caused the install to always use server-side apply (the default),
ignoring --server-side=false.
Copy ServerSideApply and ForceConflicts from the upgrade client to the
install client when falling back to install.
Fixes #31627
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
1 month ago
Mads Jensen
a18e59e465
Enable the sloglint linter
...
Signed-off-by: Mads Jensen <atombrella@users.noreply.github.com>
1 month ago
George Jenkins
7edfdb6c5e
Merge pull request #31549 from benoittgt/31548
...
fix: prevent reporting fallback on version when none specified
1 month ago
George Jenkins
3165e5463a
Merge pull request #31528 from benoittgt/31423-git-version
...
fix: preserve vendor suffixes in KubeVersion.GitVersion
1 month ago
Stephanie Hohenberg
a109ac2f06
fixes comment in install.go
...
Signed-off-by: Stephanie Hohenberg <stephanie.hohenberg@gmail.com>
1 month ago
Stephanie Hohenberg
2f598ffc85
fixes tests after merge
...
Signed-off-by: Stephanie Hohenberg <stephanie.hohenberg@gmail.com>
1 month ago
Stephanie Hohenberg
bb9356e182
fixes lint issue
...
Signed-off-by: Stephanie Hohenberg <stephanie.hohenberg@gmail.com>
1 month ago
Stephanie Hohenberg
8cf4ad73c3
updates tests after rebase from master
...
Signed-off-by: Stephanie Hohenberg <stephanie.hohenberg@gmail.com>
1 month ago
Stephanie Hohenberg
31131cff9b
Add tests to action package to improve coverage
...
Signed-off-by: Stephanie Hohenberg <stephanie.hohenberg@gmail.com>
1 month ago
Matt Farina
ff35414bed
Merge pull request #31546 from benoittgt/31544-nil-pointer
...
fix(lint): prevent segmentation violation on only comment yaml in multidoc
1 month ago
George Jenkins
dfa1e3c3c5
Merge pull request #31562 from atombrella/feature/modernize
...
Use modernize to use newer Golang features.
1 month ago
George Jenkins
51076a073a
Merge pull request #31519 from TerryHowe/chore-add-warning-for-registry-login
...
chore: add warning for registry login with namespace
1 month ago
Evans Mungai
f552950b05
Add ownership verification to uninstall action
...
This commit adds ownership verification to the uninstall action. It checks that the resource to be deleted is owned by the chart before deleting it.
Fixes : #31333
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
2 months ago
Calvin Bui
b33d4ae0c0
Use length check for MetaDependencies instead of nil comparison
...
Signed-off-by: Calvin Bui <3604363+calvinbui@users.noreply.github.com>
2 months ago
Evans Mungai
6d5b5aab32
Additional logging for ownership verification in dry-run mode
...
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
2 months ago
Evans Mungai
906f87ce1d
feat: add ownership verification before deleting resources during uninstall
...
Fixes #31333
Helm uninstall now verifies resource ownership before deletion by checking
Helm labels and annotations. Resources not owned by the release being
uninstalled are skipped with warnings, preventing accidental deletion of
resources belonging to other releases.
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
2 months ago
megha1906
e71a29ce4f
chore: fix typo in pkg/downloader/chart_downloader.go
...
Signed-off-by: megha1906 <meghabansal135@gmail.com>
2 months ago
Robert Sirchia
722482b77d
Merge pull request #31561 from atombrella/feature/nilness_cleanup
...
Remove two redundant if-checks.
2 months ago