Marcin Owsiany
a6863a64ce
Drop unused field.
...
Signed-off-by: Marcin Owsiany <porridge@redhat.com>
9 months ago
Bhargav Ravuri
9c0b4c8121
test(create): Test to check deprecated resource templates
...
Test to check deprecation warnings on resource templates that are
created by `helm create` against the latest Kubernetes version. This
test is run in a separate Makefile command to avoid failing other unit
tests configured to run with a specific Kubernetes version(s).
For resources that are disabled by default (like hpa and ingress),
to avoid skipping them from the helm linter test, they are enabled in
the test.
Fixes #11495
Signed-off-by: Bhargav Ravuri <bhargav.ravuri@infracloud.io>
9 months ago
deterclosed
dd37787ffd
chore: remove repetitive words
...
Signed-off-by: deterclosed <fliter@outlook.com>
10 months ago
Andrew Block
0a69a0dea6
Modified how created annotation is populated based on package creation time
...
Signed-off-by: Andrew Block <andy.block@gmail.com>
10 months ago
Matt Farina
976ed8c0be
Merge pull request #12761 from ricardomaraschini/proxy-for-oci-download
...
bug: add proxy support for oci getter
10 months ago
Matt Farina
2dea5bf335
Merge pull request #11790 from Nordix/waitRetry
...
Add robustness to wait status checks
10 months ago
Mario Manno
a7856c0398
Add ability to adopt unmanaged resources
...
Allow the SDK actions to adopt existing resources. This allows install
and update to overwrite resources. If TakeOwnership is not set, adoption
is only possible if they existing resources have the right labels
(managed-by) and annotations (release-name, ...).
Signed-off-by: Mario Manno <mmanno@suse.com>
10 months ago
Matt Farina
25c473834e
Enabling hide secrets on install and upgrade dry run
...
This change adds a new flag to the install and upgrade commands in
the Helm client and properties to the install and upgrade action.
The new flag is --hide-secret and can only be used with the
--dry-run flag.
The --dry-run flag is designed to send all chart rendered manifests to
stdout so that they can be inspected.
When the --hide-secret flag is used the Secret content is removed from
the output.
Signed-off-by: Matt Farina <matt.farina@suse.com>
10 months ago
Aaron U'Ren
29ab5c4b02
feat(load.go): add warning on requirements.lock
...
Signed-off-by: Aaron U'Ren <aauren@users.noreply.github.com>
10 months ago
Robert Sirchia
d58d7b3762
Fixing all the linting errors
...
Cleaned up all the linting errors we are getting.
Signed-off-by: Robert Sirchia <rsirchia@outlook.com>
10 months ago
Matt Farina
764557c470
Some fixes
...
Signed-off-by: Matt Farina <matt.farina@suse.com>
11 months ago
Trent V
ceb44fd307
Merge branch 'helm:main' into main
11 months ago
Matt Farina
c7f318ca4c
Merge pull request #12789 from gjenkins8/fix_chart_index_load_invalid_alias
...
Fix: Ignore alias validation error for index load
11 months ago
Trenton VanderWert
ab640a7177
added sprintf solution and found other possible overflow occurences
...
Signed-off-by: Trenton VanderWert <trenton.vanderwert@gmail.com>
11 months ago
George Jenkins
8d19bcb78a
add error messages
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
11 months ago
George Jenkins
68294fdae0
Fix: Ignore alias validation error for index load
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
11 months ago
Trenton VanderWert
4a45342887
changed Iota to FormatInt to allow int64 value preventing 2038 overflow
...
Signed-off-by: Trenton VanderWert <trenton.vanderwert@gmail.com>
11 months ago
Matt Farina
8e6a5149d2
validation fix
...
Signed-off-by: Matt Farina <matt.farina@suse.com>
11 months ago
Evans Mungai
dc158f6208
fix(helm): pass down username/password CLI parameters to OCI registry clients
...
When username/password parameters are passed in via the CLI
they are not passed down to the client handling requests to
OCI registries. This change ensures this happens
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
11 months ago
Ricardo Maraschini
94c1deae6d
bug: add proxy support for oci getter
...
adds missing proxy support on oci chart getter.
Signed-off-by: Ricardo Maraschini <ricardo.maraschini@gmail.com>
12 months ago
Matt Farina
e81f6140dd
Merge pull request #12428 from matt-carr/main
...
fix(helm): fix grammatical error in default NOTES.txt
12 months ago
Matt Farina
f4c37e7db5
bump version to
...
Signed-off-by: Matt Farina <matt.farina@suse.com>
(cherry picked from commit 69dcc92c56
)
1 year ago
Matt Farina
c042264a9d
Fix issues when verify generation readiness was merged
...
CI, tests, and building failed after #10920 was merged. This change
fixes the issues that were introduced.
Signed-off-by: Matt Farina <matt.farina@suse.com>
1 year ago
Matt Farina
b299359f66
Merge pull request #10920 from muang0/readiness-generation-check
...
Verify generation in readiness checks
1 year ago
Matt Farina
7fd08041b1
Merge pull request #12617 from porridge/dynamic-client
...
feature(pkg/engine): introduce RenderWithClientProvider
1 year ago
Antoine Deschênes
869c1d2560
lint: Add --kube-version flag to set capabilities and deprecation rules
...
Signed-off-by: Antoine Deschênes <antoine@antoinedeschenes.com>
1 year ago
Andrew Block
77d54d7dbe
Merge pull request #11351 from greed42/fast-tpl
...
Speed up `tpl`
1 year ago
Joe Julian
762a1c7adc
Merge pull request #12688 from mattfarina/bump-go-1.21
...
Update to Go 1.21 for builds
1 year ago
Matt Farina
83a76cea6a
Merge pull request #9176 from dastrobu/#9169/lint-dependency-shadowing
...
lint and validate dependency metadata to reference dependencies with …
1 year ago
Matt Farina
847369c184
Update to Go 1.21 for builds
...
Noteis:
1. This moves golangci scanning to a GitHub action. This will
enable inline pointers to issues in the PR where linting fails.
2. Go 1.21 is specified in the go.mod because Kubernetes libs
require it.
3. The lint issues were removed. Some were fixed while others
were handled by skipping linting or using _ as an argument.
Many of these can be refactored later for better cleanup.
Signed-off-by: Matt Farina <matt.farina@suse.com>
1 year ago
Joe Julian
6d96283c0b
Merge pull request #12204 from CARV-ICS-FORTH/riscv64
...
Add support for RISC-V
1 year ago
Joe Julian
e06a1432d5
Merge pull request #12530 from refl3ction/patch-1
...
helm create: move livenessProbe and readinessProbe values to default values file
1 year ago
Joe Julian
c9366c3a5c
Merge pull request #11878 from Exchizz/feature/pass-basic-auth-to-download-plugin
...
feat: pass basic auth to env-vars when running download plugins
1 year ago
Joe Julian
99b8f443d1
Merge pull request #11387 from zak905/fix_post_install_hook_issue
...
fix post install hook deletion due to before-hook-creation policy
1 year ago
Joe Julian
35e94bb99d
Merge pull request #12440 from sergelogvinov/hook-name
...
print failed hook name
1 year ago
Joe Julian
c3742e6331
Merge pull request #12662 from ialidzhikov/enh/make-ignore-pkg-public
...
Make the `ignore` pkg public again
1 year ago
Joe Julian
30c35166e8
Merge pull request #12350 from iamasmith/qps-iamasmith-1
...
QPS parameter proposal
1 year ago
Marcin Owsiany
a997de1f11
tests(pkg/engine): test RenderWithClientProvider
...
Signed-off-by: Marcin Owsiany <porridge@redhat.com>
1 year ago
Ismail Alidzhikov
5586760133
Make the `ignore` pkg public again
...
Signed-off-by: Ismail Alidzhikov <i.alidjikov@gmail.com>
1 year ago
Marcin Owsiany
bfec4ec926
feature(pkg/engine): introduce RenderWithClientProvider
...
Signed-off-by: Marcin Owsiany <porridge@redhat.com>
1 year ago
Fred Heinecke
73f1dcc1d9
Added `toYamlPretty` template function
...
Signed-off-by: Fred Heinecke <fred.heinecke@goteleport.com>
1 year ago
Sean Mills
ce87ece23e
Remove excessive logging
...
Resolves helm unittest issue helm-unittest/helm-unittest#237
Signed-off-by: Sean Mills <sean.m.mills@gmail.com>
1 year ago
Matt Farina
0592b3800a
Merge pull request #12457 from genofire/patch-1
...
chore(create): indent to spaces
1 year ago
Matt Farina
c682fdfebf
Merge pull request #12539 from chojnack/main
...
Fixing release labelling in rollback
1 year ago
Matt Farina
dae8783177
Merge pull request #12447 from dm3ch/allow-filtering-using-system-labels
...
Allow using label selectors for system labels for secrets and configmap
1 year ago
Scott Rigby
2745909d3d
Merge pull request #9653 from Okhoshi/feat/reset-then-reuse-flag
...
feat(helm): Add --reset-then-reuse-values flag to 'helm upgrade'
1 year ago
Marcin Chojnacki
8814bfb490
Fixing release labelling in rollback
...
1. Fixed propagating labels to rollback release
Signed-off-by: Marcin Chojnacki <marcin.chojnacki@nokia.com>
1 year ago
Denis Policastro
9f0313e5f5
feat: move livenessProbe and readinessProbe values to default values file
...
Signed-off-by: Denis Policastro <denis.policastro@gmail.com>
1 year ago
Matt Farina
24e2864c64
Revert "fix(main): fix basic auth for helm pull or push"
...
This reverts commit 4a27baaffc
.
Note, PR #11129 was layered in along with this change so the revert
preserves this API addition.
Signed-off-by: Matt Farina <matt.farina@suse.com>
1 year ago
Matt Farina
992dc58556
Revert "fix(registry): address anonymous pull issue"
...
Signed-off-by: Matt Farina <matt.farina@suse.com>
1 year ago
Dmitry Chepurovskiy
250f0bd46e
Drop filterSystemLabels usage from Query method
...
Signed-off-by: Dmitry Chepurovskiy <me@dm3ch.net>
1 year ago
Dmitry Chepurovskiy
0ec47f8ec9
Apply review suggestions
...
Co-authored-by: French Ben <FrenchBen@users.noreply.github.com>
Signed-off-by: Dmitry Chepurovskiy <me@dm3ch.net>
1 year ago
Serge Logvinov
b0d163771e
feat: print failed hook name
...
Add more details when a hook fails.
Signed-off-by: Serge Logvinov <serge.logvinov@sinextra.dev>
1 year ago
Matt Farina
25371e2f0d
Fixing precedence issue with the import of values.
...
The ordering should be:
1. User specified values (e.g CLI)
2. Parent chart values
3. Imported values
4. Sub-chart values
This enables parnet charts to import large set of values from a
child and then override select values.
This change is needed for backwards compatibility.
Fixes #12460
Signed-off-by: Matt Farina <matt.farina@suse.com>
1 year ago
Matt Farina
1b260d0a79
Merge pull request #12433 from larszi/fix-12432-helm-create-serviceaccount
...
FIX Default ServiceAccount yaml
1 year ago
Matt Farina
ff8f0276ca
Merge pull request #12429 from hiddeco/fix-swallowed-err
...
fix(registry): unswallow error
1 year ago
Miles Wilson
0c541398f2
Added support for hiding notes from install/upgrade output
...
Signed-off-by: Miles Wilson <wilson.mil@icloud.com>
1 year ago
genofire
919bffe2db
chore(create): indent to spaces
...
Signed-off-by: genofire <geno+dev@fireorbit.de>
1 year ago
Dmitry Chepurovskiy
e6d9b99255
Allow using label selectors for system labels for sql backend.
...
Fixes #12435
Signed-off-by: Dmitry Chepurovskiy <me@dm3ch.net>
1 year ago
Dmitry Chepurovskiy
e219c756e0
Allow using label selectors for system labels for secrets and configmap
...
backends.
Fixes #12435
Signed-off-by: Dmitry Chepurovskiy <me@dm3ch.net>
1 year ago
b4nks
f004d42847
remove useless print during prepareUpgrade
...
Signed-off-by: b4nks <b4nks@protonmail.com>
1 year ago
Lars Zimmermann
828763e0d8
FIX Default ServiceAccount yaml
...
As described in issue #12432 (https://github.com/helm/helm/issues/12432 ) the default serviceaccount yaml will be created wrong. This commit will fix this.
Signed-off-by: Lars Zimmermann <info@zimmermann-lars.de>
1 year ago
Hidde Beydals
fe4c01f624
fix(registry): address anonymous pull issue
...
The assumption that either a username and/or password OR an error is
returned appears to be wrong, and results in an error later on which
looks something like the following:
```
failed to authorize: failed to fetch anonymous token: unexpected status
from GET request to https://auth.docker.io/token?scope=repository%3AXXX%2FYYY%3Apull&service=registry.docker.io :
401 Unauthorized
```
To mitigate this, confirm we actually have one of the values before
setting the `Authorization` header.
Co-authored-by: Joe Julian <me@joejulian.name>
Signed-off-by: Hidde Beydals <hidde@hhh.computer>
1 year ago
Hidde Beydals
da3c666a82
fix(registry): unswallow error
...
Signed-off-by: Hidde Beydals <hidde@hhh.computer>
1 year ago
Matt Carr
c25736c894
Fix grammatical error
...
Signed-off-by: Matt Carr <mcarr@kinaxis.com>
1 year ago
Matt Farina
162b3efc33
Merge pull request #12394 from abrarcv170/patch-1
...
Increased release information key name max length.
1 year ago
Andy Smith
415af5b0e9
Add qps/HELM_QPS parameter
...
Signed-off-by: Andy Smith <iamasmith.home@gmail.com>
1 year ago
Matt Farina
c372b15022
bump version to v3.13.0
...
Signed-off-by: Matt Farina <matt.farina@suse.com>
(cherry picked from commit 825e86f6a7
)
1 year ago
Matt Farina
dbef83eac3
Merge pull request #10913 from sureshdsk/pluginbug
...
fix: plugin does not load when helm base dir contains space
1 year ago
Matt Farina
30254deff4
Merge pull request #12088 from mslapek/fix/11971-run-with-ctx
...
Fix leaking goroutines in Install
1 year ago
Michał Słapek
169561a1b3
Fix leaking goroutines in Install
...
Signed-off-by: Michał Słapek <28485371+mslapek@users.noreply.github.com>
1 year ago
Matt Farina
70cbaa0a73
Merge pull request #11372 from vovtz/#11369-fix-custom-repo-cache-for-unmanaged-dependency-updates
...
#11369 Fix custom repo index cache directory for unmanaged dependency updates
1 year ago
abrarcv170
4199be82b5
Increased release information key name max length.
...
Helm release names are limited to 53 characters. By default, Release information is stored in Kubernetes as secrets, and the secret's name structure follows the pattern "sh.helm.release.v1.<release name up to 53 characters>.v<release revision>." However, in the case of using an SQL backend, this release information key is stored in the release_v1 table, and the table constraint currently limits the key name length to 67 characters. This limitation may not be suitable for release names that are within Helm's 53-character limit and need to accommodate the additional "sh.helm.release.v1." prefix and the release revision suffix.
Signed-off-by: abrarcv170 <78675575+abrarcv170@users.noreply.github.com>
1 year ago
Matt Farina
ef02cafdd0
Merge pull request #12274 from mih-kopylov/get-metadata
...
Restore `helm get metadata` command
1 year ago
Matt Farina
5a1475ee36
Merge pull request #11294 from Juneezee/test/t.TempDir
...
test: replace `ensure.TempDir` with `t.TempDir`
1 year ago
Matt Farina
4feafb528b
Merge pull request #12019 from GOodCoffeeLover/feat/rw-psql
...
sql driver with rw-roles
1 year ago
Joe Julian
e7bb860d9a
Merge pull request #12245 from hiddeco/json-index
...
Add support for creating repository indexes in JSON format
1 year ago
Jeff van Dam
183f01b32c
Made urls key more specific
...
Signed-off-by: Jeff van Dam <jeff.van.dam@est.tech>
1 year ago
Joe Julian
edc93cb988
Merge pull request #11649 from tim-chaplin-dd/tim.chaplin/fix-selector-labels-2
...
Use common labels instead of selectorLabels for pod labels
1 year ago
Joe Julian
eb4edc96c5
Merge pull request #10965 from mattfarina/factory-comment
...
Adding details on the Factory interface
1 year ago
Maxim Trofimov
4944acb341
fix conflict
...
Signed-off-by: Maxim Trofimov <qwerty65k@mail.ru>
1 year ago
Maxim Trofimov
6138e101aa
add big tests
...
Signed-off-by: Maxim Trofimov <qwerty65k@mail.ru>
1 year ago
Maxim Trofimov
199784f711
fix conflict
...
Signed-off-by: Maxim Trofimov <qwerty65k@mail.ru>
1 year ago
Maxim Trofimov
b786cb40f0
fix
...
Signed-off-by: Maxim Trofimov <qwerty65k@mail.ru>
1 year ago
Maxim Trofimov
df5904d88a
add check if all migrations already applied
...
Signed-off-by: Maxim Trofimov <qwerty65k@mail.ru>
1 year ago
Joe Julian
1d2221f9d6
Merge pull request #12290 from Ithrael/fix/helm-rollback-err-tips
...
fix(rollback): helm rollback err tips
1 year ago
Joe Julian
126333c525
Merge remote-tracking branch 'upstream/main' into #9169/lint-dependency-shadowing
1 year ago
Tim Chaplin
479be0c36b
Use labels instead of selectorLabels for pod labels
...
Signed-off-by: Tim Chaplin <tim.chaplin@datadoghq.com>
1 year ago
Joe Julian
b6c679eb97
Merge pull request #12321 from LuBingtan/dev
...
fix(helm): fix GetPodLogs, the hooks should be sorted before get the logs of each hook
1 year ago
Joe Julian
4ff7d90872
Merge remote-tracking branch 'upstream/main' into add-labels-to-install-upgrade
1 year ago
Bingtan Lu
4e5e68d55c
fix(helm): fix GetPodLogs, the hooks should be sorted before get the logs of each hook
...
Signed-off-by: lubingtan <lubingtan@126.com>
1 year ago
ithrael
db9460cc87
fix: helm rollback err tips
...
Signed-off-by: ithrael <wh01096045@gmail.com>
1 year ago
Joe Julian
f9e03f196d
Merge pull request #12278 from heijian123/main
...
Fix helm may identify achieve of the application/x-gzip as application/vnd.ms-fontobject
1 year ago
Joe Julian
a749b66310
Merge pull request #12203 from 0xff-dev/main
...
chore: HTTPGetter add default timeout
1 year ago
Joe Julian
d9e0688640
Merge remote-tracking branch 'upstream/main' into fix-10566
1 year ago
Joe Julian
b3c35c0aea
Merge pull request #11129 from antgamdia/10623-allow-setting-oci-resolver-2
...
Allow setting a resolver in the OCI registry client
1 year ago
0xff-dev
2011a3191c
chore: HTTPGetter add default timeout
...
Signed-off-by: 0xff-dev <stevenshuang521@gmail.com>
Co-authored-by: bjwswang <bjwswang@gmail.com>
Co-authored-by: Abirdcfly <fp544037857@gmail.com>
1 year ago
Joe Julian
1a465d603d
Merge pull request #10564 from suzaku/ignore-not-found
...
Closes #3352 , add support for --ignore-not-found just like kubectl delete
1 year ago
Joe Julian
a680f72f7e
Merge pull request #11926 from AdamKorcz/fix1
...
pkg/action: fix nil-dereference
1 year ago
Joe Julian
0be8ac35ab
Merge pull request #11927 from AdamKorcz/fix2
...
pkg/chartutil: fix nil-dereference
1 year ago
Joe Julian
e19c6cf199
Merge pull request #11644 from jcpunk/automountServiceAccountToken
...
Seed a default switch to control `automountServiceAccountToken`
1 year ago
Joe Julian
a0a83637dc
Merge pull request #11780 from genofire/patch-1
...
fix(create): add podLabels to chart create
1 year ago
Joe Julian
0468fde6ce
Merge pull request #11928 from AdamKorcz/fix3
...
pkg/engine: fix nil-dereference
1 year ago
Joe Julian
67096285c2
Merge remote-tracking branch 'upstream/main' into automountServiceAccountToken
1 year ago
Joe Julian
a10626cdf0
Merge remote-tracking branch 'upstream/main' into patch-1
1 year ago
guoguangwu
bf543d94e9
fix: precedence typo
...
Signed-off-by: guoguangwu <guoguangwu@magic-shield.com>
1 year ago
Antonio Gamez Diaz
3607cd7110
Avoid nil dereference if passing a nil resolver
...
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
1 year ago
Jeff van Dam
0a7bffdd3c
Merge branch 'fixDepUpPerformance' of https://github.com/Nordix/helm into fixDepUpPerformance
1 year ago
Jeff van Dam
e5fdaa1c65
Update chart_downloader.go
...
Signed-off-by: Jeff van Dam <66410239+JvD-Ericsson@users.noreply.github.com>
1 year ago
Antonio Gamez Diaz
197d1defbf
Add required changes after merge
...
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
1 year ago
Antonio Gamez Diaz
ad6f45819a
Merge branch 'main'
...
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Conflicts:
pkg/registry/client.go
pkg/registry/utils_test.go
1 year ago
Joe Julian
4b28d7b08d
Merge remote-tracking branch 'upstream/main' into fix1
1 year ago
Joe Julian
bc8bef4c15
Merge remote-tracking branch 'upstream/main' into fix2
1 year ago
Joe Julian
c42fdd1e0b
Merge remote-tracking branch 'upstream/main' into fix3
1 year ago
satoru
5b08985138
goimports
...
Signed-off-by: satoru <satorulogic@gmail.com>
1 year ago
suzaku
48dbda2fa8
Fix #3352 , add support for --ignore-not-found just like kubectl delete
...
Signed-off-by: suzaku <satorulogic@gmail.com>
1 year ago
Joe Julian
b30d7152b7
Merge remote-tracking branch 'upstream/main' into feat/reset-then-reuse-flag
1 year ago
Joe Julian
2b9f4991d6
Merge remote-tracking branch 'upstream/main' into priorityclassorder
1 year ago
MR ZHAO
5c7a63138b
Fix helm may identify achieve of the application/x-gzip as application/vnd.ms-fontobject
...
Signed-off-by: MR ZHAO <62738635+heijian123@users.noreply.github.com>
1 year ago
Mikhail Kopylov
0b5e9d37c8
Restore `helm get metadata` command
...
Signed-off-by: Mikhail Kopylov <mih.kopylov@yandex.ru>
1 year ago
Joe Julian
e8e6da28d1
Revert "Add `helm get metadata` command"
...
Signed-off-by: Joe Julian <me@joejulian.name>
1 year ago
Joe Julian
7de6d7f162
Merge branch 'main' into feat/reset-then-reuse-flag
...
Signed-off-by: Joe Julian <me@joejulian.name>
1 year ago
Joe Julian
b12139a6ec
Merge pull request #11586 from jmhbnz/main
...
Remove warning for template directory not found
1 year ago
Joe Julian
02ef594a43
Merge pull request #11591 from ruanxin/use_wrapped_error
...
Use wrapped error so that ErrNoObjectsVisited can be compared
1 year ago
Joe Julian
847d2bb3c6
Merge pull request #11631 from mih-kopylov/get-metadata
...
Add `helm get metadata` command
1 year ago
Joe Julian
617db7b9d1
Merge pull request #11670 from zhekazuev/feature/volumes-in-chartutil
...
[helm/pkg] add volumes and volumeMounts in chartutil
1 year ago
Joe Julian
819931b226
Merge pull request #12237 from cuisongliu/auth_basic
...
fix(main): fix basic auth for helm pull or push
1 year ago
Scott Rigby
7d190be0d0
Merge pull request #12128 from aryan9600/plain-http
...
oci: Add flag --plain-http to enable working with HTTP registries
1 year ago
Graham Reed
b261a1b1be
Test update for "Allow a nested `tpl` invocation access to `defines` in a containing one"
...
Signed-off-by: Graham Reed <greed@7deadly.org>
1 year ago
Graham Reed
36d417de3b
Test update for "Speed up `tpl`"
...
Signed-off-by: Graham Reed <greed@7deadly.org>
1 year ago
Graham Reed
97dbb96f5a
Merge remote-tracking branch 'origin/main' into fast-tpl
...
Signed-off-by: Graham Reed <greed@7deadly.org>
1 year ago
Dmitry Chepurovskiy
735ff8f92c
Update pkg/action/install.go
...
Signed-off-by: Dmitry Chepurovskiy <me@dm3ch.net>
1 year ago
Eng Zer Jun
2ceebffc77
test: replace `ensure.TempDir` with `t.TempDir`
...
This commit replaces `ensure.TempDir` with `t.TempDir` in tests. The
directory created by `t.TempDir` is automatically removed when the test
and all its subtests complete.
Prior to this commit, temporary directory created using `ensure.TempDir`
needs to be removed manually by calling `os.RemoveAll`, which is omitted
in some tests. The error handling boilerplate e.g.
defer func() {
if err := os.RemoveAll(dir); err != nil {
t.Fatal(err)
}
}
is also tedious, but `t.TempDir` handles this for us nicely.
Reference: https://pkg.go.dev/testing#T.TempDir
Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
1 year ago
Matt Farina
343389856b
Merge pull request #12162 from mattfarina/fix-merge-values-ugh
...
Fix multiple bugs in values handling
1 year ago
Dmitry Chepurovskiy
7b13ac9914
Added error in case try to supply custom label with name of system label during install/upgrade
...
Signed-off-by: Dmitry Chepurovskiy <me@dm3ch.net>
1 year ago
Matt Farina
e8a748d300
Updated per feedback from gjenkins8
...
Signed-off-by: Matt Farina <matt.farina@suse.com>
1 year ago
Joe Julian
ca61c326c2
Merge pull request #11758 from joejulian/remove_blank_list_item_from_files_lines
...
strip trailing newline from Files.Lines
1 year ago
cuisongliu
4a27baaffc
fix(main): fix basic auth for helm pull or push
...
Signed-off-by: cuisongliu <cuisongliu@qq.com>
1 year ago
Hidde Beydals
2544aa23a3
cmd: support generating index in JSON format
...
This adds support for generating the repository index file in JSON
format using the `--json` flag. The index itself is still written
to `index.yaml`, which is fully backwards compatible as YAML is a
superset of JSON.
For big indexes (think multiple megabytes), this approach is however
more efficient in combination with the changes to the load logic,
as it prevents a YAML -> JSON roundtrip during decoding.
Signed-off-by: Hidde Beydals <hidde@hhh.computer>
2 years ago
Hidde Beydals
e21c9cf7e2
repo: detect JSON and unmarshal efficiently
...
When an index is in a JSON format, the `sigs.k8s.io/yaml` package uses
an inefficient approach to unmarshaling the data, as it does an
unnecessary roundtrip on the data to transform the YAML to valid JSON.
To prevent this from happening, detect if the bytes which we attempt
to load contain valid JSON, and unmarshal them directly using
`json.Unmarshal` instead.
Signed-off-by: Hidde Beydals <hidde@hhh.computer>
2 years ago
Matt Farina
96e33e2773
Tweaking new dry-run internal handling
...
There are a few changes to the new dry-run handling:
1. Some documentation is added to help clarify what is happening
and what is expected.
2. DryRun is never changed by internal handling. If an API user
sets the property it is not changed by our code.
3. The behavior on contacting the server with false/none is made
consistent between install and upgrade.
Signed-off-by: Matt Farina <matt.farina@suse.com>
2 years ago
Matt Farina
838b12191e
Merge pull request #9426 from tapaskapadia/feat/lookup-dryrun
...
feat(helm): add ability for --dry-run to do lookup functions
2 years ago
Stefan McShane
1a3e9a95dd
addressing comment
...
Signed-off-by: Stefan McShane <stefanmcshane@users.noreply.github.com>
2 years ago
MichaelMorris
d2cf8c66f1
Updated for review comments
...
Signed-off-by: MichaelMorris <michael.morris@est.tech>
2 years ago
MichaelMorris
fc74964f8a
Add robustness to wait status checks
...
When a user specifies --wait for an install or upgrade this commit will enable the user to specifiy a number of retries to attepmt if a status check fails
Errors including a HTTP status code < 500 will not be retried
Signed-off-by: MichaelMorris <michael.morris@est.tech>
2 years ago
Joe Julian
99e1dce8c8
Merge pull request #9950 from jeffrosenberg/error-on-failed-jobs-9285
...
Throw an error from jobReady() if the job exceeds its BackoffLimit
2 years ago
Joe Julian
8554d518d5
Merge pull request #10397 from mtesseract/mc/fix-err-message-on-existing-resource-conflict
...
Adjust error message wrongly claiming that there is a resource conflict
2 years ago
Antony Chazapis
786707c065
Add support for RISC-V
...
Signed-off-by: Antony Chazapis <chazapis@ics.forth.gr>
2 years ago
Joe Julian
14d363669f
Merge pull request #11529 from wujunwei/fix-update-dependency-panic
...
bugfix: SIGSEGV with OCI chart reference using helm template
2 years ago
Joe Julian
ec1d0d8671
Merge pull request #11456 from greed42/tpl-tests
...
Backfill tests for the `tpl` function
2 years ago