Ismail Alidzhikov
5586760133
Make the `ignore` pkg public again
...
Signed-off-by: Ismail Alidzhikov <i.alidjikov@gmail.com>
2 years ago
Matt Farina
c372b15022
bump version to v3.13.0
...
Signed-off-by: Matt Farina <matt.farina@suse.com>
(cherry picked from commit 825e86f6a7
)
2 years ago
Jeff van Dam
183f01b32c
Made urls key more specific
...
Signed-off-by: Jeff van Dam <jeff.van.dam@est.tech>
2 years ago
Eng Zer Jun
2ceebffc77
test: replace `ensure.TempDir` with `t.TempDir`
...
This commit replaces `ensure.TempDir` with `t.TempDir` in tests. The
directory created by `t.TempDir` is automatically removed when the test
and all its subtests complete.
Prior to this commit, temporary directory created using `ensure.TempDir`
needs to be removed manually by calling `os.RemoveAll`, which is omitted
in some tests. The error handling boilerplate e.g.
defer func() {
if err := os.RemoveAll(dir); err != nil {
t.Fatal(err)
}
}
is also tedious, but `t.TempDir` handles this for us nicely.
Reference: https://pkg.go.dev/testing#T.TempDir
Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
2 years ago
Matt Farina
1800554452
bump version to v3.12.0
...
(cherry picked from commit 54a0fac9b5e243d9922dbfb412bff17eb161e361)
Signed-off-by: Matt Farina <matt.farina@suse.com>
2 years ago
JvD_Ericsson
1ce7939838
Improve helm dependency update performance
...
What this PR does / why we need it:
This PR was created to improve performance of the dependency update command by
skipping unnecessary downloading and loading of index files that have already
been downloaded and loaded
I believe this would close refs #9865
Signed-off-by: Jeff van Dam <jeff.van.dam@est.tech>
2 years ago
Matt Farina
8c4c635e9e
Merge pull request #11832 from my-git9/chore-httpstatus
...
chore:Use http constants as http.request parameters
2 years ago
Matt Farina
4e7e939f19
Updating the Go version in go.mod
...
At this time both Go 1.19 and 1.20 are supported. The version
specified in the go.mod file is the minimum version we expect Helm
to be compiled against. This is the oldest supported version to
support environments where others compile Helm. The Helm project
is using Go 1.20 to build Helm itself.
Updating to Go 1.19 also includes dealing with io/ioutil
deprecation and some additional linting issues around staticcheck.
All the staticcheck issues were in test files so linting was
skipped for those.
Signed-off-by: Matt Farina <matt.farina@suse.com>
3 years ago
Matt Farina
50c22ed7f9
Bump the Go version
...
Needed to gofmt source to meet changes in style
Signed-off-by: Matt Farina <matt.farina@suse.com>
3 years ago
Andrew Block
08593c8dd6
Added support for insecure OCI registries
...
Signed-off-by: Andrew Block <andy.block@gmail.com>
3 years ago
xin.li
8a310c5a98
chore:Use http constants as http.request parameters
...
Signed-off-by: xin.li <xin.li@daocloud.io>
3 years ago
Matt Farina
6facbada26
bump version to v3.11.0
...
Signed-off-by: Matt Farina <matt.farina@suse.com>
(cherry picked from commit 9d8fee155b
)
3 years ago
Matt Farina
cd809f9b19
bump version to v3.10.0
...
Signed-off-by: Matt Farina <matt.farina@suse.com>
(cherry picked from commit ce66412a72
)
3 years ago
yxxhero
39b0a82365
bump Go 1.18
...
Signed-off-by: yxxhero <aiopsclub@163.com>
3 years ago
Matt Farina
1db28a2311
bump version to v3.9.0
...
Signed-off-by: Matt Farina <matt.farina@suse.com>
(cherry picked from commit 7ceeda6c58
)
3 years ago
Matt Farina
2e6b5e1374
Updating symlink log message
...
The symlink message did not tell anyone what Helm does with the contents
of the linked file. These are used in 2 places:
1. When loading a chart as a directory
2. When creating a chart archive (the linked files contents are
included)
Signed-off-by: Matt Farina <matt.farina@suse.com>
3 years ago
Martin Hickey
c477d697ec
Merge pull request #10458 from SimonAlling/remove-AssertGoldenBytes
...
Remove AssertGoldenBytes test helper
3 years ago
Matthew Fisher
2878cc8079
replace +build with go:build
...
go:build is the new conditional compilation directive used to specify build constraints. It was introduced in Go 1.17. It is meant to replace the old +build directives.
Now that go.mod points to Go 1.17 we no longer need to support both
build flags.
Signed-off-by: Matthew Fisher <matt.fisher@fermyon.com>
4 years ago
Josh Dolitsky
65d8e72504
Merge pull request #10628 from sabre1041/oci-dependencies-tag
...
Avoid querying for OCI tags can explicit version provided in chart dependencies
4 years ago
Eng Zer Jun
2e3e22a003
test: use `T.TempDir` to create temporary test directory
...
The directory created by `T.TempDir` is automatically removed when the
test and all its subtests complete.
Reference: https://pkg.go.dev/testing#T.TempDir
Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
4 years ago
Andrew Block
01ff5bb00d
Avoid querying for OCI tags can explicit version provided in chart dependencies
...
Signed-off-by: Andrew Block <andy.block@gmail.com>
4 years ago
Matt Farina
0c8320b685
bump version to v3.8.0
...
Signed-off-by: Matt Farina <matt.farina@suse.com>
(cherry picked from commit d493f29c32
)
4 years ago
David Peraza
7cab1a09e3
Move all the remainder module out of experimental.
...
All the experimental modules were moved to pkg/action
Signed-off-by: David Peraza <dperaza@redhat.com>
4 years ago
David Peraza
9f869c6b21
Removing all the checks for oci experimental flag
...
Signed-off-by: David Peraza <dperaza@redhat.com>
4 years ago
Thomas Runyon
353d74e967
refactor internal/experimental/registry to pkg/registry
...
Signed-off-by: Thomas Runyon <runyontr@gmail.com>
4 years ago
Scott Rigby
808a2d1908
Change underscore (_) back to plus (+) for Helm
...
Signed-off-by: Scott Rigby <scott@r6by.com>
4 years ago
Scott Rigby
bd754a054c
Bring exact version check logic from IndexFile.Get into registry tag check
...
Signed-off-by: Scott Rigby <scott@r6by.com>
4 years ago
Andrew Block
9c3b000889
Fixed bad commit
...
Signed-off-by: Andrew Block <andy.block@gmail.com>
4 years ago
Andrew Block
828941b273
Readded resolver OCI logic
...
Signed-off-by: Andrew Block <andy.block@gmail.com>
4 years ago
Andrew Block
291c17fcc5
Enabled auth and support http registries for OCI
...
Signed-off-by: Andrew Block <andy.block@gmail.com>
4 years ago
Scott Rigby
4c8a3faaa2
Fix import
...
Signed-off-by: Scott Rigby <scott@r6by.com>
4 years ago
Scott Rigby
b6bf3905f3
Implement reusable GetTagMatchingVersionOrConstraint
...
Largely borrowed from (IndexFile).Get. However there is not currently a nice
way to make this code also usable to the repo package, as IndexFile depends on
a list of index Entries containing a nexted version.
We could refactor this later to somehow use the same shared function, but for
now keeping separate.
Signed-off-by: Scott Rigby <scott@r6by.com>
4 years ago
Andrew Block
4f62d3dc1b
Started work on 'helm pull'
...
Signed-off-by: Andrew Block <andy.block@gmail.com>
4 years ago
Andrew Block
df98e18eb7
Working oci code without providing versions
...
Signed-off-by: Andrew Block <andy.block@gmail.com>
4 years ago
Andrew Block
0fae7f5008
Updated tag resolver logic
...
Signed-off-by: Andrew Block <andy.block@gmail.com>
4 years ago
Andrew Block
834a11db56
Added registryClient to resolver
...
Signed-off-by: Andrew Block <andy.block@gmail.com>
4 years ago
Scott Rigby
e3f2fb4235
Add OCI tag verions to the Dependency object before Resolve. TODO: fix HTTP HTTPS error for local registries
...
Signed-off-by: Scott Rigby <scott@r6by.com>
4 years ago
Andrew Block
9a7c362dd1
Initial tag listing support
...
Signed-off-by: Andrew Block <andy.block@gmail.com>
4 years ago
Scott Rigby
3dc9930488
Revert "hack in progress"
...
This reverts commit c0be414e4b8d2928018504c010cb04b1b2450bf3.
Taking a different approach, but keep this work in git history for now until we
know the new approach works.
Signed-off-by: Scott Rigby <scott@r6by.com>
4 years ago
Scott Rigby
0d2f0116ea
hack in progress
...
Signed-off-by: Scott Rigby <scott@r6by.com>
4 years ago
Allen Bai
e3897ad6b1
registry/client: use NewClientWithDockerFallback from oras v1.1.0-rc3
...
Uses NewClientWithDockerFallback to always use Docker config and
modifies go.mod to use oras v1.1.0-rc3.
Ref:
- https://github.com/helm/helm/pull/10536#issuecomment-1010144075
- https://github.com/oras-project/oras-go/pull/92
Signed-off-by: Allen Bai <abai@redhat.com>
4 years ago
Allen Bai
e08a9270be
HELM_REGISTRY_CONFIG: change default file of registry config to config.json
...
Changes default registry config file from `registry.json` to
`config.json`. This aligns with the `config.json` that is widely used in docker.
Closes: https://github.com/helm/helm/issues/10156
Related: https://github.com/helm/helm/issues/10122
Signed-off-by: Allen Bai <abai@redhat.com>
4 years ago
Josh Wolf
fed0d31bf5
ensure consistency in registry client Push/Pull function signatures. ensure message is only printed when tags contain a replaced character
...
Signed-off-by: Josh Wolf <josh@wolfs.io>
4 years ago
Scott Rigby
157ac85ab7
Fix typo. Thanks buildbot. Also comments at 80 chars
...
Signed-off-by: Scott Rigby <scott@r6by.com>
4 years ago
Josh Wolf
fb0eeebf66
add oci reference validation and tag scoped (+) replacement to registry client Push/Pull
...
Signed-off-by: Josh Wolf <josh@wolfs.io>
4 years ago
Scott Rigby
8424bc2b60
Update registry underscore message with semver note for extra clarity
...
Add newline to registry underscore message
Signed-off-by: Scott Rigby <scott@r6by.com>
4 years ago
Scott Rigby
4aacbc44e0
Move plus/underscore change to inside Client. Compare original ref for strict mode
...
Signed-off-by: Scott Rigby <scott@r6by.com>
4 years ago
Scott Rigby
472eb6f096
For OCI, convert + to _ before pull, and + to _ before push
...
Signed-off-by: Scott Rigby <scott@r6by.com>
4 years ago
Simon Alling
dd5db7bc40
Remove AssertGoldenBytes test helper
...
The test suite is thereby simplified somewhat.
Signed-off-by: Simon Alling <alling.simon@gmail.com>
4 years ago
Josh Wolf
fae5009382
ensure error is correctly handled when generating chart's oci manifest
...
Signed-off-by: Josh Wolf <josh@joshwolf.dev>
4 years ago
Josh Wolf
d2d8e52401
modify oci chart push/pull manifest test values to represent new order sorted by oras
...
Signed-off-by: Josh Wolf <josh@joshwolf.dev>
4 years ago
Josh Wolf
7cec93d9fb
upgrade oras to 0.5.0, refactor client oci logic to use new oras.Copy()
...
Signed-off-by: Josh Wolf <josh@joshwolf.dev>
4 years ago
Matt Farina
81f0df0ea6
Merge pull request #10182 from spectrocloud/oci-allow-any-media-type
...
changes to support any mediatype for layers on download
4 years ago
Kai Takac
52cbc2f49c
Fix default registry config path of oci protocol provider
...
Signed-off-by: Kai Takac <kai.takac@gmail.com>
4 years ago
LochanRn
9e29f1619b
changes to support any mediatype for layers on download
...
Signed-off-by: LochanRn <rajanaga_ra@srmuniv.edu.in>
4 years ago
Matt Farina
e6a92c4b62
bump version to 3.7
...
Signed-off-by: Matt Farina <matt.farina@suse.com>
(cherry picked from commit 7048ef6b30aa23abdcfcaf523cb4c42dff85add9)
4 years ago
Josh Dolitsky
caa97158d0
Revert moving registry actions back to pkg/
...
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
4 years ago
Josh Dolitsky
77750962d5
Move registry actions back to pkg/
...
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
4 years ago
Josh Dolitsky
0121f6a328
Merge branch 'main' of github.com:helm/helm into hip-6
...
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
4 years ago
John Howard
82a2abf512
Update oras-go to v0.4.0
...
Signed-off-by: John Howard <howardjohn@google.com>
4 years ago
Matthew Fisher
92bd9558e5
Merge pull request #9998 from bacongobbler/distribution-v3
...
Switch to distribution v3
4 years ago
Josh Dolitsky
82cdb0b793
modify registry test to only listen on loopback
...
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
4 years ago
Josh Dolitsky
f0a528ec05
Merge branch 'main' of github.com:helm/helm into hip-6
...
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
4 years ago
Matthew Fisher
4801818f7c
Switch to distribution v3
...
Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>
4 years ago
Víctor Cuadrado Juan
84a07a4774
test: Make internal/resolver/resolver_test.go pass on Win
...
TestGetLocalPath() needs Windows-specific expected strings.
Signed-off-by: Víctor Cuadrado Juan <vcuadradojuan@suse.de>
4 years ago
Nicolas De Loof
663c569887
Migrate to oras-go library
...
see https://github.com/deislabs/oras/pull/265
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
4 years ago
Josh Dolitsky
241f23d72a
Better NewOCIPusher test, add ORAS link
...
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
4 years ago
Josh Dolitsky
d296ddf026
Merge branch 'main' of github.com:helm/helm into hip-6
...
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
4 years ago
Kally Fox
f9b1445b63
refactor: use os instead of ioutil's ReadDir
...
Signed-off-by: Kally Fox <kallydev@gmail.com>
4 years ago
Josh Dolitsky
8202ccd699
Remove LoginResult/LogoutResult types
...
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
4 years ago
Josh Dolitsky
593eac8876
Merge branch 'main' of github.com:helm/helm into hip-6
...
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
4 years ago
Matt Farina
8855488272
Merge pull request #9736 from cndoit18/fix-issue-9348
...
fix(dep update): helm dep update is not respecting the "version" stip…
4 years ago
Josh Dolitsky
4884ca0059
revert change related to reading prov file
...
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
4 years ago
Josh Dolitsky
ec84339d44
return errors directly, less lines of code
...
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
4 years ago
Josh Dolitsky
230e37ca52
remove hardcoded oci strings, add constant/util
...
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
4 years ago
Josh Dolitsky
bfa5036a1a
consolidate registry source files
...
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
4 years ago
Josh Dolitsky
4d948b4a06
return err directly from pusher.Push
...
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
4 years ago
Josh Dolitsky
faf7fc5efd
use version.GetUserAgent
...
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
4 years ago
Josh Dolitsky
e856df8a54
provide hint if attempting to push directory
...
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
4 years ago
Josh Dolitsky
04d2da3637
return friendly error if missing scheme
...
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
4 years ago
Josh Dolitsky
35fdc688cd
remove the --with-prov option
...
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
4 years ago
Josh Dolitsky
eba63beab1
move experimental actions to new internal package
...
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
4 years ago
Josh Dolitsky
8f60ee76a5
resolve golint errors
...
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
4 years ago
Josh Dolitsky
24a216d3b2
move pkg/uploader, pkg/pusher to internal
...
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
4 years ago
Josh Dolitsky
4073e4d118
inline data fetching for pull result
...
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
4 years ago
Josh Dolitsky
dd7bc40bc4
one-line JSON unmarshall
...
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
4 years ago
Josh Dolitsky
817ac8ff9f
do not wrap single imports/vars
...
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
4 years ago
Josh Dolitsky
f7247c40ee
Upgrade to oras-go v0.4.0
...
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
4 years ago
Josh Dolitsky
00985cad6b
Implement changes proposed in HIP 6
...
For more information, please see the following URL:
https://github.com/helm/community/blob/main/hips/hip-0006.md
Note: OCI support remains experimental, and you are still
required to set HELM_EXPERIMENTAL_OCI=1 in your environment.
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
4 years ago
Martin Hickey
599c071ac7
Merge pull request #9681 from cndoit18/add-max-col-width-parameters
...
support max-col-width parameters
4 years ago
cndoit18
402c7f1a52
fix(dep update): helm dep update is not respecting the "version" stipulated in the requirements
...
Signed-off-by: cndoit18 <cndoit18@outlook.com>
4 years ago
Matt Farina
3415b6e7b8
bump version to v3.6.0
...
Signed-off-by: Matt Farina <matt@mattfarina.com>
(cherry picked from commit af0feeddd91c729aa97327f33c9e3e3109b13561)
4 years ago
cndoit18
a79cad5539
support max-col-width parameters
...
support commands:
- helm chart list
- helm dependency list
Signed-off-by: cndoit18 <cndoit18@outlook.com>
4 years ago
Josh Soref
2bf8fdf45d
chore: Spelling ( #9410 )
...
* spelling: annotate
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: asserts
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: behavior
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: binary
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: contain
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: copied
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: dependency
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: depending
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: deprecated
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: doesn't
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: donot
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: github
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: inputting
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: iteration
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: jabberwocky
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: kubernetes
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: length
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: mismatch
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: multiple
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: nonexistent
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: outputs
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: panicking
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: plugins
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: parsing
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: porthos
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: regular
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: resource
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: repositories
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: something
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: strict
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: string
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: unknown
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
5 years ago
Christian
4f1ab5a331
fix windows tests
...
Signed-off-by: Christian Richter <christian@boltares.de>
5 years ago
Adam Reese
657ce552cb
fix(*): Validate metadata semver and printable characters
...
ref: https://github.com/helm/helm/security/advisories/GHSA-c38g-469g-cmgx
* Skip invalid chart versions when reading the repository index file or
when programmatically adding a chart version.
* Adds semver validation and strips non-printable characters and
normalizes spaces for string fields in Metadata.Validate()
* Fixes a unit test that was pulling a remote repo. Now uses a local
repo.
* Fixes ignored error in repo update command
Signed-off-by: Adam Reese <adam@reese.io>
5 years ago
Matt Farina
8082f6db45
bump version to
...
Signed-off-by: Matt Farina <matt@mattfarina.com>
(cherry picked from commit f546ebb1ac
)
5 years ago
Matt Farina
49f895db6b
Merge pull request #8843 from bloodorangeio/oci-pull
...
Signed-off-by: Matt Farina <matt@mattfarina.com>
5 years ago
Scott Rigby
c495e88250
Replace Helm Hub with Artifact Hub ( #8626 )
...
* Replace Helm Hub with Artifact Hub
Signed-off-by: Scott Rigby <scott@r6by.com>
* Update link to new doc entry for Monocular compatible search API
Signed-off-by: Scott Rigby <scott@r6by.com>
* Add struct for Artifact Hub data, and return correct URL for both artifact hub instances and backwards compatibility for Monocular search API
Signed-off-by: Scott Rigby <scott@r6by.com>
* Keep default endpoint hub.helm.sh, so the helm org controls the domain. At least until artifacthub moves to CNCF incubation
Signed-off-by: Scott Rigby <scott@r6by.com>
5 years ago
Peter Engelbert
3028c55858
Clean up imports and add doc comments
...
Additionally, revert `NewPull()` to its existing signature.
Signed-off-by: Peter Engelbert <pmengelbert@gmail.com>
5 years ago