msb-public/helm - helm - 马士兵教育代码仓库

Commit Graph

Author	SHA1	Message	Date
Mahesh Sadupalli	c02a9aed34	fix(engine): prevent Files.Lines panic on empty file Files.Lines guards against a nil entry but an empty file inside a chart is stored as a non-nil zero-length byte slice, so the trailing newline check indexes s[-1] and panics. The engine recovers the panic into a render error, making every template/install/upgrade/lint that references the file fail. Extend the guard to len(f[path]) == 0 and return an empty slice, matching the behaviour for missing files. Fixes #32279 Signed-off-by: Mahesh Sadupalli <mahesh.sadupalli@gmail.com>	2 months ago
Joe Julian	b3707e666b	strip trailing newline from Files.Lines Signed-off-by: Joe Julian <me@joejulian.name>	3 years ago
Adam Reese	849f27d11f	ref(pkg/engine): make template specific functions private Make template specific functions private to ensure they not misused and make unit tests simpler. We may export the template helpers later if needed. This lays the foundation for the new chart pipeline. Signed-off-by: Adam Reese <adam@reese.io>	8 years ago

Author

SHA1

Message

Date

Mahesh Sadupalli

c02a9aed34

fix(engine): prevent Files.Lines panic on empty file

Files.Lines guards against a nil entry but an empty file inside a
chart is stored as a non-nil zero-length byte slice, so the trailing
newline check indexes s[-1] and panics. The engine recovers the panic
into a render error, making every template/install/upgrade/lint that
references the file fail.

Extend the guard to len(f[path]) == 0 and return an empty slice,
matching the behaviour for missing files.

Fixes #32279

Signed-off-by: Mahesh Sadupalli <mahesh.sadupalli@gmail.com>

Joe Julian

b3707e666b

strip trailing newline from Files.Lines

Signed-off-by: Joe Julian <me@joejulian.name>

Adam Reese

849f27d11f

ref(pkg/engine): make template specific functions private

Make template specific functions private to ensure they not misused and
make unit tests simpler.  We may export the template helpers later if
needed.

This lays the foundation for the new chart pipeline.

Signed-off-by: Adam Reese <adam@reese.io>

3 Commits (release-3.22)