Matt Farina
4389fa639a
Updating link handling
...
Signed-off-by: Matt Farina <matt.farina@suse.com>
(cherry picked from commit 76fdba4c8c
)
3 months ago
Matt Farina
493ed30ff4
Merge pull request #13561 from helm/dependabot/go_modules/dev-v3/github.com/Masterminds/semver/v3-3.3.1
...
Bump github.com/Masterminds/semver/v3 from 3.3.0 to 3.3.1
3 months ago
dependabot[bot]
372e40376a
Bump github.com/Masterminds/semver/v3 from 3.3.0 to 3.3.1
...
Bumps [github.com/Masterminds/semver/v3](https://github.com/Masterminds/semver ) from 3.3.0 to 3.3.1.
- [Release notes](https://github.com/Masterminds/semver/releases )
- [Changelog](https://github.com/Masterminds/semver/blob/master/CHANGELOG.md )
- [Commits](https://github.com/Masterminds/semver/compare/v3.3.0...v3.3.1 )
---
updated-dependencies:
- dependency-name: github.com/Masterminds/semver/v3
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
3 months ago
Matt Farina
acdfcf5057
Merge pull request #30990 from helm/dependabot/go_modules/dev-v3/k8s-io-82a99e9b2d
...
build(deps): bump the k8s-io group with 7 updates
3 months ago
dependabot[bot]
4fa5a64127
build(deps): bump the k8s-io group with 7 updates
...
Bumps the k8s-io group with 7 updates:
| Package | From | To |
| --- | --- | --- |
| [k8s.io/api](https://github.com/kubernetes/api ) | `0.33.1` | `0.33.2` |
| [k8s.io/apiextensions-apiserver](https://github.com/kubernetes/apiextensions-apiserver ) | `0.33.1` | `0.33.2` |
| [k8s.io/apimachinery](https://github.com/kubernetes/apimachinery ) | `0.33.1` | `0.33.2` |
| [k8s.io/apiserver](https://github.com/kubernetes/apiserver ) | `0.33.1` | `0.33.2` |
| [k8s.io/cli-runtime](https://github.com/kubernetes/cli-runtime ) | `0.33.1` | `0.33.2` |
| [k8s.io/client-go](https://github.com/kubernetes/client-go ) | `0.33.1` | `0.33.2` |
| [k8s.io/kubectl](https://github.com/kubernetes/kubectl ) | `0.33.1` | `0.33.2` |
Updates `k8s.io/api` from 0.33.1 to 0.33.2
- [Commits](https://github.com/kubernetes/api/compare/v0.33.1...v0.33.2 )
Updates `k8s.io/apiextensions-apiserver` from 0.33.1 to 0.33.2
- [Release notes](https://github.com/kubernetes/apiextensions-apiserver/releases )
- [Commits](https://github.com/kubernetes/apiextensions-apiserver/compare/v0.33.1...v0.33.2 )
Updates `k8s.io/apimachinery` from 0.33.1 to 0.33.2
- [Commits](https://github.com/kubernetes/apimachinery/compare/v0.33.1...v0.33.2 )
Updates `k8s.io/apiserver` from 0.33.1 to 0.33.2
- [Commits](https://github.com/kubernetes/apiserver/compare/v0.33.1...v0.33.2 )
Updates `k8s.io/cli-runtime` from 0.33.1 to 0.33.2
- [Commits](https://github.com/kubernetes/cli-runtime/compare/v0.33.1...v0.33.2 )
Updates `k8s.io/client-go` from 0.33.1 to 0.33.2
- [Changelog](https://github.com/kubernetes/client-go/blob/master/CHANGELOG.md )
- [Commits](https://github.com/kubernetes/client-go/compare/v0.33.1...v0.33.2 )
Updates `k8s.io/kubectl` from 0.33.1 to 0.33.2
- [Commits](https://github.com/kubernetes/kubectl/compare/v0.33.1...v0.33.2 )
---
updated-dependencies:
- dependency-name: k8s.io/api
dependency-version: 0.33.2
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: k8s-io
- dependency-name: k8s.io/apiextensions-apiserver
dependency-version: 0.33.2
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: k8s-io
- dependency-name: k8s.io/apimachinery
dependency-version: 0.33.2
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: k8s-io
- dependency-name: k8s.io/apiserver
dependency-version: 0.33.2
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: k8s-io
- dependency-name: k8s.io/cli-runtime
dependency-version: 0.33.2
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: k8s-io
- dependency-name: k8s.io/client-go
dependency-version: 0.33.2
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: k8s-io
- dependency-name: k8s.io/kubectl
dependency-version: 0.33.2
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: k8s-io
...
Signed-off-by: dependabot[bot] <support@github.com>
3 months ago
Robert Sirchia
73bd2ed08d
Merge pull request #31005 from helm/dependabot/go_modules/dev-v3/sigs.k8s.io/yaml-1.5.0
...
build(deps): bump sigs.k8s.io/yaml from 1.4.0 to 1.5.0
3 months ago
dependabot[bot]
6284ed8538
build(deps): bump sigs.k8s.io/yaml from 1.4.0 to 1.5.0
...
Bumps [sigs.k8s.io/yaml](https://github.com/kubernetes-sigs/yaml ) from 1.4.0 to 1.5.0.
- [Release notes](https://github.com/kubernetes-sigs/yaml/releases )
- [Changelog](https://github.com/kubernetes-sigs/yaml/blob/master/RELEASE.md )
- [Commits](https://github.com/kubernetes-sigs/yaml/compare/v1.4.0...v1.5.0 )
---
updated-dependencies:
- dependency-name: sigs.k8s.io/yaml
dependency-version: 1.5.0
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
3 months ago
Robert Sirchia
d823a497a2
Merge pull request #30963 from TerryHowe/oras-v2-login
...
Fix Oras v2 login
3 months ago
Terry Howe
2c55a4e8ce
fix: user username password for login
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
4 months ago
Matt Farina
8d32aff55c
Merge pull request #30945 from TerryHowe/backport-oci-transport-debugging
...
fix: backport add debug logging to oci transport
4 months ago
Terry Howe
a16e986d4e
Update pkg/registry/transport.go
...
Co-authored-by: Scott Rigby <scott@r6by.com>
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
4 months ago
Terry Howe
cea26d8bca
Update pkg/registry/transport.go
...
Co-authored-by: Scott Rigby <scott@r6by.com>
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
4 months ago
Terry Howe
b52bb41484
fix: add debug logging to oci transport
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
Co-authored-by: Billy Zha <jinzha1@microsoft.com>
4 months ago
Robert Sirchia
bfd73fba43
Merge pull request #30960 from helm/dependabot/go_modules/dev-v3/golang.org/x/crypto-0.39.0
...
build(deps): bump golang.org/x/crypto from 0.38.0 to 0.39.0
4 months ago
dependabot[bot]
45075cf943
build(deps): bump golang.org/x/crypto from 0.38.0 to 0.39.0
...
Bumps [golang.org/x/crypto](https://github.com/golang/crypto ) from 0.38.0 to 0.39.0.
- [Commits](https://github.com/golang/crypto/compare/v0.38.0...v0.39.0 )
---
updated-dependencies:
- dependency-name: golang.org/x/crypto
dependency-version: 0.39.0
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
4 months ago
Robert Sirchia
7f7add9f46
Merge pull request #30959 from helm/dependabot/go_modules/dev-v3/golang.org/x/text-0.26.0
...
build(deps): bump golang.org/x/text from 0.25.0 to 0.26.0
4 months ago
dependabot[bot]
73a7826395
build(deps): bump golang.org/x/text from 0.25.0 to 0.26.0
...
Bumps [golang.org/x/text](https://github.com/golang/text ) from 0.25.0 to 0.26.0.
- [Release notes](https://github.com/golang/text/releases )
- [Commits](https://github.com/golang/text/compare/v0.25.0...v0.26.0 )
---
updated-dependencies:
- dependency-name: golang.org/x/text
dependency-version: 0.26.0
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
4 months ago
Matt Farina
a963208f8d
Merge pull request #30941 from TerryHowe/legacy-docker
...
fix: legacy docker support broken for login
4 months ago
Terry Howe
733f94c86a
fix: legacy docker support broken for login
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
4 months ago
Robert Sirchia
9d56978f65
Merge pull request #30938 from TerryHowe/backport-fix-plugin-install-no-internet
...
fix: backport plugin installer test with no Internet
4 months ago
Terry Howe
fc36041702
fix: plugin installer test with no Internet
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
4 months ago
Scott Rigby
62759a819e
Merge pull request #30916 from jessesimpson36/v3-remove-registry-login-url-with-tests
...
test: add functional tests for "Fix 3.18.0 regression: registry login with scheme"
4 months ago
Scott Rigby
43f17c55ae
Merge pull request #30932 from mattfarina/fix-empty-registry-config-file
...
Handle an empty registry config file.
4 months ago
Matt Farina
cfe8cef46f
Handle an empty registry config file.
...
In the move to oras v2, an existing but empty registry config file
became an uncaught error. A missing file caused no error. This
change catches the error and works around it so that Helm can
continue to be fault tolerant to this issue.
Signed-off-by: Matt Farina <matt.farina@suse.com>
4 months ago
George Jenkins
f17db66a34
Merge pull request #30906 from TerryHowe/backport-tag-fix
...
[v3 backport] Prevent push cmd failure in 3.18 by handling version tag resolution in ORAS memory store
4 months ago
Benoit Tigeot
c33215d765
Prevent fetching newReference again as we have in calling method
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
4 months ago
Benoit Tigeot
f552b67230
Prevent failure when resolving version tags in oras memory store
...
- The newReference() function transforms version tags by replacing + with _ for OCI compatibility
- But the code was using the original ref (with +) for TagBytes()
- Then it tries to find the tagged reference using parsedRef.String() (with _)
- This mismatch causes the Resolve method to fail with "not found"
- By using parsedRef.String() consistently in both places, the references will match and the lookup will succeed.
I extracted the TagBytes function to improve testability.
Push() includes several external calls that are hard to mock,
so isolating this logic makes testing more manageable.
Close : #30881
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
4 months ago
Matt Farina
806d59750a
Merge pull request #30902 from brandtkeller/30890_prov_mediatype_allow
...
fix(client): allow layer selection permissive
4 months ago
Scott Rigby
e37962522c
Merge pull request #30887 from scottrigby/v3-remove-registry-login-url
...
Fix 3.18.0 regression: registry login with scheme
4 months ago
Brandt Keller
a18a52e898
fix(client): skipnode utilization for PreCopy
...
Co-authored-by: George Jenkins <gvjenkins@gmail.com>
Signed-off-by: Brandt Keller <43887158+brandtkeller@users.noreply.github.com>
4 months ago
Jesse Simpson
fedf5024d6
test: Skip instead of returning early. looks more intentional
...
Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>
4 months ago
Jesse Simpson
fe512bae43
test: tests repo stripping functionality
...
Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>
4 months ago
Jesse Simpson
099a9e18f3
test: include tests for Login based on different protocol prefixes
...
Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>
4 months ago
Brandt Keller
b07ab77da3
fix(client): layers now returns manifest - remove duplicate from descriptors
...
Signed-off-by: Brandt Keller <brandt.keller@defenseunicorns.com>
4 months ago
Brandt Keller
c225c124ac
fix(client): return nil on non-allowed media types
...
Signed-off-by: Brandt Keller <brandt.keller@defenseunicorns.com>
4 months ago
Scott Rigby
c0f3ace52d
Fix 3.18.0 regression: registry login with scheme
...
Helm 3.18.0 released an upgrade of ORAS from v1 to v2.
ORAS v2 correctly does not accept http/https scheme for registry login, while
ORAS v1 previously did. Even if v1 should not have, we want to preserve
backwards compatibility for Helm 3 users who pass the scheme.
This will be removed in Helm 4, where registry login will not accept http/https
scheme.
Co-authored-by: Andrew Block <andy.block@gmail.com>
Co-authored-by: Terry Howe <terrylhowe@gmail.com>
Signed-off-by: Scott Rigby <scott@r6by.com>
4 months ago
Robert Sirchia
f147277a59
Merge pull request #30885 from helm/revert-13534-dev-v3-12987
...
Revert "fix (helm) : toToml` renders int as float [ backport to v3 ]"
4 months ago
George Jenkins
d5391ea603
Merge pull request #30886 from benoittgt/fix-30876
...
Log warning when platformCommand|Hook and Command|Hook are set
4 months ago
Benoit Tigeot
dce60adb51
Update pkg/plugin/plugin.go
...
Co-authored-by: George Jenkins <gvjenkins@gmail.com>
Signed-off-by: Benoit Tigeot <benoittgt@users.noreply.github.com>
4 months ago
Benoit Tigeot
cda0865d64
Update pkg/plugin/plugin.go
...
Co-authored-by: George Jenkins <gvjenkins@gmail.com>
Signed-off-by: Benoit Tigeot <benoittgt@users.noreply.github.com>
4 months ago
Benoit Tigeot
5d9d9a0fb8
Wait for Helm v4 before raising when platformCommand and Command are set
...
same for `PlatformHooks` and `hooks`.
When backporting a feature for Helm v3 we forgot to mark as deprecation
validations that will enforced in v4.
See (search for "Remove in Helm 4."):
- https://github.com/helm/helm/pull/13592/files#diff-fc137d62147eb6a9c89c0566479ff219320ca691f2505631ebacbe513bcc8108R268-R270
Fix:
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
4 months ago
Matt Farina
c5249c1f8d
Revert "fix (helm) : toToml` renders int as float [ backport to v3 ]"
...
This change has caused issues with numerous charts around things
unrelated to toml. This is because of functions like typeIs/typeOf
being used and acted upon.
The change caused a significant regression.
Closes #30880
Signed-off-by: Matt Farina <matt@mattfarina.com>
4 months ago
Robert Sirchia
e6122aba27
Merge pull request #30870 from helm/dependabot/go_modules/dev-v3/k8s-io-d6f802ad31
...
build(deps): bump the k8s-io group with 7 updates
4 months ago
dependabot[bot]
5b0520d6b3
build(deps): bump the k8s-io group with 7 updates
...
Bumps the k8s-io group with 7 updates:
| Package | From | To |
| --- | --- | --- |
| [k8s.io/api](https://github.com/kubernetes/api ) | `0.33.0` | `0.33.1` |
| [k8s.io/apiextensions-apiserver](https://github.com/kubernetes/apiextensions-apiserver ) | `0.33.0` | `0.33.1` |
| [k8s.io/apimachinery](https://github.com/kubernetes/apimachinery ) | `0.33.0` | `0.33.1` |
| [k8s.io/apiserver](https://github.com/kubernetes/apiserver ) | `0.33.0` | `0.33.1` |
| [k8s.io/cli-runtime](https://github.com/kubernetes/cli-runtime ) | `0.33.0` | `0.33.1` |
| [k8s.io/client-go](https://github.com/kubernetes/client-go ) | `0.33.0` | `0.33.1` |
| [k8s.io/kubectl](https://github.com/kubernetes/kubectl ) | `0.33.0` | `0.33.1` |
Updates `k8s.io/api` from 0.33.0 to 0.33.1
- [Commits](https://github.com/kubernetes/api/compare/v0.33.0...v0.33.1 )
Updates `k8s.io/apiextensions-apiserver` from 0.33.0 to 0.33.1
- [Release notes](https://github.com/kubernetes/apiextensions-apiserver/releases )
- [Commits](https://github.com/kubernetes/apiextensions-apiserver/compare/v0.33.0...v0.33.1 )
Updates `k8s.io/apimachinery` from 0.33.0 to 0.33.1
- [Commits](https://github.com/kubernetes/apimachinery/compare/v0.33.0...v0.33.1 )
Updates `k8s.io/apiserver` from 0.33.0 to 0.33.1
- [Commits](https://github.com/kubernetes/apiserver/compare/v0.33.0...v0.33.1 )
Updates `k8s.io/cli-runtime` from 0.33.0 to 0.33.1
- [Commits](https://github.com/kubernetes/cli-runtime/compare/v0.33.0...v0.33.1 )
Updates `k8s.io/client-go` from 0.33.0 to 0.33.1
- [Changelog](https://github.com/kubernetes/client-go/blob/master/CHANGELOG.md )
- [Commits](https://github.com/kubernetes/client-go/compare/v0.33.0...v0.33.1 )
Updates `k8s.io/kubectl` from 0.33.0 to 0.33.1
- [Commits](https://github.com/kubernetes/kubectl/compare/v0.33.0...v0.33.1 )
---
updated-dependencies:
- dependency-name: k8s.io/api
dependency-version: 0.33.1
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: k8s-io
- dependency-name: k8s.io/apiextensions-apiserver
dependency-version: 0.33.1
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: k8s-io
- dependency-name: k8s.io/apimachinery
dependency-version: 0.33.1
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: k8s-io
- dependency-name: k8s.io/apiserver
dependency-version: 0.33.1
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: k8s-io
- dependency-name: k8s.io/cli-runtime
dependency-version: 0.33.1
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: k8s-io
- dependency-name: k8s.io/client-go
dependency-version: 0.33.1
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: k8s-io
- dependency-name: k8s.io/kubectl
dependency-version: 0.33.1
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: k8s-io
...
Signed-off-by: dependabot[bot] <support@github.com>
4 months ago
Robert Sirchia
dc9d5c0cfc
Merge pull request #30852 from shfc/fix/add-warning
...
fix: add warning when ignore repo flag
4 months ago
Feng Cao
afefca8b2d
chore: update generalization warning message
...
Signed-off-by: Feng Cao <24779889+shfc@users.noreply.github.com>
4 months ago
Robert Sirchia
29571c5592
Merge pull request #30858 from helm/dependabot/go_modules/dev-v3/oras.land/oras-go/v2-2.6.0
...
build(deps): bump oras.land/oras-go/v2 from 2.5.0 to 2.6.0
4 months ago
dependabot[bot]
8d6d27c26a
build(deps): bump oras.land/oras-go/v2 from 2.5.0 to 2.6.0
...
Bumps [oras.land/oras-go/v2](https://github.com/oras-project/oras-go ) from 2.5.0 to 2.6.0.
- [Release notes](https://github.com/oras-project/oras-go/releases )
- [Commits](https://github.com/oras-project/oras-go/compare/v2.5.0...v2.6.0 )
---
updated-dependencies:
- dependency-name: oras.land/oras-go/v2
dependency-version: 2.6.0
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
4 months ago
Robert Sirchia
86fd0fdb69
Merge pull request #30797 from helm/dependabot/go_modules/dev-v3/k8s-io-1e1c2be46d
...
build(deps): bump the k8s-io group with 7 updates
4 months ago
dependabot[bot]
502c0d5f5b
build(deps): bump the k8s-io group with 7 updates
...
Bumps the k8s-io group with 7 updates:
| Package | From | To |
| --- | --- | --- |
| [k8s.io/api](https://github.com/kubernetes/api ) | `0.32.3` | `0.33.0` |
| [k8s.io/apiextensions-apiserver](https://github.com/kubernetes/apiextensions-apiserver ) | `0.32.3` | `0.33.0` |
| [k8s.io/apimachinery](https://github.com/kubernetes/apimachinery ) | `0.32.3` | `0.33.0` |
| [k8s.io/apiserver](https://github.com/kubernetes/apiserver ) | `0.32.3` | `0.33.0` |
| [k8s.io/cli-runtime](https://github.com/kubernetes/cli-runtime ) | `0.32.3` | `0.33.0` |
| [k8s.io/client-go](https://github.com/kubernetes/client-go ) | `0.32.3` | `0.33.0` |
| [k8s.io/kubectl](https://github.com/kubernetes/kubectl ) | `0.32.3` | `0.33.0` |
Updates `k8s.io/api` from 0.32.3 to 0.33.0
- [Commits](https://github.com/kubernetes/api/compare/v0.32.3...v0.33.0 )
Updates `k8s.io/apiextensions-apiserver` from 0.32.3 to 0.33.0
- [Release notes](https://github.com/kubernetes/apiextensions-apiserver/releases )
- [Commits](https://github.com/kubernetes/apiextensions-apiserver/compare/v0.32.3...v0.33.0 )
Updates `k8s.io/apimachinery` from 0.32.3 to 0.33.0
- [Commits](https://github.com/kubernetes/apimachinery/compare/v0.32.3...v0.33.0 )
Updates `k8s.io/apiserver` from 0.32.3 to 0.33.0
- [Commits](https://github.com/kubernetes/apiserver/compare/v0.32.3...v0.33.0 )
Updates `k8s.io/cli-runtime` from 0.32.3 to 0.33.0
- [Commits](https://github.com/kubernetes/cli-runtime/compare/v0.32.3...v0.33.0 )
Updates `k8s.io/client-go` from 0.32.3 to 0.33.0
- [Changelog](https://github.com/kubernetes/client-go/blob/master/CHANGELOG.md )
- [Commits](https://github.com/kubernetes/client-go/compare/v0.32.3...v0.33.0 )
Updates `k8s.io/kubectl` from 0.32.3 to 0.33.0
- [Commits](https://github.com/kubernetes/kubectl/compare/v0.32.3...v0.33.0 )
---
updated-dependencies:
- dependency-name: k8s.io/api
dependency-version: 0.33.0
dependency-type: direct:production
update-type: version-update:semver-minor
dependency-group: k8s-io
- dependency-name: k8s.io/apiextensions-apiserver
dependency-version: 0.33.0
dependency-type: direct:production
update-type: version-update:semver-minor
dependency-group: k8s-io
- dependency-name: k8s.io/apimachinery
dependency-version: 0.33.0
dependency-type: direct:production
update-type: version-update:semver-minor
dependency-group: k8s-io
- dependency-name: k8s.io/apiserver
dependency-version: 0.33.0
dependency-type: direct:production
update-type: version-update:semver-minor
dependency-group: k8s-io
- dependency-name: k8s.io/cli-runtime
dependency-version: 0.33.0
dependency-type: direct:production
update-type: version-update:semver-minor
dependency-group: k8s-io
- dependency-name: k8s.io/client-go
dependency-version: 0.33.0
dependency-type: direct:production
update-type: version-update:semver-minor
dependency-group: k8s-io
- dependency-name: k8s.io/kubectl
dependency-version: 0.33.0
dependency-type: direct:production
update-type: version-update:semver-minor
dependency-group: k8s-io
...
Signed-off-by: dependabot[bot] <support@github.com>
4 months ago