Isaiah Lewis
b76a950f68
fix(helm-lint): fmt
...
Signed-off-by: Isaiah Lewis <isaiah@roof12.com>
(cherry picked from commit 62e0c78ef8
)
(cherry picked from commit b278020311
)
1 month ago
Isaiah Lewis
b79a4212e8
fix(helm-lint): Add TLSClientConfig
...
Signed-off-by: Isaiah Lewis <isaiah@roof12.com>
(cherry picked from commit fb12b44493
)
(cherry picked from commit d33ac5e44b
)
1 month ago
Isaiah Lewis
b9180e674f
fix(helm-lint): Add HTTP/HTTPS URL support for json schema references
...
Signed-off-by: Isaiah Lewis <isaiah@roof12.com>
(cherry picked from commit fa73b6743b
)
(cherry picked from commit 854370978e
)
1 month ago
Robert Sirchia
b78692c18f
Merge commit from fork
...
json schema fix
1 month ago
Matt Farina
7799b483f5
fix Chart.yaml handling
...
Signed-off-by: Matt Farina <matt.farina@suse.com>
(cherry picked from commit f13afaacd6
)
2 months ago
Matt Farina
dd8502f7b4
Handle messy index files
...
Signed-off-by: Matt Farina <matt.farina@suse.com>
(cherry picked from commit 69efc0d4fb
)
(cherry picked from commit 039b0b18d3
)
2 months ago
Robert Sirchia
cb8595bc65
json schema fix
...
Signed-off-by: Robert Sirchia <rsirchia@outlook.com>
2 months ago
Robert Sirchia
d80839cf37
Merge pull request #31037 from mattfarina/disable-goimports-2
...
Disabling linter due to unknown issue
3 months ago
Matt Farina
f20a4ad1d5
Disabling linter due to unknown issue
...
Signed-off-by: Matt Farina <matt.farina@suse.com>
(cherry picked from commit 227c9cb6b6
)
3 months ago
Matt Farina
00de613324
Updating link handling
...
Signed-off-by: Matt Farina <matt.farina@suse.com>
(cherry picked from commit 76fdba4c8c
)
(cherry picked from commit 4389fa639a
)
3 months ago
Terry Howe
5b9e2f6b4c
fix: user username password for login
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
(cherry picked from commit 2c55a4e8ce
)
3 months ago
Terry Howe
2782412073
Update pkg/registry/transport.go
...
Co-authored-by: Scott Rigby <scott@r6by.com>
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
(cherry picked from commit a16e986d4e
)
3 months ago
Terry Howe
e66cf6afdd
Update pkg/registry/transport.go
...
Co-authored-by: Scott Rigby <scott@r6by.com>
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
(cherry picked from commit cea26d8bca
)
3 months ago
Terry Howe
191f05c068
fix: add debug logging to oci transport
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
Co-authored-by: Billy Zha <jinzha1@microsoft.com>
(cherry picked from commit b52bb41484
)
3 months ago
Terry Howe
04cad46100
fix: legacy docker support broken for login
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
4 months ago
Matt Farina
bc9f8a2d8b
Handle an empty registry config file.
...
In the move to oras v2, an existing but empty registry config file
became an uncaught error. A missing file caused no error. This
change catches the error and works around it so that Helm can
continue to be fault tolerant to this issue.
Signed-off-by: Matt Farina <matt.farina@suse.com>
4 months ago
Brandt Keller
f6f8700a53
fix(client): skipnode utilization for PreCopy
...
Co-authored-by: George Jenkins <gvjenkins@gmail.com>
Signed-off-by: Brandt Keller <43887158+brandtkeller@users.noreply.github.com>
(cherry picked from commit a18a52e898
)
4 months ago
Brandt Keller
4da701593f
fix(client): layers now returns manifest - remove duplicate from descriptors
...
Signed-off-by: Brandt Keller <brandt.keller@defenseunicorns.com>
(cherry picked from commit b07ab77da3
)
4 months ago
Brandt Keller
1a8507fd5a
fix(client): return nil on non-allowed media types
...
Signed-off-by: Brandt Keller <brandt.keller@defenseunicorns.com>
(cherry picked from commit c225c124ac
)
4 months ago
Benoit Tigeot
015531ca4f
Prevent fetching newReference again as we have in calling method
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
(cherry picked from commit c33215d765
)
4 months ago
Benoit Tigeot
9db1a120f9
Prevent failure when resolving version tags in oras memory store
...
- The newReference() function transforms version tags by replacing + with _ for OCI compatibility
- But the code was using the original ref (with +) for TagBytes()
- Then it tries to find the tagged reference using parsedRef.String() (with _)
- This mismatch causes the Resolve method to fail with "not found"
- By using parsedRef.String() consistently in both places, the references will match and the lookup will succeed.
I extracted the TagBytes function to improve testability.
Push() includes several external calls that are hard to mock,
so isolating this logic makes testing more manageable.
Close : #30881
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
(cherry picked from commit f552b67230
)
4 months ago
Benoit Tigeot
e8bfa0eed6
Update pkg/plugin/plugin.go
...
Co-authored-by: George Jenkins <gvjenkins@gmail.com>
Signed-off-by: Benoit Tigeot <benoittgt@users.noreply.github.com>
(cherry picked from commit dce60adb51
)
4 months ago
Benoit Tigeot
24b44902a2
Update pkg/plugin/plugin.go
...
Co-authored-by: George Jenkins <gvjenkins@gmail.com>
Signed-off-by: Benoit Tigeot <benoittgt@users.noreply.github.com>
(cherry picked from commit cda0865d64
)
4 months ago
Benoit Tigeot
7e8f53421a
Wait for Helm v4 before raising when platformCommand and Command are set
...
same for `PlatformHooks` and `hooks`.
When backporting a feature for Helm v3 we forgot to mark as deprecation
validations that will enforced in v4.
See (search for "Remove in Helm 4."):
- https://github.com/helm/helm/pull/13592/files#diff-fc137d62147eb6a9c89c0566479ff219320ca691f2505631ebacbe513bcc8108R268-R270
Fix:
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
(cherry picked from commit 5d9d9a0fb8
)
4 months ago
Scott Rigby
ea04cea48b
Fix 3.18.0 regression: registry login with scheme
...
Helm 3.18.0 released an upgrade of ORAS from v1 to v2.
ORAS v2 correctly does not accept http/https scheme for registry login, while
ORAS v1 previously did. Even if v1 should not have, we want to preserve
backwards compatibility for Helm 3 users who pass the scheme.
This will be removed in Helm 4, where registry login will not accept http/https
scheme.
Co-authored-by: Andrew Block <andy.block@gmail.com>
Co-authored-by: Terry Howe <terrylhowe@gmail.com>
Signed-off-by: Scott Rigby <scott@r6by.com>
(cherry picked from commit c0f3ace52d
)
4 months ago
Matt Farina
bec66098fd
Revert "fix (helm) : toToml` renders int as float [ backport to v3 ]"
...
This change has caused issues with numerous charts around things
unrelated to toml. This is because of functions like typeIs/typeOf
being used and acted upon.
The change caused a significant regression.
Closes #30880
Signed-off-by: Matt Farina <matt@mattfarina.com>
(cherry picked from commit c5249c1f8d
)
4 months ago
Robert Sirchia
d8edc2aebc
bump version to v3.18.0
...
Signed-off-by: Robert Sirchia <rsirchia@outlook.com>
5 months ago
Terry Howe
cdd7c105a6
docs: Note about http fallback for OCI registries
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
5 months ago
Scott Rigby
e4bc4a31b9
Merge pull request #30768 from banjoh/em/fix-take-ownership
...
v3 backport - fix --take-ownership
5 months ago
Benoit Tigeot
087fa18276
Bump toml
...
Looking at the [toml diff](https://github.com/BurntSushi/toml/compare/v1.4.0...v1.5.0 ). I think it's safe to change the test here.
For main: https://github.com/helm/helm/pull/30775
Closes: https://github.com/helm/helm/pull/30683
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
5 months ago
Evans Mungai
0906fe7f6b
Add install test for TakeOwnership flag
...
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
5 months ago
Patrick Seidensal
4ee3a19e9a
Fix --take-ownership
...
If a resource exists in the cluster and is to be adopted by helm install
--take-ownership, it is left unchanged while helm reports the
installation to have succeeded.
This is due to CRs and CRDs being merged without three-way-merge, which
results in an empty patch.
By using a three-way-merge transparently when --take-ownership is used,
the helm behaves as expected without breaking previous behavior.
Fixes #30622
Signed-off-by: Patrick Seidensal <pseidensal@suse.com>
5 months ago
Matt Farina
3ce10e4f81
Unarchiving fix
...
Signed-off-by: Matt Farina <matt@mattfarina.com>
(cherry picked from commit 7cc4dcf94ee410c8e0d64f3e726dda199c24ccb2)
6 months ago
Benoit Tigeot
422c58e4a2
Fix typo
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
6 months ago
Benoit Tigeot
5e7f12d4c3
Report as debug log, the time spent waiting for resources
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
6 months ago
Terry Howe
1435ec7c77
Update pkg/registry/fallback.go
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
7 months ago
Terry Howe
674e882c88
automatic fallback to http
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
7 months ago
Terry Howe
c188441757
chore(oci): upgrade to ORAS v2
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
7 months ago
Scott Rigby
bcb83e465f
Fix cherry-pick helm.sh/helm/v4 -> helm.sh/helm/v3
...
Signed-off-by: Scott Rigby <scott@r6by.com>
7 months ago
Chris Berry
2aa90b8f26
Refactor based on review comment
...
Signed-off-by: Chris Berry <bez625@gmail.com>
7 months ago
Chris Berry
5739197faa
Refactor based on review comment
...
Signed-off-by: Chris Berry <bez625@gmail.com>
7 months ago
Chris Berry
b8e13878fc
Add HookOutputFunc and generic yaml unmarshaller
...
Signed-off-by: Chris Berry <bez625@gmail.com>
7 months ago
Scott Rigby
97b0e11871
clarify fix error message
...
Signed-off-by: Scott Rigby <scott@r6by.com>
7 months ago
Scott Rigby
2f79afb0a3
fix err check
...
Co-authored-by: George Jenkins <gvjenkins@gmail.com>
Signed-off-by: Scott Rigby <scott@r6by.com>
7 months ago
Scott Rigby
c77f4ec6c4
remove comments about previous functionality
...
Signed-off-by: Scott Rigby <scott@r6by.com>
7 months ago
Scott Rigby
3cd6afe845
add short circuit return
...
Co-authored-by: George Jenkins <gvjenkins@gmail.com>
Signed-off-by: Scott Rigby <scott@r6by.com>
7 months ago
Chris Berry
5367001f4f
Update based on review comments
...
Signed-off-by: Chris Berry <bez625@gmail.com>
7 months ago
Chris Berry
3c445158d8
Update based on review comments
...
Signed-off-by: Chris Berry <bez625@gmail.com>
7 months ago
Chris Berry
4cb639ed4e
Fix lint
...
Signed-off-by: Chris Berry <bez625@gmail.com>
7 months ago
Chris
20f859c9ff
Tidy up imports
...
Signed-off-by: Chris <bez625@gmail.com>
7 months ago