Robert Sirchia
fa11636b01
Merge pull request #32590 from cuishuang/main
...
fix(downloader): pass getter options when fetching cached provenance
1 week ago
George Jenkins
babae796e3
chore: Cleanup deprecated and TODO comments
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
2 weeks ago
Matthieu MOREL
28e64bd2dd
chore: fix gofumpt extra-rules ( #32486 )
...
* chore: fix gofumpt extra-rules
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
* Apply suggestions from code review
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
---------
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
2 weeks ago
cuishuang
57a67b30d2
fix(downloader): pass getter options when fetching cached provenance
...
Signed-off-by: cuishuang <imcusg@gmail.com>
2 weeks ago
Terry Howe
8eb65528be
Merge pull request #32467 from mmorel-35/testify-assertions-pkg-3
...
chore(pkg): refactor: finer tests conversions to testify part 3
2 months ago
Terry Howe
e29e06e97d
Merge pull request #32466 from mmorel-35/testify-assertions-pkg-2
...
chore(pkg): refactor: finer tests conversions to testify part 2
2 months ago
Matthieu MOREL
828d01a878
chore(pkg): refactor: finer tests conversions to testify part 1
...
refactor: finer tests conversions to testify in pkg/strvals
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2 months ago
Matthieu MOREL
9a2be11e6f
chore(pkg): refactor: finer tests conversions to testify part 3
...
refactor: finer tests conversions to testify in pkg/cmd
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2 months ago
Matthieu MOREL
4d9c03f51c
chore(pkg): refactor: finer tests conversions to testify part 2
...
#### Description
refactor: finer tests conversions to testify in pkg/storage/driver
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2 months ago
Terry Howe
76bf75c956
Merge pull request #32436 from mmorel-35/testifylint-manual-assert-pkg-20
...
chore(pkg): refactor: convert tests to testify assert/require part 20
2 months ago
Terry Howe
ea9e38035d
Merge pull request #32429 from mmorel-35/testifylint-manual-assert-pkg-14
...
chore(pkg): refactor: convert tests to testify assert/require part 14
2 months ago
Matthieu MOREL
1d4665e54c
chore(pkg): refactor: convert tests to testify assert/require part 20
...
#### Description
refactor: convert tests to testify assert/require in pkg/cmd
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2 months ago
Matthieu MOREL
dc66ee7be7
chore(pkg): refactor: convert tests to testify assert/require part 14
...
refactor: convert tests to testify assert/require in pkg/storage/driver
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2 months ago
Matthieu MOREL
dc3e3a5e7e
chore(pkg): refactor: convert tests to testify assert/require part 11
...
refactor: convert tests to testify assert/require in pkg
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2 months ago
Matthieu MOREL
3ff05c835e
chore(pkg): refactor: convert tests to testify assert/require part 5
...
refactor: convert tests to testify assert/require in pkg
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2 months ago
Lohit Kolluri
ad93b7df63
feat: honor SOURCE_DATE_EPOCH for chart archives ( #32162 )
...
* feat: honor SOURCE_DATE_EPOCH for chart archives
Add StampModTimes() on Chart struct to recursively set ModTime on
all chart file entries. CLI reads SOURCE_DATE_EPOCH env var and wires
through all 5 commands: package, install, upgrade, dep build, dep update.
Removes unused v3 duplicate source_date_epoch.go (YAGNI).
Inlines env var parsing to CLI layer from chart util.
Signed-off-by: Lohit Kolluri <lohitkolluri@gmail.com>
* docs: document SOURCE_DATE_EPOCH in environment variables help
Add a short entry for $SOURCE_DATE_EPOCH to the env var table shown
in 'helm help'. The variable is honored by 'helm package', 'install',
'upgrade', 'dep build', and 'dep update' to produce reproducible chart
archives. Full documentation belongs in helm-www.
Signed-off-by: Lohit Kolluri <lohitkolluri@gmail.com>
* fix: adapt SourceDateEpoch to upstream refactored dep check
Upstream/main restructured the dependency error handling in install.go
and upgrade.go from a nested-if block (if DependencyUpdate) to an
early-return pattern (if !DependencyUpdate). Adapt the feature's
Manager construction to match the new code structure.
Signed-off-by: Lohit Kolluri <lohitkolluri@gmail.com>
---------
Signed-off-by: Lohit Kolluri <lohitkolluri@gmail.com>
2 months ago
George Jenkins
7a7b328ba5
Merge pull request #32319 from mmorel-35/revive
...
feat(linters): add new revive rules for better code quality
2 months ago
Matthieu MOREL
16787d65f5
feat(linters): add new revive rules for better code quality
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2 months ago
Matthieu MOREL
9662fdd73b
refactor: enable several checks from gocritic
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2 months ago
Terry Howe
d262c7ca79
Merge pull request #32296 from mmorel-35/gocritic-singleCaseSwitch
...
chore: fix emptyStringTest, nestingReduce and singleCaseSwitch checks issues from gocritic
2 months ago
Matthieu MOREL
96b315f188
chore: fix emptyStringTest, nestingReduce and singleCaseSwitch checks issues from gocritic
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2 months ago
Matthieu MOREL
4ade4a5495
test: replace assert.Contains with assert.ErrorContains for better error handling
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2 months ago
Matthieu MOREL
f34ad6c337
chore: fix several checks issues from testifylint
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2 months ago
Matthieu MOREL
07259ecc86
chore: fix several checks issues from gocritic
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2 months ago
Terry Howe
b3fbf8d0f7
Merge pull request #30808 from mmorel-35/errorlint
...
chore: enable errorlint
3 months ago
Terry Howe
59b57c5c31
Merge pull request #31885 from mmorel-35/whitespace
...
chore: fix whitespace linter
3 months ago
Sumit Solanki
53d5f13f46
Potential fix for pull request finding
...
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Sumit Solanki <sumit.solanki@ibm.com>
4 months ago
Sumit Solanki
6620fec5d1
fix(downloader): order DiskCache.Get checks for overlayfs empty dirs
...
Signed-off-by: Sumit Solanki <sumit.solanki@ibm.com>
4 months ago
Terry Howe
83a4611908
Merge pull request #12932 from AndiDog/error-message
...
Make error message instructional for the case of lock file being out of date
5 months ago
Matthieu MOREL
af31a67924
chore: enable errorlint linter
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
6 months ago
Matthieu MOREL
1e0f702f00
chore: fix whitespace linter
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
6 months ago
George Jenkins
42f78ba60e
Merge pull request #31872 from mmorel-35/perfsprint-pkg-6-5f845e3
...
chore(pkg): fix perfsprint linter issues part 6
6 months ago
George Jenkins
e3b4808450
Merge pull request #31874 from mmorel-35/perfsprint-pkg-4-fb6db58
...
chore(pkg): fix perfsprint linter issues part 4
6 months ago
Matthieu MOREL
e31a078e6e
chore: enable modernize linter ( #31860 )
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
6 months ago
Matthieu MOREL
dc0e3f10c3
chore(pkg): fix perfsprint linter issues part 6
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
7 months ago
Matthieu MOREL
63f03c0f5c
chore(pkg): enable perfsprint linter
...
#### Description
enable perfsprint linter in pkg/action
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
7 months ago
Evans Mungai
ee018608f6
fix: handle OCI digest algorithm prefix in chart downloader ( #31601 )
...
* fix: strip digest algorithm prefix before hex decoding
OCI references with tag+digest (e.g., chart:1.0@sha256:abc...) failed with "invalid byte" error because the sha256: prefix was passed to hex.DecodeString().
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
* Add cmd test for OCI references with tag+digest
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
* Move oci registry push result to a struct
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
* Review comments from PR review
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
* Fix failing test
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
---------
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
7 months ago
Terry Howe
b26ec6b09e
Merge pull request #31566 from TerryHowe/fix-test-concurrency-download-index
...
fix: test concurrency download index
7 months ago
Joe Julian
14e0b8f970
Merge pull request #31128 from orgads/win-parallel
...
fix(downloader): prevent concurrent file access errors on Windows
7 months ago
Joe Julian
56d0d9374a
Merge pull request #31810 from mmorel-35/errorlint-pkg-5-dda0145
...
fix(pkg): errorlint linter
7 months ago
Matthieu MOREL
4330bdea04
fix(pkg): errorlint linter
...
#### Description
errorlint linter in pkg
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
7 months ago
Matthieu MOREL
c8989d984f
fix(pkg): errorlint linter
...
#### Description
errorlint linter in pkg
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
7 months ago
Orgad Shaneh
76eb37c01a
fix(downloader): safely handle concurrent file writes on Windows
...
When multiple processes try to download the same chart version
concurrently (e.g., via Terraform), they can race to write the
destination file. On Windows, this results in 'Access Denied'
errors because the file cannot be renamed while another process
has a handle to the destination.
This commit introduces 'PlatformAtomicWriteFile' to the fileutil
package. On Unix-like systems, it simply delegates to AtomicWriteFile,
maintaining existing behavior. On Windows, it coordinates writes using
a lock file (.lock). It acquires the lock, then performs the atomic
write.
Crucially, this implementation ensures that existing files are
overwritten (rather than skipped). This ensures that if a chart is
republished with the same version, the local cache is correctly updated,
preventing stale data issues.
Fixes #31633
Signed-off-by: Orgad Shaneh <orgad.shaneh@audiocodes.com>
7 months ago
megha1906
e71a29ce4f
chore: fix typo in pkg/downloader/chart_downloader.go
...
Signed-off-by: megha1906 <meghabansal135@gmail.com>
10 months ago
Terry Howe
64bae717c5
fxi: test concurrency download index
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
10 months ago
Mads Jensen
380abe2b16
Remove two redundant if-checks.
...
These were found with the nilness checker.
Signed-off-by: Mads Jensen <atombrella@users.noreply.github.com>
10 months ago
tison
4576a81a00
for remaining local variable case inconsistency
...
Signed-off-by: tison <wander4096@gmail.com>
10 months ago
tison
90d01915f9
for all other similar cases
...
Signed-off-by: tison <wander4096@gmail.com>
10 months ago
Matt Farina
52267ee74b
Move repo package to versioned directory
...
The repo package is internally versioned at v1. Repos were designed
to be versioned. This change moves it to a versioned directory the
same way other packages are now being handled.
Signed-off-by: Matt Farina <matt.farina@suse.com>
1 year ago
Scott Rigby
e814ff3c38
Remove unnecessary file i/o operations from signing and verifying
...
Signed-off-by: Scott Rigby <scott@r6by.com>
1 year ago