George Jenkins
ca6681ca55
chore: Fix independent-merge lint issues
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
1 week ago
Matthieu MOREL
28e64bd2dd
chore: fix gofumpt extra-rules ( #32486 )
...
* chore: fix gofumpt extra-rules
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
* Apply suggestions from code review
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
---------
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
1 week ago
Matthieu MOREL
24bbb46c62
chore: fix gofumpt issues
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2 months ago
Matthieu MOREL
a2b1a60d51
fix: enhance error handling and improve test assertions ( #32352 )
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2 months ago
Matthieu MOREL
a02a5713de
chore: fix elseif and ifElseChain issues from gocritic ( #32289 )
...
* chore: fix elseif and ifElseChain issues from gocritic
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
* test: enhance assertions in OCIInstaller and list tests using testify
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
---------
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2 months ago
George Jenkins
7a7b328ba5
Merge pull request #32319 from mmorel-35/revive
...
feat(linters): add new revive rules for better code quality
2 months ago
George Jenkins
b46d116afe
Merge pull request #32320 from mmorel-35/gomodguard_v2
...
fix(linters): update golangci-lint to 2.12.2
2 months ago
George Jenkins
66c1232dc7
Merge pull request #32321 from mmorel-35/gocritic
...
refactor: enable several checks from gocritic
2 months ago
Akanksha Trehun
cfa3b24fe6
fix: remove trailing whitespace in .golangci.yml ( #32325 )
...
Signed-off-by: Akanksha Trehun <akankshatrehun@gmail.com>
2 months ago
Matthieu MOREL
16787d65f5
feat(linters): add new revive rules for better code quality
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2 months ago
Matthieu MOREL
9662fdd73b
refactor: enable several checks from gocritic
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2 months ago
Matthieu MOREL
7bfcdb0fc3
fix(linters): update golangci-lint to 2.12.2
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2 months ago
Terry Howe
d262c7ca79
Merge pull request #32296 from mmorel-35/gocritic-singleCaseSwitch
...
chore: fix emptyStringTest, nestingReduce and singleCaseSwitch checks issues from gocritic
2 months ago
Matthieu MOREL
96b315f188
chore: fix emptyStringTest, nestingReduce and singleCaseSwitch checks issues from gocritic
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2 months ago
Matthieu MOREL
f34ad6c337
chore: fix several checks issues from testifylint
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2 months ago
Matthieu MOREL
07259ecc86
chore: fix several checks issues from gocritic
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2 months ago
Matthieu MOREL
34cfdfdbe5
chore: enable contextcheck, fatcontext and noctx linters
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
3 months ago
George Jenkins
253da5106a
Merge pull request #32171 from mmorel-35/empty-len
...
Fix empty and len testifylint violations across test files
3 months ago
Terry Howe
b3fbf8d0f7
Merge pull request #30808 from mmorel-35/errorlint
...
chore: enable errorlint
3 months ago
George Jenkins
81d6f04c82
Merge pull request #30867 from mmorel-35/gocritic
...
chore: fix deprecatedComment issues from gocritic
3 months ago
Terry Howe
59b57c5c31
Merge pull request #31885 from mmorel-35/whitespace
...
chore: fix whitespace linter
3 months ago
Matthieu MOREL
488c4a805d
Fix empty and len testifylint violations across test files
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
3 months ago
Evans Mungai
d374e823b2
Merge pull request #32086 from mmorel-35/error-is-as
...
testifylint: enable error-is-as and error-nil rules
4 months ago
Arnav Nagzirkar
e679ec9f04
ci: enable bidichk linter to prevent invisible Unicode characters
...
Adds the bidichk linter to .golangci.yml to detect dangerous invisible
Unicode characters (ZWSP, bidi controls) in source files during CI.
Fixes #32137
Signed-off-by: Arnav Nagzirkar <arnav.nagzirkar@mail.utoronto.ca>
4 months ago
Matthieu MOREL
f8ba28bb17
testifylint: enable error-is-as and error-nil rules
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
5 months ago
George Jenkins
4bd9e90aa0
Merge pull request #30811 from mmorel-35/testifylint
...
chore: fix bool-compare issues from testifylint
5 months ago
George Jenkins
ce203dc568
Merge pull request #31938 from mmorel-35/perfsprint
...
chore: enable perfsprint linter
6 months ago
Matthieu MOREL
7edfff33eb
chore: fix unnecessary-format issues from revive
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
6 months ago
Matthieu MOREL
071558d69f
chore: fix bool-compare issues from testifylint
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
6 months ago
Matthieu MOREL
83a0138172
chore: fix deprecatedComment issues from gocritic
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
6 months ago
Matthieu MOREL
af31a67924
chore: enable errorlint linter
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
6 months ago
Matthieu MOREL
62494896e9
chore: enable perfsprint linter
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
6 months ago
Matthieu MOREL
1e0f702f00
chore: fix whitespace linter
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
6 months ago
Matthieu MOREL
e31a078e6e
chore: enable modernize linter ( #31860 )
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
6 months ago
Matthieu MOREL
5b6c6bbfc7
fix: enable nolinlint linter
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
7 months ago
Brenden Ehlers
9a898af7f2
enable exhaustive linter
...
Signed-off-by: Brenden Ehlers <brenden@theehlers.org>
9 months ago
Brenden Ehlers
1c119bcaa6
fix: add default casess to switch statements
...
Signed-off-by: Brenden Ehlers <brenden@theehlers.org>
9 months ago
Mads Jensen
a18e59e465
Enable the sloglint linter
...
Signed-off-by: Mads Jensen <atombrella@users.noreply.github.com>
9 months ago
Matt Farina
0d359d44ea
Restore lint rule for excluding meaningless name
...
This rule is needed for packages like 'util'. Changes to those
packages trigger this rule.
Signed-off-by: Matt Farina <matt.farina@suse.com>
12 months ago
Benoit Tigeot
34c2d5c1a9
Remove unused golangci-lint rules that produce warning
...
Avoid this noisy output when running local linting:
```sh
❯ golangci-lint run ./...
WARN [runner/exclusion_rules] Skipped 0 issues by rules: [Text: "var-naming: avoid meaningless package names", Linters: "revive"]
```
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
12 months ago
Matt Farina
9dcc49cbd5
Move lint pkg to be part of each chart version
...
Linting is specific to the chart versions. A v2 and v3 chart will
lint differently.
To accomplish this, packages like engine need to be able to handle
different chart versions. This was accomplished by some changes:
1. The introduction of a Charter interface for charts
2. The ChartAccessor which is able to accept a chart and then
provide access to its data via an interface. There is an
interface, factory, and implementation for each version of
chart.
3. Common packages were moved to a common and util packages.
Due to some package loops, there are 2 packages which may
get some consolidation in the future.
The new interfaces provide the foundation to move the actions
and cmd packages to be able to handle multiple apiVersions of
charts.
Signed-off-by: Matt Farina <matt.farina@suse.com>
1 year ago
Matthieu MOREL
56a2bb4188
chore: enable usetesting linter
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
1 year ago
Robert Sirchia
1b21f04b3b
Merge pull request #30865 from mmorel-35/github.com/evanphx/json-patch/v5
...
fix: update json-patch import path and add gomodguard settings
1 year ago
Matthieu MOREL
157f0ba10a
chore: enable thelper
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
1 year ago
Matthieu MOREL
706392fabb
fix: update json-patch import path and add gomodguard settings
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
1 year ago
Robert Sirchia
4d580c6b95
Merge pull request #30810 from mmorel-35/usestdlibvars
...
chore: enable usestdlibvars linter
1 year ago
Adharsh
7801588957
Fix bug in .golangci.yml configuration
...
The initial configuration was missing rules that caused the linter to skip
certain important checks. This update adds the missing rules to ensure the
code quality checks are correctly enforced across the repository.
Signed-off-by: Adharsh <adharshunni0007@gmail.com>
1 year ago
Matthieu MOREL
77a267dacf
chore: enable usestdlibvars linter
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
1 year ago
Matthieu MOREL
3270d35d3f
refactor: reorganize .golangci.yml for better clarity and structure
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
1 year ago
Justen Stall
700103d76a
chore: add depguard rule for github.com/pkg/errors
...
Signed-off-by: Justen Stall <39888103+justenstall@users.noreply.github.com>
1 year ago