7 Commits (copilot/important-issues-review)

Author	SHA1	Message	Date
Zhaofeng Miao	3bcf965f99	perf: enable concurrent status computation to prevent multi-minute delays (#32043) ... * fix: enable concurrent status computation to prevent multi-minute delays Set StatusComputeWorkers=8 on DefaultStatusWatcher for Wait, WaitWithJobs, and WatchUntilReady. This opts in to the async status computation added in fluxcd/cli-utils#20, preventing the informer notification pipeline from being blocked by slow API calls when many resources are updated simultaneously. Without this, status computation for resources like Deployments (which require additional LIST ReplicaSets/Pods calls) runs serially inside the informer, causing growing delays of 1-3+ minutes when upgrading many resources at once (e.g., ~20 Deployments via Helm). Signed-off-by: maplemiao <maplemiao@tencent.com> * refactor(kube): expose StatusComputeWorkers as a WaitOption Replace the package-level DefaultStatusComputeWorkers variable with a WithStatusComputeWorkers WaitOption threaded through waitOptions into the statusWaiter. This removes global mutable state from pkg/kube and lets callers opt in explicitly. SDK consumers (e.g. helm-controller) inherit the zero value, which preserves the upstream cli-utils synchronous behavior and avoids an unexpected fan-out of status-compute goroutines when many releases reconcile concurrently. The Helm CLI continues to enable 8 workers by default via a shared pkg/cmd/flags.go helper, so install/upgrade/ rollback/uninstall/test users still get the fix for multi-minute informer stalls out of the box. Signed-off-by: maplemiao <maplemiao@tencent.com> * refactor(kube): clamp negative StatusComputeWorkers values to zero Address review feedback: when a caller passes a negative value to WithStatusComputeWorkers, coerce it to zero rather than propagating it to the underlying cli-utils watcher, where the behavior is undefined. Zero is the safe default and matches the SDK opt-in contract. Signed-off-by: maplemiao <maplemiao@tencent.com> --------- Signed-off-by: maplemiao <maplemiao@tencent.com> Signed-off-by: Maple Miao <maplemiao@yunzhanghu.com> Co-authored-by: Cursor <cursoragent@cursor.com>	4 weeks ago
Matthieu MOREL	1e0f702f00	chore: fix whitespace linter ... Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>	5 months ago
Evans Mungai	e70d59de7c	docs: document uninstall using cascade foreground flag ... Signed-off-by: Evans Mungai <mbuevans@gmail.com>	7 months ago
Mads Jensen	6cceead399	Use modernize to use newer Golang features. ... The rangeint suggestion is faster. The maps.Copy and slices.Contains are just syntatic sugar. Signed-off-by: Mads Jensen <atombrella@users.noreply.github.com>	9 months ago
Austin Abro	386523bdbc	update to get waiter instead of set ... Signed-off-by: Austin Abro <AustinAbro321@gmail.com>	1 year ago
Austin Abro	1704ce3067	Merge branch 'main' into refactor-wait	1 year ago
Austin Abro	297f7b9acb	squash ... Signed-off-by: Austin Abro <AustinAbro321@gmail.com>	1 year ago