52 Commits (copilot/important-issues-review)

Author	SHA1	Message	Date
Benoit Tigeot	03bb62f63d	jsonschema: warn and ignore unresolved URN $ref to match v3.18.4 ... - v3.18.5 switched jsonschema and began resolving external $ref at compile-time, exposing missing urn handling (“no URLLoader registered for urn:…”). - Add urn scheme loader and pluggable URNResolver. If unresolved, log a warning and return a permissive true schema (back-compat). - Apply to pkg/chart/v2 and internal/chart/v3 validators. Not sure about that Note: external URNs need AddResource/Resolver (the CLI uses --map for this). Warning may appear twice since both validators run. Another strategy could be to add the option to import more "external schema" explicitly but it is another PR. Something similar to `--map` from jsonschema package (santhosh-tekuri/jsonschema@ed65924). Close: #31170 Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>	12 months ago
Matt Farina	9dcc49cbd5	Move lint pkg to be part of each chart version ... Linting is specific to the chart versions. A v2 and v3 chart will lint differently. To accomplish this, packages like engine need to be able to handle different chart versions. This was accomplished by some changes: 1. The introduction of a Charter interface for charts 2. The ChartAccessor which is able to accept a chart and then provide access to its data via an interface. There is an interface, factory, and implementation for each version of chart. 3. Common packages were moved to a common and util packages. Due to some package loops, there are 2 packages which may get some consolidation in the future. The new interfaces provide the foundation to move the actions and cmd packages to be able to handle multiple apiVersions of charts. Signed-off-by: Matt Farina <matt.farina@suse.com>	12 months ago