8 Commits (copilot/important-issues-review)

Author	SHA1	Message	Date
Matthieu MOREL	a02a5713de	chore: fix elseif and ifElseChain issues from gocritic (#32289) ... * chore: fix elseif and ifElseChain issues from gocritic Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com> * test: enhance assertions in OCIInstaller and list tests using testify Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com> --------- Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>	1 month ago
Evans Mungai	a8e249714f	Update pkg/chart/common/util/coalesce.go ... Signed-off-by: Evans Mungai <mbuevans@gmail.com>	4 months ago
Johannes Lohmer	00638773d1	fix(values): do not copy chart-default nils into coalesced values ... Only user-supplied nils should survive coalescing. Chart-default nils defaults, not just user overrides. This caused: - %!s(<nil>) in templates using Bitnami common.secrets.key (#31919) - pluck fallbacks returning nil instead of falling through to globals (#31971) Fixes #31919 Fixes #31971 Signed-off-by: Johannes Lohmer <jojo.dev@lohmer.com>	4 months ago
Matthieu MOREL	ba38159313	chore(pkg): fix modernize linter ... #### Description fix modernize linter in pkg/strvals Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>	6 months ago
Evans Mungai	679f051980	Preserve nil values in chart already ... Signed-off-by: Evans Mungai <mbuevans@gmail.com>	8 months ago
Evans Mungai	292fe70219	fix(values): preserve nil values when chart default is empty map ... Only delete nil user values when overriding a non-nil chart default. When chart has empty map or no default for a key, preserve user's nil. | Scenario | Result | |----------|--------| | User sets `baz: ~`, chart has `baz: "value"` | Key deleted | | User sets `baz: ~`, chart has empty map `{}` | Nil preserved | | User sets `baz: ~`, chart has `baz: ~` | Nil preserved | Fixes #31643 Signed-off-by: Evans Mungai <mbuevans@gmail.com>	8 months ago
Terry Howe	bee9c1a108	chore: replace github.com/mitchellh/copystructure ... Signed-off-by: Terry Howe <terrylhowe@gmail.com>	11 months ago
Matt Farina	9dcc49cbd5	Move lint pkg to be part of each chart version ... Linting is specific to the chart versions. A v2 and v3 chart will lint differently. To accomplish this, packages like engine need to be able to handle different chart versions. This was accomplished by some changes: 1. The introduction of a Charter interface for charts 2. The ChartAccessor which is able to accept a chart and then provide access to its data via an interface. There is an interface, factory, and implementation for each version of chart. 3. Common packages were moved to a common and util packages. Due to some package loops, there are 2 packages which may get some consolidation in the future. The new interfaces provide the foundation to move the actions and cmd packages to be able to handle multiple apiVersions of charts. Signed-off-by: Matt Farina <matt.farina@suse.com>	12 months ago