4 Commits (copilot/important-issues-review)

Author	SHA1	Message	Date
Abhay Chaurasiya	82be04d7f2	remove legacy import comments from remaining packages (#31933) ... Pre-Go-modules import path comments (e.g. `// import "helm.sh/helm/v4/..."`) are obsolete since Go 1.11 where go.mod is the authoritative module path. These stale comments cause issues with downstream tooling such as Kythe. Removes the legacy import comments from 64 files across 20 packages: - cmd/helm - internal/chart/v3/lint and sub-packages - internal/plugin and sub-packages - internal/release/v2/util - pkg/chart/v2/lint and sub-packages - pkg/cmd, pkg/engine, pkg/ignore, pkg/provenance - pkg/registry - pkg/release/v1/util - pkg/repo/v1 - pkg/storage and pkg/storage/driver Follows up on #31931 and #31932 which addressed pkg/kube. Fixes #31846 Signed-off-by: abhay1999 <abhay.chaurasiya@example.com> Signed-off-by: abhay1999 <abhaychaurasiya19@gmail.com>	1 month ago
Aleksei Sviridkin	979e68fbbd	internal/plugin: remove zero-width spaces from plugin name comment ... The comment describing allowed plugin name characters contained three U+200B (zero-width space) characters around the '_' and '-' literals. The rendered comment is identical without them; the ZWSP were likely copy-pasted from a rich-text source. Downstream impact: every project that vendors helm.sh/helm/v4 and runs Renovate gets a repo-wide warning on its Dependency Dashboard about hidden Unicode characters. Renovate scans the whole tree (including vendor/) for ZWSP/bidi-override codepoints and cannot be told to skip a path for this specific check. Removing the characters here clears the warning everywhere downstream. Signed-off-by: Aleksei Sviridkin <f@lex.la>	3 months ago
Scott Rigby	be74ab72a0	[HIP-0026] Plugin runtime interface (#31145) ... * Runtime abstraction to encapsulate subprocess code and enable future runtimes Also fix race condition in TestPrepareCommandExtraArgs by replacing the shared variable modification with a local copy Co-authored-by: George Jenkins <gvjenkins@gmail.com> Signed-off-by: Scott Rigby <scott@r6by.com> * Remove commented out code Co-authored-by: Joe Julian <me@joejulian.name> Signed-off-by: Scott Rigby <scott@r6by.com> * Check test failure string Co-authored-by: Jesse Simpson <jesse.simpson36@gmail.com> Signed-off-by: Scott Rigby <scott@r6by.com> --------- Signed-off-by: Scott Rigby <scott@r6by.com> Co-authored-by: George Jenkins <gvjenkins@gmail.com> Co-authored-by: Joe Julian <me@joejulian.name> Co-authored-by: Jesse Simpson <jesse.simpson36@gmail.com>	1 year ago
George Jenkins	a1c84f9a4c	Move pkg/plugin -> internal/plugin ... Signed-off-by: George Jenkins <gvjenkins@gmail.com>	1 year ago