8 Commits (copilot/important-issues-review)

Author	SHA1	Message	Date
Matthieu MOREL	ba31ca0c0b	chore(internal): refactor: convert tests to testify assert/require part 1 ... refactor: convert tests to testify assert/require in internal/plugin/installer Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>	4 weeks ago
Abhay Chaurasiya	82be04d7f2	remove legacy import comments from remaining packages (#31933) ... Pre-Go-modules import path comments (e.g. `// import "helm.sh/helm/v4/..."`) are obsolete since Go 1.11 where go.mod is the authoritative module path. These stale comments cause issues with downstream tooling such as Kythe. Removes the legacy import comments from 64 files across 20 packages: - cmd/helm - internal/chart/v3/lint and sub-packages - internal/plugin and sub-packages - internal/release/v2/util - pkg/chart/v2/lint and sub-packages - pkg/cmd, pkg/engine, pkg/ignore, pkg/provenance - pkg/registry - pkg/release/v1/util - pkg/repo/v1 - pkg/storage and pkg/storage/driver Follows up on #31931 and #31932 which addressed pkg/kube. Fixes #31846 Signed-off-by: abhay1999 <abhay.chaurasiya@example.com> Signed-off-by: abhay1999 <abhaychaurasiya19@gmail.com>	1 month ago
Matthieu MOREL	a02a5713de	chore: fix elseif and ifElseChain issues from gocritic (#32289) ... * chore: fix elseif and ifElseChain issues from gocritic Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com> * test: enhance assertions in OCIInstaller and list tests using testify Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com> --------- Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>	1 month ago
Matthieu MOREL	07259ecc86	chore: fix several checks issues from gocritic ... Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>	1 month ago
Matthieu MOREL	7edfff33eb	chore: fix unnecessary-format issues from revive ... Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>	5 months ago
Matthieu MOREL	9409226e15	chore(internal): enable perfsprint linter ... #### Description enable perfsprint linter in internal/plugin/installer Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>	6 months ago
Scott Rigby	9ea35da0d0	[HIP-0026] Plugin packaging, signing, and verification (#31176) ... * Plugin packaging, signing and verification Signed-off-by: Scott Rigby <scott@r6by.com> * wrap keyring read error with more explicit message Co-authored-by: Jesse Simpson <jesse.simpson36@gmail.com> Signed-off-by: Scott Rigby <scott@r6by.com> * skip unnecessary check Co-authored-by: Evans Mungai <mbuevans@gmail.com> Signed-off-by: Scott Rigby <scott@r6by.com> * Change behavior for installing plugin with missing .prov file (now warns and continues instead of failing) Signed-off-by: Scott Rigby <scott@r6by.com> * Add comprehensive plugin verification tests - Test missing .prov files (warns but continues) - Test invalid .prov file formats (fails verification) - Test hash mismatches in .prov files (fails verification) - Test .prov file access errors (fails appropriately) - Test directory plugins don't support verification - Test installation without verification enabled (succeeds) - Test with valid .prov files (fails on empty keyring as expected) --------- Signed-off-by: Scott Rigby <scott@r6by.com> Co-authored-by: Jesse Simpson <jesse.simpson36@gmail.com> Co-authored-by: Evans Mungai <mbuevans@gmail.com>	12 months ago
Scott Rigby	7d22bb25fa	Plugin OCI installer ... Signed-off-by: Scott Rigby <scott@r6by.com>	12 months ago