Terry Howe
9c7bf37c6f
fix: Ignore absolute path when RepoUrl is provided
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
Co-authored-by: Mohammad Forutan <mforutan@users.noreply.github.com>
11 months ago
George Jenkins
561a7da61c
Merge pull request #31297 from TerryHowe/fix-hide-notes-in-helm-test
...
fix: hide notes in helm test command
11 months ago
George Jenkins
b5de5b1591
chore: Cleanup additional/redundant kube client Interfaces
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
11 months ago
George Jenkins
f21b143bef
refactor: Replace action 'DryRun' string with DryRunStrategy type + deprecations
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
11 months ago
Matt Farina
d2236e95ed
Merge pull request #31303 from mattfarina/unified-loader
...
Update the action interfaces for chart apiversions
11 months ago
Matt Farina
8dc7c57f50
Update the action interfaces for chart apiversions
...
This change is about handling the interfaces to public functions for
different chart apiVersions. The internals are still focused on v2.
This enables v3 to be layered in layer.
Signed-off-by: Matt Farina <matt.farina@suse.com>
11 months ago
Terry Howe
020a8eccfd
fix: helm verify run signature
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
11 months ago
Matt Farina
da595e0e71
Merge pull request #31293 from TerryHowe/copilot/fix-8
...
chore: remove pkg/time which is no longer needed
11 months ago
Terry Howe
dab4fd2909
fix: hide notes in helm test command
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
11 months ago
Terry Howe
3e1dd9a5dc
chore: remove pkg/time which is no longer needed
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
11 months ago
reddaisyy
1c67fbf108
refactor: use strings.builder
...
Signed-off-by: reddaisyy <reddaisy@outlook.jp>
11 months ago
Evan Anderson
20f4e1f12d
Use filepath.Path when handling directory names
...
Signed-off-by: Evan Anderson <evan.k.anderson@gmail.com>
11 months ago
Scott Rigby
315b13334c
Merge pull request #31258 from StephanieHhnbrg/test-unreachable-client
...
Refactor unreachableKubeClient for testing into failingKubeClient
11 months ago
Stephanie Hohenberg
e19d9fb6ee
Refactor unreachableKubeClient for testing into failingKubeClient
...
Signed-off-by: Stephanie Hohenberg <stephanie.hohenberg@gmail.com>
11 months ago
Scott Rigby
50358d7ffd
Merge pull request #31200 from TerryHowe/fix-install-tests
...
fix: installer action goroutine count
11 months ago
Matt Farina
9dcc49cbd5
Move lint pkg to be part of each chart version
...
Linting is specific to the chart versions. A v2 and v3 chart will
lint differently.
To accomplish this, packages like engine need to be able to handle
different chart versions. This was accomplished by some changes:
1. The introduction of a Charter interface for charts
2. The ChartAccessor which is able to accept a chart and then
provide access to its data via an interface. There is an
interface, factory, and implementation for each version of
chart.
3. Common packages were moved to a common and util packages.
Due to some package loops, there are 2 packages which may
get some consolidation in the future.
The new interfaces provide the foundation to move the actions
and cmd packages to be able to handle multiple apiVersions of
charts.
Signed-off-by: Matt Farina <matt.farina@suse.com>
12 months ago
Matt Farina
52267ee74b
Move repo package to versioned directory
...
The repo package is internally versioned at v1. Repos were designed
to be versioned. This change moves it to a versioned directory the
same way other packages are now being handled.
Signed-off-by: Matt Farina <matt.farina@suse.com>
12 months ago
Matt Farina
6f957f4922
Move the release util to the versioned directory
...
The release util package is directly related to the v1 of
releases and uses the v1 of releases.
Signed-off-by: Matt Farina <matt.farina@suse.com>
12 months ago
Scott Rigby
591d863df5
Move Postrenderer to a plugin type
...
Fix/add back postrenderer args unit tests
Signed-off-by: Scott Rigby <scott@r6by.com>
12 months ago
Scott Rigby
e814ff3c38
Remove unnecessary file i/o operations from signing and verifying
...
Signed-off-by: Scott Rigby <scott@r6by.com>
12 months ago
Scott Rigby
9ea35da0d0
[HIP-0026] Plugin packaging, signing, and verification ( #31176 )
...
* Plugin packaging, signing and verification
Signed-off-by: Scott Rigby <scott@r6by.com>
* wrap keyring read error with more explicit message
Co-authored-by: Jesse Simpson <jesse.simpson36@gmail.com>
Signed-off-by: Scott Rigby <scott@r6by.com>
* skip unnecessary check
Co-authored-by: Evans Mungai <mbuevans@gmail.com>
Signed-off-by: Scott Rigby <scott@r6by.com>
* Change behavior for installing plugin with missing .prov file (now warns and continues instead of failing)
Signed-off-by: Scott Rigby <scott@r6by.com>
* Add comprehensive plugin verification tests
- Test missing .prov files (warns but continues)
- Test invalid .prov file formats (fails verification)
- Test hash mismatches in .prov files (fails verification)
- Test .prov file access errors (fails appropriately)
- Test directory plugins don't support verification
- Test installation without verification enabled (succeeds)
- Test with valid .prov files (fails on empty keyring as expected)
---------
Signed-off-by: Scott Rigby <scott@r6by.com>
Co-authored-by: Jesse Simpson <jesse.simpson36@gmail.com>
Co-authored-by: Evans Mungai <mbuevans@gmail.com>
12 months ago
Terry Howe
b12cd28503
fix: installer action goroutine count
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
12 months ago
George Jenkins
934f761e08
Merge pull request #30812 from gjenkins8/gjenkins/chartrelease_server_side_apply
...
HIP-0023: Helm support server-side apply
12 months ago
Scott Rigby
be74ab72a0
[HIP-0026] Plugin runtime interface ( #31145 )
...
* Runtime abstraction to encapsulate subprocess code and enable future runtimes
Also fix race condition in TestPrepareCommandExtraArgs by replacing the shared variable modification with a local copy
Co-authored-by: George Jenkins <gvjenkins@gmail.com>
Signed-off-by: Scott Rigby <scott@r6by.com>
* Remove commented out code
Co-authored-by: Joe Julian <me@joejulian.name>
Signed-off-by: Scott Rigby <scott@r6by.com>
* Check test failure string
Co-authored-by: Jesse Simpson <jesse.simpson36@gmail.com>
Signed-off-by: Scott Rigby <scott@r6by.com>
---------
Signed-off-by: Scott Rigby <scott@r6by.com>
Co-authored-by: George Jenkins <gvjenkins@gmail.com>
Co-authored-by: Joe Julian <me@joejulian.name>
Co-authored-by: Jesse Simpson <jesse.simpson36@gmail.com>
12 months ago
Matt Farina
0f1b410f14
Merge pull request #31165 from mattfarina/content-cache
...
Initial addition of content based cache
12 months ago
George Jenkins
a0d6b0d383
Merge pull request #13629 from gjenkins8/rename_atomic_rollbackonfailure
...
Rename 'atomic' -> 'rollback-on-failure'
12 months ago
Matt Farina
fea6d8eb04
Updating to tested content cache
...
A few things are added here:
1. The cache is made to be more generic as a content based cache.
It could be used for other things such as plugins
2. Flags were added to specify the content cache locaiton rather
than rely on the repository cache. Keeping the 2 the same
hid bugs and errors.
3. Tests were added and updated to ensure the cache is used and
tested
Signed-off-by: Matt Farina <matt.farina@suse.com>
12 months ago
George Jenkins
ebc874ef84
fix client-side to server-side field manager migration
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
12 months ago
Matt Farina
6ac2c34689
Initial addition of content based cache
...
The previous cache was based on chart name and version. If 2 charts
with different content had the same name and version they would collide.
Helm did not trust the cache because of this and always downloaded
content. It was a short lived cache.
This commit introduces a content based cache which is based on the
content rather than file name. Charts with the same name but different
content are no longer an issue.
While the system assumes a file based interface, the cache system
is pluggable. In the future, it should return bytes for the content
instead of paths to it. That would requie a larger change for Helm 5
or later.
Signed-off-by: Matt Farina <matt.farina@suse.com>
12 months ago
George Jenkins
b4b2392f7e
mergefix
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
1 year ago
George Jenkins
e2dcbe28bf
Helm client/SDK support server-side apply
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
1 year ago
George Jenkins
36e52c828d
Merge pull request #31030 from gjenkins8/gjenkins/kubeclient_ssa
...
HIP-0023: Kube client support server-side apply
1 year ago
joemicky
762ef3ee80
refactor: omit unnecessary reassignment
...
Signed-off-by: joemicky <joemickychang@outlook.com>
1 year ago
Joe Julian
4b493f036c
Merge remote-tracking branch 'upstream/main' into papdaniel/main
1 year ago
George Jenkins
ba53075a9d
Merge pull request #12968 from sjeandeaux/helm-uninstall-dry-run
...
helm uninstall dry run support `--ignore-not-found`
1 year ago
George Jenkins
b2dc411f9d
code review (error checks, collapse forceConflicts, UpdateApplyFunc)
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
1 year ago
George Jenkins
45141451b4
Kube client support server-side apply
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
1 year ago
Stephane Jeandeaux
44a594fef5
review
...
Signed-off-by: Stephane Jeandeaux <stephane.jeandeaux@gmail.com>
1 year ago
Robert Sirchia
c5901abba6
Merge pull request #31050 from spreadshirt/fix-helm-pull-ud-check
...
Fix `helm pull` untar dir check with repo urls
1 year ago
Stephane Jeandeaux
8434935a3d
fix fallthrough
...
Signed-off-by: Stephane Jeandeaux <stephane.jeandeaux@gmail.com>
1 year ago
Stephane Jeandeaux
65209bed54
Update pkg/action/uninstall.go
...
Co-authored-by: Eddy Moulton <eddy@moulton.com.au>
Signed-off-by: Stephane Jeandeaux <sjeandeaux@users.noreply.github.com>
1 year ago
Stephane Jeandeaux
b3568a67a8
helm uninstall
...
The goal is to have the same behaviour with or without dry-run with --ignore-not-found
close #12970
Signed-off-by: Stephane Jeandeaux <stephane.jeandeaux@gmail.com>
1 year ago
Joe Julian
ae0fe82bc3
Merge remote-tracking branch 'upstream/main' into get-values-test
1 year ago
Khwaja Faraz Ahmed
85164e5705
fix lint errors
...
Signed-off-by: Khwaja Faraz Ahmed <khwajafarazahmed@gmail.com>
1 year ago
Khwaja Faraz Ahmed
ded25c1908
Add tests for alias
...
Signed-off-by: Khwaja Faraz Ahmed <khwajafarazahmed@gmail.com>
1 year ago
George Jenkins
93106ba2b6
Merge pull request #30982 from gjenkins8/gjenkins/force_replace_flag
...
Rename 'force' to 'force-replace'
1 year ago
Evans Mungai
85243914a4
feat: switch yaml library to go.yaml.in/yaml/v3
...
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
1 year ago
Khwaja Faraz Ahmed
a37934a892
fix linting issue
...
Signed-off-by: Khwaja Faraz Ahmed <khwaja.ahmed@securiti.ai>
1 year ago
Faraz Khawaja
2d2d4a868d
Fix struct declaration
...
Signed-off-by: Faraz Khawaja <khwajafarazahmed@yahoo.com>
Signed-off-by: Khwaja Faraz Ahmed <khwaja.ahmed@securiti.ai>
1 year ago
George Jenkins
08840f042c
Rename 'atomic' -> 'rollback-on-failure'
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
1 year ago
Luna Stadler
1031b67fff
Fix `helm pull` untar dir check with repo urls
...
The existing check worked for `helm pull downloaded-repo/chart-name`,
but often does not work when using `--repo-url`, depending on the urls
used by the charts.
Signed-off-by: Luna Stadler <luc@spreadshirt.net>
1 year ago
Faraz Khawaja
f75100266b
Resolve conflicts
1 year ago
Robert Sirchia
619035d789
Merge pull request #31057 from danilobuerger/db/thick-lark
...
Pass credentials when either chart repo or repo dont specify a port but it matches the default port of that scheme
1 year ago
Joe Julian
08909e030b
Merge pull request #31019 from zachburg/templates_lint
...
Return early when linting if the `templates/` directory does not exist
1 year ago
Joe Julian
1f3e4ad12a
Merge pull request #31011 from yalosev/feature/add-labels-to-metadata
...
feature: add labels to metadata
1 year ago
George Jenkins
74f2805f01
Rename 'force' to 'force-replace'
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
1 year ago
Danilo Bürger
055c4e2bec
Moved url comparison to own function
...
Signed-off-by: Danilo Bürger <info@danilobuerger.de>
1 year ago
Khwaja Faraz Ahmed
d50d22c970
Add test coverage for get_values/metadata.go
...
Signed-off-by: Khwaja Faraz Ahmed <khwaja.ahmed@securiti.ai>
Signed-off-by: Khwaja Faraz Ahmed <khwajafarazahmed@gmail.com>
1 year ago
Danilo Bürger
8096f09370
Pass credentials when either chart repo or repo dont specify a port but it matches the default port of that scheme
...
Signed-off-by: Danilo Bürger <danilo.buerger@helsing.ai>
1 year ago
Scott Rigby
091f9a24fe
Merge pull request #13154 from carloslima/post-render-everything
...
Allow post-renderer to process hooks
1 year ago
Yuriy Losev
46b1a41631
Add release labels to the release Metadata
...
Signed-off-by: Yuriy Losev <yuriy.losev@flant.com>
1 year ago
Zach Burgess
35434947a3
Return a lint warning if `templates/` does not exist.
...
Signed-off-by: Zach Burgess <zachburg@google.com>
1 year ago
George Jenkins
5283915c57
Remove deprecated '--create-pods' flag
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
1 year ago
Carlos Lima
6991a0a531
Make annotateAndMerge deterministic
...
Signed-off-by: Carlos Lima <carlos@cpan.org>
1 year ago
Carlos Lima
c01e76b5c3
review: change annotation name to postrenderer.helm.sh/postrender-filename
...
Signed-off-by: Carlos Lima <carlos@cpan.org>
1 year ago
Carlos Lima
a1416cf225
review: style changes
...
Signed-off-by: Carlos Lima <carlos@cpan.org>
1 year ago
Carlos Lima
859721bd77
review: rewrite error messages from the end-user perspective
...
Signed-off-by: Carlos Lima <carlos@cpan.org>
1 year ago
Carlos Lima
b26b473bf6
review: make splitAndDeannotate private
...
Signed-off-by: Carlos Lima <carlos@cpan.org>
1 year ago
Carlos Lima
855b5a44b7
review: make annotateAndMerge private
...
Signed-off-by: Carlos Lima <carlos@cpan.org>
1 year ago
Carlos Lima
1d993f9e2d
review: make filenameAnnotation private
...
Signed-off-by: Carlos Lima <carlos@cpan.org>
1 year ago
Carlos Lima
e6362d74c8
Allow post-renderer to process hooks
...
This annotates and merges all manifests before sending to the
postrender, reversing the process and recovering the filenames
afterwards.
closes #7891
Signed-off-by: Carlos Lima <carlos@cpan.org>
1 year ago
acceptacross
9623fb80f1
chore: fix some function names in comment
...
Signed-off-by: acceptacross <csqcqs@gmail.com>
1 year ago
Scott Rigby
069b525332
Merge pull request #13586 from jessesimpson36/cleaner-stacktraces
...
fix: add formatting for errors to make multiline stacktraces in helm templates
1 year ago
Scott Rigby
e2630d1aba
Merge pull request #30939 from TerryHowe/action-hooks-delete-policy-mutex
...
fix: action hooks delete policy mutex
1 year ago
Terry Howe
a8cbf3aa51
fix: action hooks delete policy mutex
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
1 year ago
Matthieu MOREL
56a2bb4188
chore: enable usetesting linter
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
1 year ago
Matthieu MOREL
157f0ba10a
chore: enable thelper
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
1 year ago
yetyear
03448d1d79
refactor: use maps.Copy for cleaner map handling
...
Signed-off-by: yetyear <flite@outlook.com>
1 year ago
findnature
ac8d2f9aed
refactor: use slices.Contains to simplify code
...
Signed-off-by: findnature <cricis@aliyun.com>
1 year ago
Jesse Simpson
0a7dd4b269
test: adjust failing test on extra whitespace
...
Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>
1 year ago
Jesse Simpson
edf0f7be59
test: adjust formatting for error in test
...
Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>
1 year ago
Justen Stall
7a316c8d51
update expected error message in install test
...
Signed-off-by: Justen Stall <39888103+justenstall@users.noreply.github.com>
1 year ago
Justen Stall
3877ec9049
fix golangci-lint issues
...
Signed-off-by: Justen Stall <39888103+justenstall@users.noreply.github.com>
1 year ago
Justen Stall
065e2eb3eb
updates after merge conflict resolution
...
Signed-off-by: Justen Stall <39888103+justenstall@users.noreply.github.com>
1 year ago
Justen Stall
280a9ddbdb
Merge branch 'main' into stdlib-errors-2
...
Signed-off-by: Justen Stall <39888103+justenstall@users.noreply.github.com>
1 year ago
Stepan Paksashvili
5c2f89307d
feat(pkg/engine): and custom funcs to action config
...
Signed-off-by: Stepan Paksashvili <stepan.paksashvili@flant.com>
1 year ago
Stepan Paksashvili
9073bcf53e
feat(pkg/engine): add support for custom template funcs
...
Enhances the template engine and action config to allow users to inject custom template functions via an action config when using Helm as a library.
Closes #30733
Signed-off-by: Stepan Paksashvili <stepan.paksashvili@flant.com>
1 year ago
Scott Rigby
599fad1864
Merge pull request #30697 from p-se/fix-take-ownership
...
Fix --take-ownership for custom resources - closes #30622
1 year ago
Benoit Tigeot
d33e2896f0
Prevent failures with method signatures on hooks
...
changes on wait strategy. This PR try to fix linting and tests.
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
1 year ago
Scott Rigby
e397f44840
Merge pull request #30673 from nvanthao/process-all-hook-deletions-on-failure
...
fix: Process all hook deletions on failure
1 year ago
Robert Sirchia
8733103743
Merge pull request #30718 from klihub/fixes/package/multiple-charts-single-passwd-from-stdin
...
Allow signing multiple charts with a single passphrase from stdin.
1 year ago
Krisztian Litkey
3102c28804
fix: allow signing multiple charts with passphrase from stdin.
...
Cache the signing key passphrase. When signing multiple charts
with the passphrase from stdin, this allows signing all charts
instead of all but the first failing with an error about stdin
already having been closed.
Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>
1 year ago
Evans Mungai
e8e79cc4b4
Merge branch 'main' into fix-take-ownership
...
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
1 year ago
Evans Mungai
7c37a109f2
Add install test for TakeOwnership flag
...
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
1 year ago
Benoit Tigeot
a6d0335bbb
Use fmt.Fprintf(...) instead of ...
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
1 year ago
Benoit Tigeot
a9b7732367
could remove embedded field X from selector
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
1 year ago
Robert Sirchia
f5decfc28d
Merge pull request #30737 from rpolishchuk/investigation-pr-30610
...
fix: order dependent test
1 year ago
Matt Farina
7a1eb77e77
Merge pull request #30708 from benoittgt/migrate-kube-pkg-to-slog
...
Migrate pkg to slog
1 year ago
Matt Farina
7938662f95
Remove ValidName regex
...
This regex was already deprecated.
Validation happens inside the Metadata Validate function for the
name instead of using this regex.
Signed-off-by: Matt Farina <matt.farina@suse.com>
1 year ago
Benoit Tigeot
68440d7b29
Prefer using slog.Any when displaying errors
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
1 year ago