From f5701d0e441ca957867ee5e1fee9cf8682127f4d Mon Sep 17 00:00:00 2001 From: carlory Date: Mon, 18 Sep 2017 19:15:34 +0800 Subject: [PATCH] add test code for UnmarshalChartfile --- pkg/chartutil/chartfile.go | 3 +++ pkg/chartutil/chartfile_test.go | 10 ++++++++++ 2 files changed, 13 insertions(+) diff --git a/pkg/chartutil/chartfile.go b/pkg/chartutil/chartfile.go index 9897d66ff..55847819a 100644 --- a/pkg/chartutil/chartfile.go +++ b/pkg/chartutil/chartfile.go @@ -35,6 +35,9 @@ const ApiVersionV1 = "v1" // UnmarshalChartfile takes raw Chart.yaml data and unmarshals it. func UnmarshalChartfile(data []byte) (*chart.Metadata, error) { + if len(data) == 0 { + return nil, nil + } y := &chart.Metadata{} err := yaml.Unmarshal(data, y) if err != nil { diff --git a/pkg/chartutil/chartfile_test.go b/pkg/chartutil/chartfile_test.go index 5b36dc955..edbbc9ea3 100755 --- a/pkg/chartutil/chartfile_test.go +++ b/pkg/chartutil/chartfile_test.go @@ -24,6 +24,16 @@ import ( const testfile = "testdata/chartfiletest.yaml" +func TestUnmarshalChartfile(t *testing.T) { + metadata, err := UnmarshalChartfile([]byte{}) + if err != nil { + t.Error(err) + } + if err == nil && metadata != nil { + t.Errorf("Want nil, but got %t", metadata) + } +} + func TestLoadChartfile(t *testing.T) { f, err := LoadChartfile(testfile) if err != nil {