From f451967ab5a5a9b1a26deb699bd1a1f4f2ba6b1e Mon Sep 17 00:00:00 2001
From: Manuel Alonso <434575+manute@users.noreply.github.com>
Date: Mon, 22 Dec 2025 19:15:16 +0100
Subject: [PATCH] fix(test): no check empty resources

Signed-off-by: Manuel Alonso <434575+manute@users.noreply.github.com>
(cherry picked from commit 0357e8d0f7eab074252ca49e1ca3aded834a001d)
---
 pkg/action/install.go      |  4 ----
 pkg/action/install_test.go | 16 ++++++++++------
 2 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/pkg/action/install.go b/pkg/action/install.go
index 7a7a672c2..273742bb5 100644
--- a/pkg/action/install.go
+++ b/pkg/action/install.go
@@ -191,10 +191,6 @@ func (i *Install) installCRDs(crds []chart.CRD) error {
 			return fmt.Errorf("failed to install CRD %s: %w", obj.Name, err)
 		}
 
-		if len(res) == 0 {
-			return fmt.Errorf("failed to install CRD %s: resources are empty", obj.Name)
-		}
-
 		// Send them to Kube
 		if _, err := i.cfg.KubeClient.Create(
 			res,
diff --git a/pkg/action/install_test.go b/pkg/action/install_test.go
index ec62aea2f..007462522 100644
--- a/pkg/action/install_test.go
+++ b/pkg/action/install_test.go
@@ -1211,28 +1211,32 @@ func TestInstallRelease_WaitOptionsPassedDownstream(t *testing.T) {
 
 func TestInstallCRDs_CheckNilErrors(t *testing.T) {
 	tests := []struct {
-		name  string
-		input []chart.CRD
+		name        string
+		input       []chart.CRD
+		expectedErr bool
 	}{
 		{
 			name: "only one crd with file nil",
 			input: []chart.CRD{
 				{Name: "one", File: nil},
 			},
+			expectedErr: true,
 		},
 		{
 			name: "only one crd with its file data nil",
 			input: []chart.CRD{
 				{Name: "one", File: &common.File{Name: "crds/foo.yaml", Data: nil}},
 			},
+			expectedErr: false,
 		},
 		{
 			name: "at least a crd with its file data nil",
 			input: []chart.CRD{
 				{Name: "one", File: &common.File{Name: "crds/foo.yaml", Data: []byte("data")}},
-				{Name: "two", File: &common.File{Name: "crds/foo.yaml", Data: nil}},
-				{Name: "three", File: &common.File{Name: "crds/foo.yaml", Data: []byte("data")}},
+				{Name: "two", File: &common.File{Name: "crds/foo2.yaml", Data: nil}},
+				{Name: "three", File: &common.File{Name: "crds/foo3.yaml", Data: []byte("data")}},
 			},
+			expectedErr: false,
 		},
 	}
 
@@ -1241,8 +1245,8 @@ func TestInstallCRDs_CheckNilErrors(t *testing.T) {
 			instAction := installAction(t)
 
 			err := instAction.installCRDs(tt.input)
-			if err == nil {
-				t.Errorf("got error expected nil")
+			if tt.expectedErr && err == nil {
+				t.Errorf("got error %v expected nil", err)
 			}
 		})
 	}