From ad6b4fe2104e78092fa02d8ce7b3ea51f68cb506 Mon Sep 17 00:00:00 2001 From: Guy Bolton King Date: Thu, 20 Jan 2022 11:32:14 +0000 Subject: [PATCH 1/3] Add extra directories to path used in repo_add_test.go Signed-off-by: Guy Bolton King --- cmd/helm/repo_add_test.go | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/cmd/helm/repo_add_test.go b/cmd/helm/repo_add_test.go index c88479ea1..905941033 100644 --- a/cmd/helm/repo_add_test.go +++ b/cmd/helm/repo_add_test.go @@ -48,7 +48,11 @@ func TestRepoAddCmd(t *testing.T) { } defer srv2.Stop() - tmpdir := ensure.TempDir(t) + tmpdir := filepath.Join(ensure.TempDir(t), "path-component/data") + err = os.MkdirAll(tmpdir, 0777) + if err != nil { + t.Fatal(err) + } repoFile := filepath.Join(tmpdir, "repositories.yaml") tests := []cmdTestCase{ From 4367fe0c1e4350187b455e6fc7f54ed989244557 Mon Sep 17 00:00:00 2001 From: Guy Bolton King Date: Thu, 20 Jan 2022 11:33:28 +0000 Subject: [PATCH 2/3] Make repo_add_test.go fail by inserted .yaml into path Signed-off-by: Guy Bolton King --- cmd/helm/repo_add_test.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cmd/helm/repo_add_test.go b/cmd/helm/repo_add_test.go index 905941033..f96fda407 100644 --- a/cmd/helm/repo_add_test.go +++ b/cmd/helm/repo_add_test.go @@ -48,7 +48,7 @@ func TestRepoAddCmd(t *testing.T) { } defer srv2.Stop() - tmpdir := filepath.Join(ensure.TempDir(t), "path-component/data") + tmpdir := filepath.Join(ensure.TempDir(t), "path-component.yaml/data") err = os.MkdirAll(tmpdir, 0777) if err != nil { t.Fatal(err) From 8b1c28427fb77c08aec8f5335faa457175e45b55 Mon Sep 17 00:00:00 2001 From: Guy Bolton King Date: Thu, 20 Jan 2022 11:37:45 +0000 Subject: [PATCH 3/3] Make repo_add.go only replace the last suffix in the path when generating a lockfile Signed-off-by: Guy Bolton King --- cmd/helm/repo_add.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cmd/helm/repo_add.go b/cmd/helm/repo_add.go index 8844174be..fa945e739 100644 --- a/cmd/helm/repo_add.go +++ b/cmd/helm/repo_add.go @@ -119,7 +119,7 @@ func (o *repoAddOptions) run(out io.Writer) error { repoFileExt := filepath.Ext(o.repoFile) var lockPath string if len(repoFileExt) > 0 && len(repoFileExt) < len(o.repoFile) { - lockPath = strings.Replace(o.repoFile, repoFileExt, ".lock", 1) + lockPath = strings.TrimSuffix(o.repoFile, repoFileExt) + ".lock" } else { lockPath = o.repoFile + ".lock" }