From f0fd37d2c50f947ce056e14372a3952e83251b04 Mon Sep 17 00:00:00 2001 From: Martin Hickey Date: Tue, 18 Jan 2022 15:56:31 +0000 Subject: [PATCH] Replace golint with revive golint which is used as one of the sublinters in golangci-lint is deprecated. It is replaced with revive which is a drop-in replacement. Signed-off-by: Martin Hickey Co-authored-by: Martin Mulholland --- .circleci/config.yml | 2 +- .golangci.yml | 2 +- cmd/helm/completion_test.go | 4 ++-- cmd/helm/load_plugins.go | 2 +- cmd/helm/repo_update.go | 4 ++-- pkg/chartutil/validate_name.go | 8 ++++---- pkg/cli/environment_test.go | 36 +++++++++++++++++----------------- pkg/registry/client.go | 18 +++++++---------- pkg/uploader/chart_uploader.go | 2 +- 9 files changed, 37 insertions(+), 41 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index f3599607b..7a9c4874d 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -13,7 +13,7 @@ jobs: environment: GOCACHE: "/tmp/go/cache" - GOLANGCI_LINT_VERSION: "1.36.0" + GOLANGCI_LINT_VERSION: "1.43.0" steps: - checkout diff --git a/.golangci.yml b/.golangci.yml index 5c2445711..2807ede34 100644 --- a/.golangci.yml +++ b/.golangci.yml @@ -8,12 +8,12 @@ linters: - dupl - gofmt - goimports - - golint - gosimple - govet - ineffassign - misspell - nakedret + - revive - structcheck - unused - varcheck diff --git a/cmd/helm/completion_test.go b/cmd/helm/completion_test.go index 6d53616d0..1143d6445 100644 --- a/cmd/helm/completion_test.go +++ b/cmd/helm/completion_test.go @@ -47,10 +47,10 @@ func checkFileCompletion(t *testing.T, cmdName string, shouldBePerformed bool) { } if !strings.Contains(out, "ShellCompDirectiveNoFileComp") != shouldBePerformed { if shouldBePerformed { - t.Error(fmt.Sprintf("Unexpected directive ShellCompDirectiveNoFileComp when completing '%s'", cmdName)) + t.Errorf("Unexpected directive ShellCompDirectiveNoFileComp when completing '%s'", cmdName) } else { - t.Error(fmt.Sprintf("Did not receive directive ShellCompDirectiveNoFileComp when completing '%s'", cmdName)) + t.Errorf("Did not receive directive ShellCompDirectiveNoFileComp when completing '%s'", cmdName) } t.Log(out) } diff --git a/cmd/helm/load_plugins.go b/cmd/helm/load_plugins.go index 70002b0b0..a97d49a93 100644 --- a/cmd/helm/load_plugins.go +++ b/cmd/helm/load_plugins.go @@ -313,7 +313,7 @@ func loadFile(path string) (*pluginCommand, error) { cmds := new(pluginCommand) b, err := ioutil.ReadFile(path) if err != nil { - return cmds, errors.New(fmt.Sprintf("File (%s) not provided by plugin. No plugin auto-completion possible.", path)) + return cmds, fmt.Errorf("file (%s) not provided by plugin. No plugin auto-completion possible", path) } err = yaml.Unmarshal(b, cmds) diff --git a/cmd/helm/repo_update.go b/cmd/helm/repo_update.go index ae09f9195..27661674c 100644 --- a/cmd/helm/repo_update.go +++ b/cmd/helm/repo_update.go @@ -133,8 +133,8 @@ func updateCharts(repos []*repo.ChartRepository, out io.Writer, failOnRepoUpdate wg.Wait() if len(repoFailList) > 0 && failOnRepoUpdateFail { - return errors.New(fmt.Sprintf("Failed to update the following repositories: %s", - repoFailList)) + return fmt.Errorf("Failed to update the following repositories: %s", + repoFailList) } fmt.Fprintln(out, "Update Complete. ⎈Happy Helming!⎈") diff --git a/pkg/chartutil/validate_name.go b/pkg/chartutil/validate_name.go index 8c45d533b..05c090cb6 100644 --- a/pkg/chartutil/validate_name.go +++ b/pkg/chartutil/validate_name.go @@ -40,15 +40,15 @@ var ( errMissingName = errors.New("no name provided") // errInvalidName indicates that an invalid release name was provided - errInvalidName = errors.New(fmt.Sprintf( + errInvalidName = fmt.Errorf( "invalid release name, must match regex %s and the length must not be longer than 53", - validName.String())) + validName.String()) // errInvalidKubernetesName indicates that the name does not meet the Kubernetes // restrictions on metadata names. - errInvalidKubernetesName = errors.New(fmt.Sprintf( + errInvalidKubernetesName = fmt.Errorf( "invalid metadata name, must match regex %s and the length must not be longer than 253", - validName.String())) + validName.String()) ) const ( diff --git a/pkg/cli/environment_test.go b/pkg/cli/environment_test.go index 1c3dc815e..b113d0961 100644 --- a/pkg/cli/environment_test.go +++ b/pkg/cli/environment_test.go @@ -51,9 +51,9 @@ func TestEnvSettings(t *testing.T) { ns, kcontext string debug bool maxhistory int - kAsUser string - kAsGroups []string - kCaFile string + asUser string + asGroups []string + caFile string }{ { name: "defaults", @@ -66,9 +66,9 @@ func TestEnvSettings(t *testing.T) { ns: "myns", debug: true, maxhistory: defaultMaxHistory, - kAsUser: "poro", - kAsGroups: []string{"admins", "teatime", "snackeaters"}, - kCaFile: "/tmp/ca.crt", + asUser: "poro", + asGroups: []string{"admins", "teatime", "snackeaters"}, + caFile: "/tmp/ca.crt", }, { name: "with envvars set", @@ -76,9 +76,9 @@ func TestEnvSettings(t *testing.T) { ns: "yourns", maxhistory: 5, debug: true, - kAsUser: "pikachu", - kAsGroups: []string{"operators", "snackeaters", "partyanimals"}, - kCaFile: "/tmp/ca.crt", + asUser: "pikachu", + asGroups: []string{"operators", "snackeaters", "partyanimals"}, + caFile: "/tmp/ca.crt", }, { name: "with flags and envvars set", @@ -87,9 +87,9 @@ func TestEnvSettings(t *testing.T) { ns: "myns", debug: true, maxhistory: 5, - kAsUser: "poro", - kAsGroups: []string{"admins", "teatime", "snackeaters"}, - kCaFile: "/my/ca.crt", + asUser: "poro", + asGroups: []string{"admins", "teatime", "snackeaters"}, + caFile: "/my/ca.crt", }, } @@ -119,14 +119,14 @@ func TestEnvSettings(t *testing.T) { if settings.MaxHistory != tt.maxhistory { t.Errorf("expected maxHistory %d, got %d", tt.maxhistory, settings.MaxHistory) } - if tt.kAsUser != settings.KubeAsUser { - t.Errorf("expected kAsUser %q, got %q", tt.kAsUser, settings.KubeAsUser) + if tt.asUser != settings.KubeAsUser { + t.Errorf("expected kAsUser %q, got %q", tt.asUser, settings.KubeAsUser) } - if !reflect.DeepEqual(tt.kAsGroups, settings.KubeAsGroups) { - t.Errorf("expected kAsGroups %+v, got %+v", len(tt.kAsGroups), len(settings.KubeAsGroups)) + if !reflect.DeepEqual(tt.asGroups, settings.KubeAsGroups) { + t.Errorf("expected kAsGroups %+v, got %+v", len(tt.asGroups), len(settings.KubeAsGroups)) } - if tt.kCaFile != settings.KubeCaFile { - t.Errorf("expected kCaFile %q, got %q", tt.kCaFile, settings.KubeCaFile) + if tt.caFile != settings.KubeCaFile { + t.Errorf("expected kCaFile %q, got %q", tt.caFile, settings.KubeCaFile) } }) } diff --git a/pkg/registry/client.go b/pkg/registry/client.go index 213a9dc49..26aae46a4 100644 --- a/pkg/registry/client.go +++ b/pkg/registry/client.go @@ -296,9 +296,8 @@ func (c *Client) Pull(ref string, options ...PullOption) (*PullResult, error) { numDescriptors := len(descriptors) if numDescriptors < minNumDescriptors { - return nil, errors.New( - fmt.Sprintf("manifest does not contain minimum number of descriptors (%d), descriptors found: %d", - minNumDescriptors, numDescriptors)) + return nil, fmt.Errorf("manifest does not contain minimum number of descriptors (%d), descriptors found: %d", + minNumDescriptors, numDescriptors) } var configDescriptor *ocispec.Descriptor var chartDescriptor *ocispec.Descriptor @@ -318,22 +317,19 @@ func (c *Client) Pull(ref string, options ...PullOption) (*PullResult, error) { } } if configDescriptor == nil { - return nil, errors.New( - fmt.Sprintf("could not load config with mediatype %s", ConfigMediaType)) + return nil, fmt.Errorf("could not load config with mediatype %s", ConfigMediaType) } if operation.withChart && chartDescriptor == nil { - return nil, errors.New( - fmt.Sprintf("manifest does not contain a layer with mediatype %s", - ChartLayerMediaType)) + return nil, fmt.Errorf("manifest does not contain a layer with mediatype %s", + ChartLayerMediaType) } var provMissing bool if operation.withProv && provDescriptor == nil { if operation.ignoreMissingProv { provMissing = true } else { - return nil, errors.New( - fmt.Sprintf("manifest does not contain a layer with mediatype %s", - ProvLayerMediaType)) + return nil, fmt.Errorf("manifest does not contain a layer with mediatype %s", + ProvLayerMediaType) } } result := &PullResult{ diff --git a/pkg/uploader/chart_uploader.go b/pkg/uploader/chart_uploader.go index 2aa04937a..d7e940406 100644 --- a/pkg/uploader/chart_uploader.go +++ b/pkg/uploader/chart_uploader.go @@ -46,7 +46,7 @@ func (c *ChartUploader) UploadTo(ref, remote string) error { } if u.Scheme == "" { - return errors.New(fmt.Sprintf("scheme prefix missing from remote (e.g. \"%s://\")", registry.OCIScheme)) + return fmt.Errorf("scheme prefix missing from remote (e.g. \"%s://\")", registry.OCIScheme) } p, err := c.Pushers.ByScheme(u.Scheme)