From efecbf14ccae6a524f676df923c4a4bb79ebbe0e Mon Sep 17 00:00:00 2001 From: Amir Saeid Date: Tue, 5 Jun 2018 10:45:04 +0100 Subject: [PATCH] Replace ioutil.WriteFile with File.Write This would eliminate the need to comment the need to Chmod. However, we need to Close the file manually now since ioutil.WriteFile does it internally. --- pkg/downloader/chart_downloader.go | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/pkg/downloader/chart_downloader.go b/pkg/downloader/chart_downloader.go index be42c3bf9..62553faa1 100644 --- a/pkg/downloader/chart_downloader.go +++ b/pkg/downloader/chart_downloader.go @@ -111,8 +111,10 @@ func (c *ChartDownloader) DownloadTo(ref, version, dest string) (string, *proven } tmpfilename := tmpfile.Name() - // 0644 here is ineffective since TempFile creates files with 0600 permission. We'll chmod it later. - if err := ioutil.WriteFile(tmpfilename, data.Bytes(), 0644); err != nil { + if _, err := tmpfile.Write(data.Bytes()); err != nil { + return tmpfilename, nil, err + } + if err := tmpfile.Close(); err != nil { return tmpfilename, nil, err }