diff --git a/cmd/helm/repo.go b/cmd/helm/repo.go index cc89a4825..d02cee163 100644 --- a/cmd/helm/repo.go +++ b/cmd/helm/repo.go @@ -44,7 +44,7 @@ var repoCmd = &cobra.Command{ } type addCmd struct { - update bool + noupdate bool } func repoAddCmd() *cobra.Command { @@ -59,25 +59,25 @@ func repoAddCmd() *cobra.Command { name, url := args[0], args[1] var err error - if add.update { - err = updateRepository(name, url) - } else { + if add.noupdate { err = addRepository(name, url) + } else { + err = updateRepository(name, url) } if err != nil { return err } - if add.update { - fmt.Println(name + " has been updated") - } else { + if add.noupdate { fmt.Println(name + " has been added to your repositories") + } else { + fmt.Println(name + " has been updated") } return nil }, } f := cmd.Flags() - f.BoolVarP(&add.update, "update", "u", false, "update old url if it exists") + f.BoolVar(&add.noupdate, "no-update", false, "raise error if repo is already registered") return cmd } diff --git a/cmd/helm/repo_test.go b/cmd/helm/repo_test.go index 124914a3a..5792a7115 100644 --- a/cmd/helm/repo_test.go +++ b/cmd/helm/repo_test.go @@ -61,12 +61,12 @@ func TestRepoAdd(t *testing.T) { t.Errorf("%s was not successfully inserted into %s", testName, repositoriesFile()) } - if err := insertRepoLine(testName, ts.URL); err == nil { - t.Errorf("Duplicate repository name was added") + if err := updateRepository(testName, ts.URL); err != nil { + t.Errorf("Repository was not updated: %s", err) } - if err := updateRepository(testName, testURL); err == nil { - t.Errorf("Repository was not updated: %s", err) + if err := insertRepoLine(testName, ts.URL); err == nil { + t.Errorf("Duplicate repository name was added") } }