From ecd531657778daf3fde3777e39fbf628fa9eb4a6 Mon Sep 17 00:00:00 2001 From: Austin Abro Date: Tue, 18 Feb 2025 13:50:04 +0000 Subject: [PATCH] lint Signed-off-by: Austin Abro --- cmd/helm/install.go | 2 +- pkg/kube/fake/fake.go | 2 +- pkg/kube/statuswait.go | 6 +++--- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/cmd/helm/install.go b/cmd/helm/install.go index 649c5c8b8..4d72be966 100644 --- a/cmd/helm/install.go +++ b/cmd/helm/install.go @@ -190,7 +190,7 @@ func addInstallFlags(cmd *cobra.Command, f *pflag.FlagSet, client *action.Instal f.BoolVar(&client.Force, "force", false, "force resource updates through a replacement strategy") f.BoolVar(&client.DisableHooks, "no-hooks", false, "prevent hooks from running during install") f.BoolVar(&client.Replace, "replace", false, "reuse the given name, only if that name is a deleted release which remains in the history. This is unsafe in production") - f.DurationVar(&client.Timeout, "timeout", 300*time.Second, "time to wait for any individual Kubernetes operation (like Jobs for hooks)") + f.DurationVar(&client.Timeout, "timeout", 300*time.Second, "time to wait for any individual Kubernetes operation (like Jobs for hooks)") f.BoolVar(&client.WaitForJobs, "wait-for-jobs", false, "if set and --wait enabled, will wait until all Jobs have been completed before marking the release as successful. It will wait for as long as --timeout") f.BoolVarP(&client.GenerateName, "generate-name", "g", false, "generate the name (and omit the NAME parameter)") f.StringVar(&client.NameTemplate, "name-template", "", "specify template used to name the release") diff --git a/pkg/kube/fake/fake.go b/pkg/kube/fake/fake.go index 087fa89cb..c4322733a 100644 --- a/pkg/kube/fake/fake.go +++ b/pkg/kube/fake/fake.go @@ -140,7 +140,7 @@ func (f *FailingKubeClient) DeleteWithPropagationPolicy(resources kube.ResourceL return f.PrintingKubeClient.DeleteWithPropagationPolicy(resources, policy) } -func (f *FailingKubeClient) SetWaiter(ws kube.WaitStrategy) error { +func (f *FailingKubeClient) SetWaiter(_ kube.WaitStrategy) error { return nil } diff --git a/pkg/kube/statuswait.go b/pkg/kube/statuswait.go index 4a0dcd0d2..3c1e90a36 100644 --- a/pkg/kube/statuswait.go +++ b/pkg/kube/statuswait.go @@ -218,14 +218,14 @@ func (w *hookOnlyWaiter) WatchUntilReady(resourceList ResourceList, timeout time return w.sw.WatchUntilReady(resourceList, timeout) } -func (w *hookOnlyWaiter) Wait(resourceList ResourceList, timeout time.Duration) error { +func (w *hookOnlyWaiter) Wait(_ ResourceList, _ time.Duration) error { return nil } -func (w *hookOnlyWaiter) WaitWithJobs(resourceList ResourceList, timeout time.Duration) error { +func (w *hookOnlyWaiter) WaitWithJobs(_ ResourceList, _ time.Duration) error { return nil } -func (w *hookOnlyWaiter) WaitForDelete(resourceList ResourceList, timeout time.Duration) error { +func (w *hookOnlyWaiter) WaitForDelete(_ ResourceList, _ time.Duration) error { return nil }