From e8dfb29dd8bf13db55d2d7b8d33053fb52bb7517 Mon Sep 17 00:00:00 2001 From: Thomas O'Donnell Date: Thu, 15 Nov 2018 16:34:37 -0800 Subject: [PATCH] Apply suggestions from code review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-Authored-By: helgi <70530+helgi@users.noreply.github.com> Signed-off-by: Helgi Þorbjörnsson --- pkg/engine/engine.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkg/engine/engine.go b/pkg/engine/engine.go index 118733b6c..f3dd869c9 100644 --- a/pkg/engine/engine.go +++ b/pkg/engine/engine.go @@ -159,7 +159,7 @@ func (e *Engine) alterFuncMap(t *template.Template, referenceTpls map[string]ren if e.LintMode { // Don't fail on missing required values when linting log.Printf("[INFO] Missing required value: %s", warn) - return val, nil + return "", nil } // Convert nil to "" in case required is piped into other functions return "", fmt.Errorf(warn)