mirror of https://github.com/helm/helm
liuming
5 years ago
commit
e7adc4b5d7
@ -0,0 +1,82 @@
|
||||
/*
|
||||
Copyright The Helm Authors.
|
||||
|
||||
Licensed under the Apache License, Version 2.0 (the "License");
|
||||
you may not use this file except in compliance with the License.
|
||||
You may obtain a copy of the License at
|
||||
|
||||
http://www.apache.org/licenses/LICENSE-2.0
|
||||
|
||||
Unless required by applicable law or agreed to in writing, software
|
||||
distributed under the License is distributed on an "AS IS" BASIS,
|
||||
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
||||
See the License for the specific language governing permissions and
|
||||
limitations under the License.
|
||||
*/
|
||||
|
||||
package main
|
||||
|
||||
import (
|
||||
"fmt"
|
||||
"path/filepath"
|
||||
"strings"
|
||||
"testing"
|
||||
|
||||
"helm.sh/helm/v3/pkg/repo/repotest"
|
||||
)
|
||||
|
||||
func TestShowPreReleaseChart(t *testing.T) {
|
||||
srv, err := repotest.NewTempServer("testdata/testcharts/*.tgz*")
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
defer srv.Stop()
|
||||
|
||||
if err := srv.LinkIndices(); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
|
||||
tests := []struct {
|
||||
name string
|
||||
args string
|
||||
flags string
|
||||
fail bool
|
||||
expectedErr string
|
||||
}{
|
||||
{
|
||||
name: "show pre-release chart",
|
||||
args: "test/pre-release-chart",
|
||||
fail: true,
|
||||
expectedErr: "failed to download \"test/pre-release-chart\"",
|
||||
},
|
||||
{
|
||||
name: "show pre-release chart with 'devel' flag",
|
||||
args: "test/pre-release-chart",
|
||||
flags: "--devel",
|
||||
fail: false,
|
||||
},
|
||||
}
|
||||
|
||||
for _, tt := range tests {
|
||||
t.Run(tt.name, func(t *testing.T) {
|
||||
outdir := srv.Root()
|
||||
cmd := fmt.Sprintf("show all '%s' %s --repository-config %s --repository-cache %s",
|
||||
tt.args,
|
||||
tt.flags,
|
||||
filepath.Join(outdir, "repositories.yaml"),
|
||||
outdir,
|
||||
)
|
||||
//_, out, err := executeActionCommand(cmd)
|
||||
_, _, err := executeActionCommand(cmd)
|
||||
if err != nil {
|
||||
if tt.fail {
|
||||
if !strings.Contains(err.Error(), tt.expectedErr) {
|
||||
t.Errorf("%q expected error: %s, got: %s", tt.name, tt.expectedErr, err.Error())
|
||||
}
|
||||
return
|
||||
}
|
||||
t.Errorf("%q reported error: %s", tt.name, err)
|
||||
}
|
||||
})
|
||||
}
|
||||
}
|
||||
@ -0,0 +1 @@
|
||||
["hummingbird","iguana","rocket","starlord"]
|
||||
@ -0,0 +1,4 @@
|
||||
- hummingbird
|
||||
- iguana
|
||||
- rocket
|
||||
- starlord
|
||||
@ -0,0 +1,123 @@
|
||||
/*
|
||||
Copyright The Helm Authors.
|
||||
|
||||
Licensed under the Apache License, Version 2.0 (the "License");
|
||||
you may not use this file except in compliance with the License.
|
||||
You may obtain a copy of the License at
|
||||
|
||||
http://www.apache.org/licenses/LICENSE-2.0
|
||||
|
||||
Unless required by applicable law or agreed to in writing, software
|
||||
distributed under the License is distributed on an "AS IS" BASIS,
|
||||
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
||||
See the License for the specific language governing permissions and
|
||||
limitations under the License.
|
||||
*/
|
||||
|
||||
package action
|
||||
|
||||
import (
|
||||
"testing"
|
||||
|
||||
"helm.sh/helm/v3/pkg/kube"
|
||||
|
||||
appsv1 "k8s.io/api/apps/v1"
|
||||
|
||||
"github.com/stretchr/testify/assert"
|
||||
"k8s.io/apimachinery/pkg/api/meta"
|
||||
v1 "k8s.io/apimachinery/pkg/apis/meta/v1"
|
||||
"k8s.io/apimachinery/pkg/runtime/schema"
|
||||
"k8s.io/cli-runtime/pkg/resource"
|
||||
)
|
||||
|
||||
func newDeploymentResource(name, namespace string) *resource.Info {
|
||||
return &resource.Info{
|
||||
Name: name,
|
||||
Mapping: &meta.RESTMapping{
|
||||
Resource: schema.GroupVersionResource{Group: "apps", Version: "v1", Resource: "deployment"},
|
||||
GroupVersionKind: schema.GroupVersionKind{Group: "apps", Version: "v1", Kind: "Deployment"},
|
||||
},
|
||||
Object: &appsv1.Deployment{
|
||||
ObjectMeta: v1.ObjectMeta{
|
||||
Name: name,
|
||||
Namespace: namespace,
|
||||
},
|
||||
},
|
||||
}
|
||||
}
|
||||
|
||||
func TestCheckOwnership(t *testing.T) {
|
||||
deployFoo := newDeploymentResource("foo", "ns-a")
|
||||
|
||||
// Verify that a resource that lacks labels/annotations is not owned
|
||||
err := checkOwnership(deployFoo.Object, "rel-a", "ns-a")
|
||||
assert.EqualError(t, err, `invalid ownership metadata; label validation error: missing key "app.kubernetes.io/managed-by": must be set to "Helm"; annotation validation error: missing key "meta.helm.sh/release-name": must be set to "rel-a"; annotation validation error: missing key "meta.helm.sh/release-namespace": must be set to "ns-a"`)
|
||||
|
||||
// Set managed by label and verify annotation error message
|
||||
_ = accessor.SetLabels(deployFoo.Object, map[string]string{
|
||||
appManagedByLabel: appManagedByHelm,
|
||||
})
|
||||
err = checkOwnership(deployFoo.Object, "rel-a", "ns-a")
|
||||
assert.EqualError(t, err, `invalid ownership metadata; annotation validation error: missing key "meta.helm.sh/release-name": must be set to "rel-a"; annotation validation error: missing key "meta.helm.sh/release-namespace": must be set to "ns-a"`)
|
||||
|
||||
// Set only the release name annotation and verify missing release namespace error message
|
||||
_ = accessor.SetAnnotations(deployFoo.Object, map[string]string{
|
||||
helmReleaseNameAnnotation: "rel-a",
|
||||
})
|
||||
err = checkOwnership(deployFoo.Object, "rel-a", "ns-a")
|
||||
assert.EqualError(t, err, `invalid ownership metadata; annotation validation error: missing key "meta.helm.sh/release-namespace": must be set to "ns-a"`)
|
||||
|
||||
// Set both release name and namespace annotations and verify no ownership errors
|
||||
_ = accessor.SetAnnotations(deployFoo.Object, map[string]string{
|
||||
helmReleaseNameAnnotation: "rel-a",
|
||||
helmReleaseNamespaceAnnotation: "ns-a",
|
||||
})
|
||||
err = checkOwnership(deployFoo.Object, "rel-a", "ns-a")
|
||||
assert.NoError(t, err)
|
||||
|
||||
// Verify ownership error for wrong release name
|
||||
err = checkOwnership(deployFoo.Object, "rel-b", "ns-a")
|
||||
assert.EqualError(t, err, `invalid ownership metadata; annotation validation error: key "meta.helm.sh/release-name" must equal "rel-b": current value is "rel-a"`)
|
||||
|
||||
// Verify ownership error for wrong release namespace
|
||||
err = checkOwnership(deployFoo.Object, "rel-a", "ns-b")
|
||||
assert.EqualError(t, err, `invalid ownership metadata; annotation validation error: key "meta.helm.sh/release-namespace" must equal "ns-b": current value is "ns-a"`)
|
||||
|
||||
// Verify ownership error for wrong manager label
|
||||
_ = accessor.SetLabels(deployFoo.Object, map[string]string{
|
||||
appManagedByLabel: "helm",
|
||||
})
|
||||
err = checkOwnership(deployFoo.Object, "rel-a", "ns-a")
|
||||
assert.EqualError(t, err, `invalid ownership metadata; label validation error: key "app.kubernetes.io/managed-by" must equal "Helm": current value is "helm"`)
|
||||
}
|
||||
|
||||
func TestSetMetadataVisitor(t *testing.T) {
|
||||
var (
|
||||
err error
|
||||
deployFoo = newDeploymentResource("foo", "ns-a")
|
||||
deployBar = newDeploymentResource("bar", "ns-a-system")
|
||||
resources = kube.ResourceList{deployFoo, deployBar}
|
||||
)
|
||||
|
||||
// Set release tracking metadata and verify no error
|
||||
err = resources.Visit(setMetadataVisitor("rel-a", "ns-a", true))
|
||||
assert.NoError(t, err)
|
||||
|
||||
// Verify that release "b" cannot take ownership of "a"
|
||||
err = resources.Visit(setMetadataVisitor("rel-b", "ns-a", false))
|
||||
assert.Error(t, err)
|
||||
|
||||
// Force release "b" to take ownership
|
||||
err = resources.Visit(setMetadataVisitor("rel-b", "ns-a", true))
|
||||
assert.NoError(t, err)
|
||||
|
||||
// Check that there is now no ownership error when setting metadata without force
|
||||
err = resources.Visit(setMetadataVisitor("rel-b", "ns-a", false))
|
||||
assert.NoError(t, err)
|
||||
|
||||
// Add a new resource that is missing ownership metadata and verify error
|
||||
resources.Append(newDeploymentResource("baz", "default"))
|
||||
err = resources.Visit(setMetadataVisitor("rel-b", "ns-a", false))
|
||||
assert.Error(t, err)
|
||||
assert.Contains(t, err.Error(), `Deployment "baz" in namespace "" cannot be owned`)
|
||||
}
|
||||
@ -0,0 +1,37 @@
|
||||
/*
|
||||
Copyright The Helm Authors.
|
||||
|
||||
Licensed under the Apache License, Version 2.0 (the "License");
|
||||
you may not use this file except in compliance with the License.
|
||||
You may obtain a copy of the License at
|
||||
|
||||
http://www.apache.org/licenses/LICENSE-2.0
|
||||
|
||||
Unless required by applicable law or agreed to in writing, software
|
||||
distributed under the License is distributed on an "AS IS" BASIS,
|
||||
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
||||
See the License for the specific language governing permissions and
|
||||
limitations under the License.
|
||||
*/
|
||||
|
||||
package rules
|
||||
|
||||
import (
|
||||
"os"
|
||||
"path/filepath"
|
||||
"testing"
|
||||
)
|
||||
|
||||
var (
|
||||
nonExistingValuesFilePath = filepath.Join("/fake/dir", "values.yaml")
|
||||
)
|
||||
|
||||
func TestValidateValuesYamlNotDirectory(t *testing.T) {
|
||||
_ = os.Mkdir(nonExistingValuesFilePath, os.ModePerm)
|
||||
defer os.Remove(nonExistingValuesFilePath)
|
||||
|
||||
err := validateValuesFileExistence(nonExistingValuesFilePath)
|
||||
if err == nil {
|
||||
t.Errorf("validateValuesFileExistence to return a linter error, got no error")
|
||||
}
|
||||
}
|
||||
Loading…
Reference in new issue