From e77a0f938fac9ef66d057cc92f5876282decc7b3 Mon Sep 17 00:00:00 2001 From: silenceshell Date: Thu, 30 Nov 2017 23:41:19 +0800 Subject: [PATCH] feat(helm): sort resources output by 'helm status'. use a slice to store keys of the resources map and sort the slice to print the map later. Closes #3127 --- pkg/kube/client.go | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/pkg/kube/client.go b/pkg/kube/client.go index 798434da4..253371e21 100644 --- a/pkg/kube/client.go +++ b/pkg/kube/client.go @@ -23,6 +23,7 @@ import ( "fmt" "io" "log" + "sort" "strings" "time" @@ -202,7 +203,15 @@ func (c *Client) Get(namespace string, reader io.Reader) (string, error) { // track of tab widths. buf := new(bytes.Buffer) p, _ := c.Printer(nil, printers.PrintOptions{}) - for t, ot := range objs { + + objsKeys := make([]string, 0, len(objs)) + for key := range objs { + objsKeys = append(objsKeys, key) + } + sort.Strings(objsKeys) + + for _, t := range objsKeys { + ot := objs[t] if _, err = buf.WriteString("==> " + t + "\n"); err != nil { return "", err }