From e572f9454afd2598c20a16250aa03dea31e8ab19 Mon Sep 17 00:00:00 2001 From: Robert James Hernandez Date: Fri, 7 Sep 2018 17:44:53 -0700 Subject: [PATCH] fix(helm): ignore short flag when sha is empty Signed-off-by: Robert James Hernandez --- cmd/helm/version.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cmd/helm/version.go b/cmd/helm/version.go index 922e744b2..fcbe743f5 100644 --- a/cmd/helm/version.go +++ b/cmd/helm/version.go @@ -144,7 +144,7 @@ func getK8sVersion() (*apiVersion.Info, error) { } func formatVersion(v *pb.Version, short bool) string { - if short { + if short && v.GitCommit != "" { return fmt.Sprintf("%s+g%s", v.SemVer, v.GitCommit[:7]) } return fmt.Sprintf("%#v", v)