From e55162daaa48845e553d3df6901404a197846988 Mon Sep 17 00:00:00 2001 From: Mukul Date: Sat, 8 Aug 2026 10:18:45 +0530 Subject: [PATCH] Use ExecContext for the SQL driver's statements Importing database/sql for the sql.ErrNoRows check lets the noctx linter resolve the sqlx receivers, which surfaced the existing plain Exec calls in this file. Exec is defined as ExecContext with context.Background(), so this is behaviour-preserving and keeps the golangci-lint job green. Signed-off-by: Mukul --- pkg/storage/driver/sql.go | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/pkg/storage/driver/sql.go b/pkg/storage/driver/sql.go index ec3566851..93739badb 100644 --- a/pkg/storage/driver/sql.go +++ b/pkg/storage/driver/sql.go @@ -17,6 +17,7 @@ limitations under the License. package driver import ( + "context" "database/sql" "errors" "fmt" @@ -525,7 +526,7 @@ func (s *SQL) Create(key string, rel release.Releaser) error { return err } - if _, err := transaction.Exec(insertQuery, args...); err != nil { + if _, err := transaction.ExecContext(context.Background(), insertQuery, args...); err != nil { // The failed statement leaves the transaction in an aborted state - // PostgreSQL rejects every subsequent statement on it with "current // transaction is aborted" - so roll it back before checking whether the @@ -577,7 +578,7 @@ func (s *SQL) Create(key string, rel release.Releaser) error { return err } - if _, err := transaction.Exec(insertLabelsQuery, args...); err != nil { + if _, err := transaction.ExecContext(context.Background(), insertLabelsQuery, args...); err != nil { defer transaction.Rollback() s.Logger().Debug("failed to write Labels", slog.Any("error", err)) return err @@ -622,7 +623,7 @@ func (s *SQL) Update(key string, rel release.Releaser) error { return err } - if _, err := s.db.Exec(query, args...); err != nil { + if _, err := s.db.ExecContext(context.Background(), query, args...); err != nil { s.Logger().Debug("failed to update release in SQL database", slog.String("key", key), slog.Any("error", err)) return err } @@ -678,7 +679,7 @@ func (s *SQL) Delete(key string) (release.Releaser, error) { return nil, err } - _, err = transaction.Exec(deleteQuery, args...) + _, err = transaction.ExecContext(context.Background(), deleteQuery, args...) if err != nil { s.Logger().Debug("failed perform delete query", slog.Any("error", err)) return release, err @@ -702,7 +703,7 @@ func (s *SQL) Delete(key string) (release.Releaser, error) { s.Logger().Debug("failed to build delete Labels query", slog.Any("error", err)) return nil, err } - _, err = transaction.Exec(deleteCustomLabelsQuery, args...) + _, err = transaction.ExecContext(context.Background(), deleteCustomLabelsQuery, args...) return release, err }