From e4c88faeff8b3b5752a49dbb1e3bd54306462d55 Mon Sep 17 00:00:00 2001 From: Zach Burgess Date: Fri, 27 Jun 2025 11:54:39 -0700 Subject: [PATCH] Update test assertions Signed-off-by: Zach Burgess --- .../output/lint-chart-with-bad-subcharts-with-subcharts.txt | 2 ++ pkg/cmd/testdata/output/lint-chart-with-bad-subcharts.txt | 1 + pkg/cmd/testdata/output/lint-quiet-with-error.txt | 1 + pkg/lint/lint_test.go | 2 +- 4 files changed, 5 insertions(+), 1 deletion(-) diff --git a/pkg/cmd/testdata/output/lint-chart-with-bad-subcharts-with-subcharts.txt b/pkg/cmd/testdata/output/lint-chart-with-bad-subcharts-with-subcharts.txt index 6e2efcecd..2432563f5 100644 --- a/pkg/cmd/testdata/output/lint-chart-with-bad-subcharts-with-subcharts.txt +++ b/pkg/cmd/testdata/output/lint-chart-with-bad-subcharts-with-subcharts.txt @@ -3,6 +3,7 @@ [ERROR] templates/: error unpacking subchart bad-subchart in chart-with-bad-subcharts: validation: chart.metadata.name is required [ERROR] : unable to load chart error unpacking subchart bad-subchart in chart-with-bad-subcharts: validation: chart.metadata.name is required +[ERROR] crds/: error unpacking subchart bad-subchart in chart-with-bad-subcharts: validation: chart.metadata.name is required ==> Linting testdata/testcharts/chart-with-bad-subcharts/charts/bad-subchart [ERROR] Chart.yaml: name is required @@ -12,6 +13,7 @@ [ERROR] templates/: validation: chart.metadata.name is required [ERROR] : unable to load chart validation: chart.metadata.name is required +[ERROR] crds/: validation: chart.metadata.name is required ==> Linting testdata/testcharts/chart-with-bad-subcharts/charts/good-subchart [INFO] Chart.yaml: icon is recommended diff --git a/pkg/cmd/testdata/output/lint-chart-with-bad-subcharts.txt b/pkg/cmd/testdata/output/lint-chart-with-bad-subcharts.txt index af533797b..c514a100a 100644 --- a/pkg/cmd/testdata/output/lint-chart-with-bad-subcharts.txt +++ b/pkg/cmd/testdata/output/lint-chart-with-bad-subcharts.txt @@ -3,5 +3,6 @@ [ERROR] templates/: error unpacking subchart bad-subchart in chart-with-bad-subcharts: validation: chart.metadata.name is required [ERROR] : unable to load chart error unpacking subchart bad-subchart in chart-with-bad-subcharts: validation: chart.metadata.name is required +[ERROR] crds/: error unpacking subchart bad-subchart in chart-with-bad-subcharts: validation: chart.metadata.name is required Error: 1 chart(s) linted, 1 chart(s) failed diff --git a/pkg/cmd/testdata/output/lint-quiet-with-error.txt b/pkg/cmd/testdata/output/lint-quiet-with-error.txt index e3d29a5a3..f8ae55eb3 100644 --- a/pkg/cmd/testdata/output/lint-quiet-with-error.txt +++ b/pkg/cmd/testdata/output/lint-quiet-with-error.txt @@ -4,5 +4,6 @@ [ERROR] templates/: cannot load Chart.yaml: error converting YAML to JSON: yaml: line 6: did not find expected '-' indicator [ERROR] : unable to load chart cannot load Chart.yaml: error converting YAML to JSON: yaml: line 6: did not find expected '-' indicator +[ERROR] crds/: cannot load Chart.yaml: error converting YAML to JSON: yaml: line 6: did not find expected '-' indicator Error: 2 chart(s) linted, 1 chart(s) failed diff --git a/pkg/lint/lint_test.go b/pkg/lint/lint_test.go index 45e24f533..6c380409c 100644 --- a/pkg/lint/lint_test.go +++ b/pkg/lint/lint_test.go @@ -40,7 +40,7 @@ const invalidChartFileDir = "rules/testdata/invalidchartfile" func TestBadChart(t *testing.T) { m := RunAll(badChartDir, values, namespace).Messages - if len(m) != 8 { + if len(m) != 9 { t.Errorf("Number of errors %v", len(m)) t.Errorf("All didn't fail with expected errors, got %#v", m) }