From c78af5483c895fc4ccc204c350ed47b5da48fc17 Mon Sep 17 00:00:00 2001 From: Arash Deshmeh Date: Wed, 14 Feb 2018 10:42:39 -0500 Subject: [PATCH] fix(helm): fix the implicit dependency of TestSetAppVersion test on previous tests, due to helm home, by explicitly creating a temporary helm directory for the test. Signed-off-by: Arash Deshmeh --- cmd/helm/package_test.go | 16 ++++++++++++++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/cmd/helm/package_test.go b/cmd/helm/package_test.go index d338c29cd..4404586e0 100644 --- a/cmd/helm/package_test.go +++ b/cmd/helm/package_test.go @@ -205,7 +205,19 @@ func TestSetAppVersion(t *testing.T) { var ch *chart.Chart expectedAppVersion := "app-version-foo" tmp, _ := ioutil.TempDir("", "helm-package-app-version-") - defer os.RemoveAll(tmp) + + thome, err := tempHelmHome(t) + if err != nil { + t.Fatal(err) + } + cleanup := resetEnv() + defer func() { + os.RemoveAll(tmp) + os.RemoveAll(thome.String()) + cleanup() + }() + + settings.Home = helmpath.Home(thome) c := newPackageCmd(&bytes.Buffer{}) flags := map[string]string{ @@ -213,7 +225,7 @@ func TestSetAppVersion(t *testing.T) { "app-version": expectedAppVersion, } setFlags(c, flags) - err := c.RunE(c, []string{"testdata/testcharts/alpine"}) + err = c.RunE(c, []string{"testdata/testcharts/alpine"}) if err != nil { t.Errorf("unexpected error %q", err) }