diff --git a/cmd/helm/init.go b/cmd/helm/init.go index 4c8149188..54622e11b 100644 --- a/cmd/helm/init.go +++ b/cmd/helm/init.go @@ -121,8 +121,8 @@ func newInitCmd(out io.Writer) *cobra.Command { f.BoolVar(&i.opts.EnableHostNetwork, "net-host", false, "install Tiller with net=host") f.StringVar(&i.serviceAccount, "service-account", "", "name of service account") - f.StringVar(&i.opts.NodeSelectors, "node-selectors", "", "labels to select which node tiller lands on") - f.StringVarP(&i.opts.Output, "output", "o", "", "skip installation and output tiller's manifest in specified format (json,yaml)") + f.StringVar(&i.opts.NodeSelectors, "node-selectors", "", "labels to specify the node on which Tiller is installed (app=tiller,helm=rocks)") + f.StringVarP(&i.opts.Output, "output", "o", "", "skip installation and output Tiller's manifest in specified format (json or yaml)") f.StringArrayVar(&i.opts.Values, "set", []string{}, "set values for the Tiller Deployment manifest (can specify multiple or separate values with commas: key1=val1,key2=val2)") return cmd @@ -189,7 +189,6 @@ func (i *initCmd) run() error { return err } if len(i.opts.Output) > 0 { - var body string var err error if body, err = installer.DeploymentManifest(&i.opts); err != nil { diff --git a/cmd/helm/installer/options.go b/cmd/helm/installer/options.go index 83dcd6813..32cdae391 100644 --- a/cmd/helm/installer/options.go +++ b/cmd/helm/installer/options.go @@ -45,6 +45,7 @@ type Options struct { Namespace string // ServiceAccount is the Kubernetes service account to add to Tiller. + ServiceAccount string // ImageSpec indentifies the image Tiller will use when deployed. @@ -76,7 +77,7 @@ type Options struct { // NodeSelectors determine which nodes Tiller can land on NodeSelectors string - // Output dumps the Tiller manifest in the specified format (e.g. json) but skips Helm/Tiller installation + // Output dumps the Tiller manifest in the specified format (e.g. JSON) but skips Helm/Tiller installation Output string // Set merges additional values into the Tiller Deployment manifest @@ -106,8 +107,7 @@ func (opts *Options) tls() bool { return opts.EnableTLS || opts.VerifyTLS } // valuesMap returns user set values in map format func (opts *Options) valuesMap(m map[string]interface{}) (map[string]interface{}, error) { for _, skv := range opts.Values { - err := strvals.ParseInto(skv, m) - if err != nil { + if err := strvals.ParseInto(skv, m); err != nil { return nil, err } } diff --git a/docs/helm/helm_init.md b/docs/helm/helm_init.md index 5809c9c33..d80bb440f 100644 --- a/docs/helm/helm_init.md +++ b/docs/helm/helm_init.md @@ -38,9 +38,10 @@ helm init --dry-run do not install local or remote --local-repo-url string URL for local repository (default "http://127.0.0.1:8879/charts") --net-host install Tiller with net=host - --node-selectors string labels to select which node tiller lands on - -o, --output string skip installation and output tiller's manifest in specified format + --node-selectors string labels to specify the node on which Tiller is installed (app=tiller,helm=rocks) + -o, --output string skip installation and output Tiller's manifest in specified format (json or yaml) --service-account string name of service account + --set stringArray set values for the Tiller Deployment manifest (can specify multiple or separate values with commas: key1=val1,key2=val2) --skip-refresh do not refresh (download) the local repository cache --stable-repo-url string URL for stable repository (default "https://kubernetes-charts.storage.googleapis.com") -i, --tiller-image string override Tiller image