From d8c40403364c817315ca9de85ba5e371905e5d03 Mon Sep 17 00:00:00 2001 From: promalert Date: Tue, 11 Nov 2025 13:46:49 +0800 Subject: [PATCH] refactor: use strings.Builder to improve performance Signed-off-by: promalert --- pkg/action/uninstall.go | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/pkg/action/uninstall.go b/pkg/action/uninstall.go index 0cb31be43..d5474490c 100644 --- a/pkg/action/uninstall.go +++ b/pkg/action/uninstall.go @@ -242,9 +242,9 @@ func (u *Uninstall) deleteRelease(rel *release.Release) (kube.ResourceList, stri } filesToKeep, filesToDelete := filterManifestsToKeep(files) - var kept string + var kept strings.Builder for _, f := range filesToKeep { - kept += "[" + f.Head.Kind + "] " + f.Head.Metadata.Name + "\n" + fmt.Fprintf(&kept, "[%s] %s\n", f.Head.Kind, f.Head.Metadata.Name) } var builder strings.Builder @@ -259,7 +259,7 @@ func (u *Uninstall) deleteRelease(rel *release.Release) (kube.ResourceList, stri if len(resources) > 0 { _, errs = u.cfg.KubeClient.Delete(resources, parseCascadingFlag(u.DeletionPropagation)) } - return resources, kept, errs + return resources, kept.String(), errs } func parseCascadingFlag(cascadingFlag string) v1.DeletionPropagation {