From d7524abedff3a0b070da6868d4f187fb7ad1507f Mon Sep 17 00:00:00 2001 From: Morten Linderud Date: Tue, 1 Sep 2020 12:08:41 +0200 Subject: [PATCH] Makefile: Fix LDFLAGS overriding When distributions build software it's desirable to have the ability to define own linker flags, or Go flags. As `-ldflags` defined in `go build` overrides `-ldflags` defined in the env variable `GOFLAGS`, there is a distinct need to be able to replace the default values with new ones or append to them. Fixes #8645 Signed-off-by: Morten Linderud --- Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/Makefile b/Makefile index 85041f7f4..a9eac8033 100644 --- a/Makefile +++ b/Makefile @@ -50,6 +50,7 @@ endif LDFLAGS += -X helm.sh/helm/v3/internal/version.metadata=${VERSION_METADATA} LDFLAGS += -X helm.sh/helm/v3/internal/version.gitCommit=${GIT_COMMIT} LDFLAGS += -X helm.sh/helm/v3/internal/version.gitTreeState=${GIT_DIRTY} +LDFLAGS += $(EXT_LDFLAGS) .PHONY: all all: build