From d68d505afab2dae27433439a8ba4cf6b3075aba3 Mon Sep 17 00:00:00 2001 From: vaish123-fullstck Date: Fri, 27 Mar 2026 09:53:45 +0530 Subject: [PATCH] fix(getter): correct httpClient method and remove debug option reference Signed-off-by: vaish123-fullstck --- pkg/getter/httpgetter.go | 10 ++++++---- pkg/getter/httpgetter_test.go | 6 ++---- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/pkg/getter/httpgetter.go b/pkg/getter/httpgetter.go index 1477e0a5d..6b8a39b05 100644 --- a/pkg/getter/httpgetter.go +++ b/pkg/getter/httpgetter.go @@ -30,7 +30,7 @@ import ( "helm.sh/helm/v4/internal/version" ) -// 🔥 Constant for session header +// Add constant (minimal addition) const helmSessionHeader = "helm-session" // HTTPGetter is the default HTTP(/S) backend handler @@ -38,7 +38,9 @@ type HTTPGetter struct { opts getterOptions transport *http.Transport once sync.Once - sessionID string // 🔥 Stores session ID for request grouping + + // Add session field (minimal addition) + sessionID string } // Get performs a Get from repo.Getter and returns the body. @@ -56,7 +58,7 @@ func (g *HTTPGetter) get(href string, opts getterOptions) (*bytes.Buffer, error) return nil, err } - // 🔥 Add Helm session header to group requests from a single command execution + // Set helm session header for traceability if g.sessionID != "" { req.Header.Set(helmSessionHeader, g.sessionID) } @@ -113,7 +115,7 @@ func NewHTTPGetter(options ...Option) (Getter, error) { opt(&client.opts) } - // 🔥 Generate session ID once per getter instance + // Generate session ID (minimal addition) client.sessionID = uuid.New().String() return &client, nil diff --git a/pkg/getter/httpgetter_test.go b/pkg/getter/httpgetter_test.go index c687dd147..698a8a53a 100644 --- a/pkg/getter/httpgetter_test.go +++ b/pkg/getter/httpgetter_test.go @@ -688,22 +688,20 @@ func TestHTTPGetterSessionHeader(t *testing.T) { })) defer srv.Close() + // Create getter for HTTP session header test g, err := NewHTTPGetter(WithURL(srv.URL)) if err != nil { t.Fatal(err) } - // First request if _, err := g.Get(srv.URL); err != nil { t.Fatal(err) } - // Second request (to verify persistence) if _, err := g.Get(srv.URL); err != nil { t.Fatal(err) } - // Read headers safely h1 := <-headerChan h2 := <-headerChan @@ -712,6 +710,6 @@ func TestHTTPGetterSessionHeader(t *testing.T) { } if h1 != h2 { - t.Errorf("expected session ID to be reused, but got %s and %s", h1, h2) + t.Errorf("expected same session ID, got %s and %s", h1, h2) } }