From d552cb3b1d491f4a1aa170d9903a897c1e9ffc7f Mon Sep 17 00:00:00 2001 From: Daniel Lipovetsky Date: Tue, 15 Dec 2020 10:00:07 -0800 Subject: [PATCH] fix(pkg/storage): If storage.Create fails to clean up recent release versions, return an error Previously, storage.Create was ignoring the error. This meant that a user that relied on the recent release version cleanup would not be notified if that cleanup failed, and release versions could grow without bound. Closes #9145 Signed-off-by: Daniel Lipovetsky (cherry picked from commit 00cf10d360de3fbe440789ee51662c2894e041ce) --- pkg/storage/storage.go | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/pkg/storage/storage.go b/pkg/storage/storage.go index 2dfa3f615..cfc0d0deb 100644 --- a/pkg/storage/storage.go +++ b/pkg/storage/storage.go @@ -61,7 +61,10 @@ func (s *Storage) Create(rls *rspb.Release) error { s.Log("creating release %q", makeKey(rls.Name, rls.Version)) if s.MaxHistory > 0 { // Want to make space for one more release. - s.removeLeastRecent(rls.Name, s.MaxHistory-1) + if err := s.removeLeastRecent(rls.Name, s.MaxHistory-1); err != nil && + !errors.Is(err, driver.ErrReleaseNotFound) { + return err + } } return s.Driver.Create(makeKey(rls.Name, rls.Version), rls) }