From 8ecf42034f143d77e99d44a8de8aa50348b9bc83 Mon Sep 17 00:00:00 2001 From: Byeongjae Jung Date: Tue, 18 Jul 2023 11:33:20 +0900 Subject: [PATCH 1/3] add test code --- pkg/storage/driver/secrets_test.go | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+) diff --git a/pkg/storage/driver/secrets_test.go b/pkg/storage/driver/secrets_test.go index d509c7b3a..f6df0fcfa 100644 --- a/pkg/storage/driver/secrets_test.go +++ b/pkg/storage/driver/secrets_test.go @@ -128,6 +128,18 @@ func TestSecretList(t *testing.T) { if len(ssd) != 2 { t.Errorf("Expected 2 superseded, got %d", len(ssd)) } + + // list all release with labels + lbl, err := secrets.List(func(_ *rspb.Release) bool { return true }) + if err != nil { + t.Fatalf("Failed to query: %s", err) + } + + for _, r := range lbl { + if r.Labels == nil { + t.Fatalf("Expected release labels is nil") + } + } } func TestSecretQuery(t *testing.T) { @@ -152,6 +164,18 @@ func TestSecretQuery(t *testing.T) { if err != ErrReleaseNotFound { t.Errorf("Expected {%v}, got {%v}", ErrReleaseNotFound, err) } + + // query secret with labels + rlb, err := secrets.Query(map[string]string{}) + if err != nil { + t.Fatalf("Failed to query: %s", err) + } + + for _, r := range rlb { + if r.Labels == nil { + t.Fatalf("Expected release labels is nil") + } + } } func TestSecretCreate(t *testing.T) { From 248d2c7b674378f3289bc934055d0156fd395713 Mon Sep 17 00:00:00 2001 From: Byeongjae Jung Date: Tue, 18 Jul 2023 11:40:23 +0900 Subject: [PATCH 2/3] Update secrets_test.go Signed-off-by: Byeongjae Jung Signed-off-by: Byeongjae Jung --- pkg/storage/driver/secrets_test.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkg/storage/driver/secrets_test.go b/pkg/storage/driver/secrets_test.go index f6df0fcfa..238abe783 100644 --- a/pkg/storage/driver/secrets_test.go +++ b/pkg/storage/driver/secrets_test.go @@ -165,7 +165,7 @@ func TestSecretQuery(t *testing.T) { t.Errorf("Expected {%v}, got {%v}", ErrReleaseNotFound, err) } - // query secret with labels + // query secrets with labels rlb, err := secrets.Query(map[string]string{}) if err != nil { t.Fatalf("Failed to query: %s", err) From eeebbc10628d3c33248e10fb254b2b7ff425d500 Mon Sep 17 00:00:00 2001 From: Byeongjae Jung Date: Tue, 18 Jul 2023 11:50:05 +0900 Subject: [PATCH 3/3] Update secrets_test.go chore Signed-off-by: Byeongjae Jung --- pkg/storage/driver/secrets_test.go | 1 + 1 file changed, 1 insertion(+) diff --git a/pkg/storage/driver/secrets_test.go b/pkg/storage/driver/secrets_test.go index 238abe783..b3b326c73 100644 --- a/pkg/storage/driver/secrets_test.go +++ b/pkg/storage/driver/secrets_test.go @@ -171,6 +171,7 @@ func TestSecretQuery(t *testing.T) { t.Fatalf("Failed to query: %s", err) } + // check for _, r := range rlb { if r.Labels == nil { t.Fatalf("Expected release labels is nil")