From d0a4d63fb242dc57e6e845395c16705f4ca3d308 Mon Sep 17 00:00:00 2001
From: Richard Shade <richard@pulumi.com>
Date: Wed, 10 Apr 2024 08:24:59 -0500
Subject: [PATCH] Adding in basic retries for 502/503 in the HTTP Getter

Signed-off-by: Richard Shade <richard@pulumi.com>
---
 pkg/getter/httpgetter.go | 66 ++++++++++++++++++++++++++++++++++------
 1 file changed, 57 insertions(+), 9 deletions(-)

diff --git a/pkg/getter/httpgetter.go b/pkg/getter/httpgetter.go
index b53e558e3..1738cf285 100644
--- a/pkg/getter/httpgetter.go
+++ b/pkg/getter/httpgetter.go
@@ -18,10 +18,12 @@ package getter
 import (
 	"bytes"
 	"crypto/tls"
+	"fmt"
 	"io"
 	"net/http"
 	"net/url"
 	"sync"
+	"time"
 
 	"github.com/pkg/errors"
 
@@ -83,18 +85,64 @@ func (g *HTTPGetter) get(href string) (*bytes.Buffer, error) {
 		return nil, err
 	}
 
-	resp, err := client.Do(req)
-	if err != nil {
-		return nil, err
+	// Define the maximum number of retries
+	maxRetries := 20
+
+	// Define retryable status codes
+	retryableCodes := map[int]bool{
+		http.StatusBadGateway:         true, // 502
+		http.StatusServiceUnavailable: true, // 503
 	}
-	defer resp.Body.Close()
-	if resp.StatusCode != http.StatusOK {
-		return nil, errors.Errorf("failed to fetch %s : %s", href, resp.Status)
+
+	for attempt := 0; attempt < maxRetries; attempt++ {
+		resp, err := client.Do(req)
+
+		if err != nil {
+			if attempt < (maxRetries - 1) {
+				fmt.Printf("Error: %v\n", err)
+				// Sleep for a short duration before retrying
+				time.Sleep(1 * time.Second)
+				continue
+			}
+
+			return nil, err
+		}
+
+		respStatus := resp.Status
+		defer resp.Body.Close()
+
+		// Check the status code
+		if _, ok := retryableCodes[resp.StatusCode]; ok {
+			if attempt < (maxRetries - 1) {
+				fmt.Printf("Received retryable status code: %v\n", resp.StatusCode)
+				// Close the response body
+				resp.Body.Close()
+				// Sleep for a short duration before retrying
+				time.Sleep(1 * time.Second)
+				continue
+			}
+			return nil, errors.Errorf("failed to fetch %s : %s", href, respStatus)
+		}
+
+		if resp.StatusCode != http.StatusOK {
+			if attempt < (maxRetries - 1) {
+				fmt.Printf("Received non-OK status code: %v\n", resp.StatusCode)
+				// Close the response body
+				resp.Body.Close()
+				// Sleep for a short duration before retrying
+				time.Sleep(1 * time.Second)
+				continue
+			}
+			return nil, errors.Errorf("failed to fetch %s : %s", href, respStatus)
+		}
+
+		// Process the response
+		buf := bytes.NewBuffer(nil)
+		_, err = io.Copy(buf, resp.Body)
+		return buf, err
 	}
 
-	buf := bytes.NewBuffer(nil)
-	_, err = io.Copy(buf, resp.Body)
-	return buf, err
+	return nil, fmt.Errorf("maximum retries exceeded")
 }
 
 // NewHTTPGetter constructs a valid http/https client as a Getter