From ce1a46899f5b1e7ba9d485d7800d0d23313d7d7b Mon Sep 17 00:00:00 2001 From: rimas Date: Tue, 1 Dec 2020 18:50:14 +0200 Subject: [PATCH] Fixes #9083 Signed-off-by: rimas --- cmd/helm/testdata/testcharts/chart-with-only-crds/Chart.yaml | 4 ++-- pkg/chartutil/create.go | 3 ++- pkg/lint/rules/testdata/multi-template-fail/Chart.yaml | 4 ++-- pkg/lint/rules/testdata/v3-fail/Chart.yaml | 4 ++-- 4 files changed, 8 insertions(+), 7 deletions(-) diff --git a/cmd/helm/testdata/testcharts/chart-with-only-crds/Chart.yaml b/cmd/helm/testdata/testcharts/chart-with-only-crds/Chart.yaml index a8b4c2022..54a84c1ed 100644 --- a/cmd/helm/testdata/testcharts/chart-with-only-crds/Chart.yaml +++ b/cmd/helm/testdata/testcharts/chart-with-only-crds/Chart.yaml @@ -17,5 +17,5 @@ type: application version: 0.1.0 # This is the version number of the application being deployed. This version number should be -# incremented each time you make changes to the application. -appVersion: 1.16.0 +# incremented each time you make changes to the application and recommended to use it with quotes. +appVersion: "1.16.0" diff --git a/pkg/chartutil/create.go b/pkg/chartutil/create.go index 6cd0a00ea..b6dffb231 100644 --- a/pkg/chartutil/create.go +++ b/pkg/chartutil/create.go @@ -99,7 +99,8 @@ version: 0.1.0 # This is the version number of the application being deployed. This version number should be # incremented each time you make changes to the application. Versions are not expected to # follow Semantic Versioning. They should reflect the version the application is using. -appVersion: 1.16.0 +# It is recommended to use it with quotes. +appVersion: "1.16.0" ` const defaultValues = `# Default values for %s. diff --git a/pkg/lint/rules/testdata/multi-template-fail/Chart.yaml b/pkg/lint/rules/testdata/multi-template-fail/Chart.yaml index f022d5ad9..e59040368 100644 --- a/pkg/lint/rules/testdata/multi-template-fail/Chart.yaml +++ b/pkg/lint/rules/testdata/multi-template-fail/Chart.yaml @@ -17,5 +17,5 @@ type: application version: 0.1.0 # This is the version number of the application being deployed. This version number should be -# incremented each time you make changes to the application. -appVersion: 1.16.0 +# incremented each time you make changes to the application and recommended to use it with quotes. +appVersion: "1.16.0" diff --git a/pkg/lint/rules/testdata/v3-fail/Chart.yaml b/pkg/lint/rules/testdata/v3-fail/Chart.yaml index efbad1c86..7d48edba7 100644 --- a/pkg/lint/rules/testdata/v3-fail/Chart.yaml +++ b/pkg/lint/rules/testdata/v3-fail/Chart.yaml @@ -17,5 +17,5 @@ type: application version: 0.1.0 # This is the version number of the application being deployed. This version number should be -# incremented each time you make changes to the application. -appVersion: 1.16.0 +# incremented each time you make changes to the application and recommended to use it with quotes. +appVersion: "1.16.0"