From cd399dd1400c962a88247b84db5a2bf6935d73c8 Mon Sep 17 00:00:00 2001 From: Ali Date: Sat, 18 Apr 2026 04:21:02 +0500 Subject: [PATCH] pkg/kube: promote statusWaiter wait-progress messages to Info SDK users who do not enable debug logging see no output when the status waiter is running, even though the legacy waiter printed resource-readiness progress to stdout. The statusWaiter's "waiting for resources" and "all resources achieved desired status" messages were both at slog.Debug level, invisible unless --debug is passed. Promote these five calls to slog.Info so that SDK callers that set up a logger at Info level (the default) see meaningful wait progress without needing to enable debug. The per-resource "waiting for resource" poll callback remains at Debug since it fires on every poll cycle and would be too noisy at Info. Fixes #31585 Signed-off-by: Ali --- pkg/kube/statuswait.go | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/pkg/kube/statuswait.go b/pkg/kube/statuswait.go index 59c1218ff..e063ec580 100644 --- a/pkg/kube/statuswait.go +++ b/pkg/kube/statuswait.go @@ -74,7 +74,7 @@ func (w *statusWaiter) WatchUntilReady(resourceList ResourceList, timeout time.D } ctx, cancel := w.contextWithTimeout(w.watchUntilReadyCtx, timeout) defer cancel() - w.Logger().Debug("waiting for resources", "count", len(resourceList), "timeout", timeout) + w.Logger().Info("waiting for resources", "count", len(resourceList), "timeout", timeout) sw := watcher.NewDefaultStatusWatcher(w.client, w.restMapper) jobSR := helmStatusReaders.NewCustomJobStatusReader(w.restMapper) podSR := helmStatusReaders.NewCustomPodStatusReader(w.restMapper) @@ -96,7 +96,7 @@ func (w *statusWaiter) Wait(resourceList ResourceList, timeout time.Duration) er } ctx, cancel := w.contextWithTimeout(w.waitCtx, timeout) defer cancel() - w.Logger().Debug("waiting for resources", "count", len(resourceList), "timeout", timeout) + w.Logger().Info("waiting for resources", "count", len(resourceList), "timeout", timeout) sw := watcher.NewDefaultStatusWatcher(w.client, w.restMapper) sw.StatusReader = statusreaders.NewStatusReader(w.restMapper, w.readers...) return w.wait(ctx, resourceList, sw) @@ -108,7 +108,7 @@ func (w *statusWaiter) WaitWithJobs(resourceList ResourceList, timeout time.Dura } ctx, cancel := w.contextWithTimeout(w.waitWithJobsCtx, timeout) defer cancel() - w.Logger().Debug("waiting for resources", "count", len(resourceList), "timeout", timeout) + w.Logger().Info("waiting for resources", "count", len(resourceList), "timeout", timeout) sw := watcher.NewDefaultStatusWatcher(w.client, w.restMapper) newCustomJobStatusReader := helmStatusReaders.NewCustomJobStatusReader(w.restMapper) readers := append([]engine.StatusReader(nil), w.readers...) @@ -124,7 +124,7 @@ func (w *statusWaiter) WaitForDelete(resourceList ResourceList, timeout time.Dur } ctx, cancel := w.contextWithTimeout(w.waitForDeleteCtx, timeout) defer cancel() - w.Logger().Debug("waiting for resources to be deleted", "count", len(resourceList), "timeout", timeout) + w.Logger().Info("waiting for resources to be deleted", "count", len(resourceList), "timeout", timeout) sw := watcher.NewDefaultStatusWatcher(w.client, w.restMapper) return w.waitForDelete(ctx, resourceList, sw) } @@ -255,7 +255,7 @@ func statusObserver(cancel context.CancelFunc, desired status.Status, logger *sl } if aggregator.AggregateStatus(rss, desired) == desired { - logger.Debug("all resources achieved desired status", "desiredStatus", desired, "resourceCount", len(rss)) + logger.Info("all resources achieved desired status", "desiredStatus", desired, "resourceCount", len(rss)) cancel() return }